Re: Pull Request 164

2023-02-12 Thread Matthias Seidel
Hi Damjan, Thanks! Since AOO42X was split from trunk it should not be very different... I will try to build on Windows now. Regards,    Matthias Am 12.02.23 um 20:02 schrieb Damjan Jovanovic: > It's in AOO42X too now. > > Damjan > > On Sun, Feb 12, 2023 at 3:10 PM Damjan Jovanovic wrote: > >

Re: Pull Request 164

2023-02-12 Thread Damjan Jovanovic
It's in AOO42X too now. Damjan On Sun, Feb 12, 2023 at 3:10 PM Damjan Jovanovic wrote: > Hi > > I've now merged it. > > Should we also cherry-pick it into AOO42X? I am currently testing it there. > > Regards > Damjan > > On Sat, Feb 11, 2023 at 1:14 PM Matthias Seidel < > matthias.sei...@hambur

Re: Pull Request 164

2023-02-12 Thread Damjan Jovanovic
Hi I've now merged it. Should we also cherry-pick it into AOO42X? I am currently testing it there. Regards Damjan On Sat, Feb 11, 2023 at 1:14 PM Matthias Seidel wrote: > So at least 3 people are interested in this big enhancement... > > @Damjan: I would say, merge it! We need to move forward

[GitHub] [openoffice] DamjanJovanovic merged pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-12 Thread via GitHub
DamjanJovanovic merged PR #164: URL: https://github.com/apache/openoffice/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openo

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-11 Thread Matthias Seidel
Hi Pedro, Am 11.02.23 um 23:28 schrieb Pedro Lino: > Hi Matthias > > No problem opening both files in RC1 under Ubuntu x64 Yes, Damjan fixed a lot of these issues... But let's keep that separate. Regards,    Matthias > > Best, > Pedro > >> On 02/11/2023 8:52 PM WET Matthias Seidel wrote: >>

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-11 Thread Pedro Lino
Hi Matthias No problem opening both files in RC1 under Ubuntu x64 Best, Pedro > On 02/11/2023 8:52 PM WET Matthias Seidel wrote: > > > Hi, > > Am 11.02.23 um 21:46 schrieb Czesław Wolański: > > Hi, > > > >> What file did you use? > > The one you mentioned i.e. .xlsx from > > https://bz.apac

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-11 Thread Matthias Seidel
Hi, Am 11.02.23 um 21:46 schrieb Czesław Wolański: > Hi, > >> What file did you use? > The one you mentioned i.e. .xlsx from > https://bz.apache.org/ooo/show_bug.cgi?id=126720 Yes, that patch is in 4.1.14 but not in Damjan's branch. Remember that this PR is from early January... ;-) Try to open

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-11 Thread Czesław Wolański
Hi, > What file did you use? The one you mentioned i.e. .xlsx from https://bz.apache.org/ooo/show_bug.cgi?id=126720 Regards, Czesław Am Sa., 11. Feb. 2023 um 21:42 Uhr schrieb Matthias Seidel < matthias.sei...@hamburg.de>: > Hi, > > I have updated my comment. > > What file did you use? > > R

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-11 Thread Matthias Seidel
Hi, I have updated my comment. What file did you use? Regards,    Matthias Am 11.02.23 um 21:38 schrieb Czesław Wolański: > Hi, > > > I confirm. Cyrillic characters are missing. > > Regards, > Czesław > > Am Sa., 11. Feb. 2023 um 20:17 Uhr schrieb Pilot-Pirx (via GitHub) < > g...@apache.org>:

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-11 Thread Czesław Wolański
Hi, I confirm. Cyrillic characters are missing. Regards, Czesław Am Sa., 11. Feb. 2023 um 20:17 Uhr schrieb Pilot-Pirx (via GitHub) < g...@apache.org>: > > Pilot-Pirx commented on PR #164: > URL: https://github.com/apache/openoffice/pull/164#issuecomment-1426857635 > >I am having problems

[GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-11 Thread via GitHub
Pilot-Pirx commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1426857635 I am having problems with an xlsx file containing Cyrillic characters. Only the numbers are imported. It may only be my machine. -- This is an automated message from the Apache Git

Re: Pull Request 164

2023-02-11 Thread Matthias Seidel
So at least 3 people are interested in this big enhancement... @Damjan: I would say, merge it! We need to move forward. Regards,    Matthias Am 10.02.23 um 17:00 schrieb Matthias Seidel: > Hi Carl, > > Am 07.02.23 um 15:10 schrieb Carl Marcum: >> Hi All, >> >> On 2/7/23 5:46 AM, Matthias Seidel

[GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-02-10 Thread via GitHub
Pilot-Pirx commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1426053986 My test on Windows with this table: https://home.apache.org/~cmarcum/test-files/2-row-html-table.html was successful! -- This is an automated message from the Apache Gi

Re: Pull Request 164

2023-02-10 Thread Matthias Seidel
Hi Carl, Am 07.02.23 um 15:10 schrieb Carl Marcum: > Hi All, > > On 2/7/23 5:46 AM, Matthias Seidel wrote: >> Hi all, >> >> PR #164 [1] is a huge one. >> >> It would be great if there was additional feedback... >> >> Regards, >> >>     Matthias >> >> [1] https://github.com/apache/openoffice/pull/1

Re: Pull Request 164

2023-02-07 Thread Carl Marcum
Hi All, On 2/7/23 5:46 AM, Matthias Seidel wrote: Hi all, PR #164 [1] is a huge one. It would be great if there was additional feedback... Regards,    Matthias [1] https://github.com/apache/openoffice/pull/164 A good test for this is to open this test file [1] in a browser and copy/past

Pull Request 164

2023-02-07 Thread Matthias Seidel
Hi all, PR #164 [1] is a huge one. It would be great if there was additional feedback... Regards,    Matthias [1] https://github.com/apache/openoffice/pull/164 smime.p7s Description: S/MIME Cryptographic Signature

[GitHub] [openoffice] cbmarcum commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-07 Thread GitBox
cbmarcum commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374548388 > > Copy/Paste from Firefox to Calc trunk and this PR all 2 rows for both > > There is no way all 2 pasted successfully over HTML on trunk. Either the transfer format wasn

[GitHub] [openoffice] DamjanJovanovic commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-07 Thread GitBox
DamjanJovanovic commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-137456 > Copy/Paste from Firefox to Calc trunk and this PR all 2 rows for both There is no way all 2 pasted successfully over HTML on trunk. Either the transfer format was

[GitHub] [openoffice] cbmarcum commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-07 Thread GitBox
cbmarcum commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374528032 My latest testing: File > Open set file type filter to HTML Document (OpenOffice Calc) (*.html;*.htm) trunk got to row 13106 with PR 164 got all 2 rows ---

[GitHub] [openoffice] DamjanJovanovic commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-06 Thread GitBox
DamjanJovanovic commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374407466 I believe the Writer table limit of 64K cells is unrelated to this issue. For example in main/sw/source/filter/html/htmltab.cxx: ``` class HTMLTable { ...

[GitHub] [openoffice] DamjanJovanovic commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-06 Thread GitBox
DamjanJovanovic commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374378198 > When I open it with my build of this PR on CentOS 7 it still only opens into a Writer/HTML document to the row 12801 before starting to just produce text beyond that. Same as w

[GitHub] [openoffice] cbmarcum commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-06 Thread GitBox
cbmarcum commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374199770 H Damjan, Thanks for your work on this. I made a slight change to the html test file from i117635 by removing the first row so that cell A1 was in the first row. See link [1].

[GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-05 Thread GitBox
Pilot-Pirx commented on PR #164: URL: https://github.com/apache/openoffice/pull/164#issuecomment-1372114965 Hi Damjan, this is a great amount of work, thank you! I will try to do a build on Windows and test some files... -- This is an automated message from the Apache Git Service. To

Re: [GitHub] [openoffice] DamjanJovanovic opened a new pull request, #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-03 Thread Dirk-Willem van Gulik
On 3 Jan 2023, at 05:51, GitBox wrote: > > DamjanJovanovic opened a new pull request, #164: > URL: https://github.com/apache/openoffice/pull/164 > > Our EditEngine, in main/editeng, has a number of containers for paragraphs, > paragraph portions, lines, etc. These are base

[GitHub] [openoffice] DamjanJovanovic opened a new pull request, #164: Update EditEngine code to use 32 bit paragraph storage

2023-01-02 Thread GitBox
DamjanJovanovic opened a new pull request, #164: URL: https://github.com/apache/openoffice/pull/164 Our EditEngine, in main/editeng, has a number of containers for paragraphs, paragraph portions, lines, etc. These are based on svl's "PTRARR" type classes, which is just a