Re: Exporting symbols from AOO shared libraries

2016-04-02 Thread Damjan Jovanovic
The patch is on https://bz.apache.org/ooo/show_bug.cgi?id=126901. The sc module that my patch affects, doesn't export any headers, so exporting the symbol still doesn't allow anyone to compile against it, only to link once they have compiled. In the sw module which also doesn't export any headers

Re: Exporting symbols from AOO shared libraries

2016-04-02 Thread Patricia Shanahan
A difficult one. I don't like making things public just to support testing, because later on, when someone wants to make changes, it is impossible to tell whether they can or not. In a simpler project, I might suggest doing separate builds for testing, but I hesitate to add to the AOO build

Exporting symbols from AOO shared libraries

2016-04-02 Thread Damjan Jovanovic
Hi I am trying to add a unit test to Calc, and the C++ class I want to test (ScStringUtil) isn't exported from its library (with SC_DLLPUBLIC), so my test is failing to link. Can I export that class? What determines when we can/should? Thank you Damjan --