dave2wave commented on PR #322:
URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692906697
https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/detect_aws_credentials.py
It looks like this is more about the environment that the precook is running
jbampton commented on PR #322:
URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692884291
Hi @dave2wave I think the AWS check/hook would fail if it finds AWS
credentials in the repo.
So then for us it would be like a security check locally to warn when AWS
credenti
jbampton commented on code in PR #322:
URL: https://github.com/apache/openoffice/pull/322#discussion_r1976719141
##
.pre-commit-config.yaml:
##
@@ -32,8 +32,11 @@ repos:
- id: check-illegal-windows-names
- id: check-merge-conflict
- id: check-vcs-permalinks
dave2wave commented on PR #322:
URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692879585
I don't think we have any use of aws cli. How is the detect-aws-credentials
check helpful for us? Is there a better check that is similar?
--
This is an automated message from the Ap
jbampton commented on PR #322:
URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692861064
Yes the `fix-byte-order-marker` hook passed.
I think it is still good to have this check so that we don't regress
backwards.
The run still takes about two minutes.
--
Th
Pilot-Pirx commented on PR #322:
URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692862241
Definitely!
I did all that "by hand" ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Pilot-Pirx commented on PR #322:
URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692858879
Regarding BOM:
I think I removed all of them (hopefully)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jbampton opened a new pull request, #322:
URL: https://github.com/apache/openoffice/pull/322
https://github.com/pre-commit/pre-commit-hooks#detect-aws-credentials
https://github.com/pre-commit/pre-commit-hooks#fix-byte-order-marker
Both checks/hooks/tests already pass. Good to
