Pilot-Pirx merged PR #238:
URL: https://github.com/apache/openoffice/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice
Pilot-Pirx commented on code in PR #238:
URL: https://github.com/apache/openoffice/pull/238#discussion_r1900206798
##
main/automation/source/server/recorder.cxx:
##
Review Comment:
Often German Umlauts were replaced:
ä -> ae
ö -> oe
ü -> ue
ß -> ss
I also saw
Pilot-Pirx commented on code in PR #238:
URL: https://github.com/apache/openoffice/pull/238#discussion_r1900206798
##
main/automation/source/server/recorder.cxx:
##
Review Comment:
Often German Umlauts were replaced:
ä -> ae
ö -> oe
ü -> ue
ß -> ss
I also saw
Pilot-Pirx commented on code in PR #238:
URL: https://github.com/apache/openoffice/pull/238#discussion_r1900206798
##
main/automation/source/server/recorder.cxx:
##
Review Comment:
Often German Umlauts were replaced:
ä -> ae
ö -> oe
ü -> ue
ß -> ss
I also saw
jbampton commented on code in PR #238:
URL: https://github.com/apache/openoffice/pull/238#discussion_r1900205357
##
main/automation/source/server/recorder.cxx:
##
Review Comment:
Some of these German words have found their way into our codespell ignored
words list in #191
Pilot-Pirx commented on code in PR #238:
URL: https://github.com/apache/openoffice/pull/238#discussion_r1900203619
##
main/automation/source/server/recorder.cxx:
##
Review Comment:
Yes, still old German comments from the time where no Unicode was used... ;-)
--
This is
jbampton commented on code in PR #238:
URL: https://github.com/apache/openoffice/pull/238#discussion_r1900199682
##
main/automation/source/server/recorder.cxx:
##
@@ -586,7 +586,7 @@ IMPL_LINK( MacroRecorder, EventListener, VclSimpleEvent*,
pEvent )
jbampton opened a new pull request, #238:
URL: https://github.com/apache/openoffice/pull/238
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
