On 20 Jun, Yury Tarasievich wrote:
> Hello Peter,
>
> You are right on both issues, of course.
>
> To be fair, on your (1), I didn't touch that
> variable check, I just brute-forced the C++11
> mode of compilation.
>
> Which leads to your (2), but thing is, modern
> boost sort of requires C++
DonLewisFreeBSD commented on pull request #133:
URL: https://github.com/apache/openoffice/pull/133#issuecomment-864508440
> The meaing of the Flag is
> -Werror: every warning is treated as an error.
>
> Since Grafite is a dependency it is fine to build without. However Imho we
sho
Hello Peter,
You are right on both issues, of course.
To be fair, on your (1), I didn't touch that
variable check, I just brute-forced the C++11
mode of compilation.
Which leads to your (2), but thing is, modern
boost sort of requires C++11. Might be other
external modules do, too.
Might
Hi Yuri,
Nice work! However there is more then One change I am unsure about.
# you removed the __cplusplus string check. I think that is a bit hacky.
It would have benn better to check the content and add it with or
# switching to C11 -> we should do this and start refactoring the code
to th
leginee commented on pull request #133:
URL: https://github.com/apache/openoffice/pull/133#issuecomment-864492889
The meaing of the Flag is
-Werror: every warning is treated as an error.
Since Grafite is a dependency it is fine to build without. However Imho we
should strife for r
ardovm opened a new pull request #133:
URL: https://github.com/apache/openoffice/pull/133
The flag is set by default by the graphite configure script, but it lets the
compilation fail with gcc 7.5
The compilation of the graphite module is consistently failing on openSUSE
Leap 15.2 x
On 2021/06/18 07:08:17, Yury Tarasievich wrote
...
I've managed to actually finish the build with
the changes:
https://gist.github.com/yurytch/9725e3281f9ef784cbf865fcebf51517
(plus some info in two comments)
This is of course a kludge cubed, but at the
moment it seems to serve. I didn't se
Pilot-Pirx merged pull request #15:
URL: https://github.com/apache/openoffice/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea