RE: Will a PR be ignored if it fails checks?

Hi Tim, Please fix the warning / error without waiting for someone to review it. Best regards Alin -Original Message- From: Tim Hardisty Sent: den 15 november 2022 20:25 To: dev@nuttx.apache.org Subject: Will a PR be ignored if it fails checks? As subject really. My (first real) PR

Re: Will a PR be ignored if it fails checks?

Hi Alin, Ok - will do. I ran the checkpatch script as per guides - should I have done something else as well before submitting a PR? Thanks, Tim. On 16/11/2022, 08:00, "alin.jerpe...@sony.com" wrote: Hi Tim, Please fix the warning / error without waiting for someone to review it.

Re: Will a PR be ignored if it fails checks?

Thanks Nathan - I have already left such a comment on the PR. On 15/11/2022, 22:14, "Nathan Hartman" wrote: On Tue, Nov 15, 2022 at 2:25 PM Tim Hardisty wrote: > As subject really. My (first real) PR failed some checks due to an unused > variable. An easy fix, but I wanted to

RE: Will a PR be ignored if it fails checks?

Hi Tim, I usually do the following steps: - compile locally the patch and test it - run nxstyle to ensure that there are no errors - let the CI run and fix errors - wait for others to review and comment Best regards Alin -Original Message- From: Tim Hardisty Sent: den 16 november