Re: FS automount: callback when FS is mounted

Hello Gregory, I made some progress with this activity. Will appreciate your review https://github.com/apache/incubator-nuttx/pull/5345 Best regards, Petro чт, 2 груд. 2021 р. о 01:42 Gregory Nutt пише: > > > But ai think that the approach with a signal will require turning > automount > > into

is CODE keyword still used?

Hello team, Recently I noticed that some structures in common code use CODE keyword for pointers to functions and some do not, so I have the question: is CODE keyword still supported? Here are few examples: struct automount_lower_s { ... CODE int (*attach)(FAR const struct automount_lower_s *low

Re: is CODE keyword still used?

Hi Petro, It is used by Z80, Z180 and Z16/ZNEO, see include/nuttx/compiler.h for reference. BR, Alan On 1/26/22, Petro Karashchenko wrote: > Hello team, > > Recently I noticed that some structures in common code use CODE > keyword for pointers to functions and some do not, so I have the > ques

Re: is CODE keyword still used?

Hello Alan, Yeah, I see that. But since CODE is missing for the most of the pointers to functions in common code I just wonder how that platform works. None of FS operations in include/nuttx/fs/fs.h have CODE. Does this mean that Z80, Z180 and Z16/ZNEO do not use FS as all? And another question i

Re: is CODE keyword still used?

Hey Petro, The CODE is used on function pointers, so I think it is ok in the FS code. BR, Alan On 1/26/22, Petro Karashchenko wrote: > Hello Alan, > > Yeah, I see that. But since CODE is missing for the most of the > pointers to functions in common code I just wonder how that platform > works.

Re: is CODE keyword still used?

Hello Alan, Maybe you misread the header file. Here are few examples of what is in include/nuttx/fs/fs.h struct file_operations { /* The device driver open method differs from the mountpoint open method */ int (*open)(FAR struct file *filep); /* The following methods must be identical

Re: is CODE keyword still used?

Sorry Petro, I missed that files! Maybe Greg could explain why it is missing or if it is not necessary. Should be nice if we could find a wait to instruct the compiler (or the building system) to include the typedefed CODE to the pointer functions automatically, but I don't know if it is possible

Re: is CODE keyword still used?

It is required for any CPU architecture that has asymmetry in code and data space addresses. It is a bad idea to remove it. There is no benefit to remonving it and there is most certainly a downside. On Wed, Jan 26, 2022 at 7:06 AM Petro Karashchenko < petro.karashche...@gmail.com> wrote: > Hel

Re: SD Card in Simulation

Hostfs is exactly what I need. Thank you! On Mon, Jan 24, 2022, 17:21 Sebastien Lorquet wrote: > Hi > > The closest way to achieve this, eg if you want to exercise the SD > drivers, would be to simulate a SPI/SD device that the main SD driver > could talk to. > > The simulated SPI or SD would ha

Re: is CODE keyword still used?

Hello Gregory, The question is more about should we populate it to missing places, or just keep as is until someone complains (hopefully should never happen). I'm asking it because automounter structures are equipped with CODE, but all the FS structures are not and that seems very inconsistent to

Re: is CODE keyword still used?

You would think it should be used with AVR since the data pointer is typically 16-bits and the instruction pointer is typically 20-24 bits. But it is not, that is because 1) GCC does support the concept of code vs data. and 2) a fixed size pointer is used, regardless of actual size of the addres

Re: is CODE keyword still used?

> Should be nice if we could find a wait to instruct the compiler (or > the building system) to include the typedefed CODE to the pointer > functions automatically, but I don't know if it is possible. > > I think you are all making risky irresponsible changes to fix something that is not broken.

Re: is CODE keyword still used?

> >> Should be nice if we could find a wait to instruct the compiler (or >> the building system) to include the typedefed CODE to the pointer >> functions automatically, but I don't know if it is possible. >> >> I think you are all making risky irresponsible changes to fix something > that is not b

Re: is CODE keyword still used?

i guess that a problem is the semantics of CODE/FAR/NEAR is not very well documented. On Thu, Jan 27, 2022 at 5:21 AM Gregory Nutt wrote: > > > > >> Should be nice if we could find a wait to instruct the compiler (or > >> the building system) to include the typedefed CODE to the pointer > >> func

Re: is CODE keyword still used?

On Thu, Jan 27, 2022 at 1:57 AM Alan Carvalho de Assis wrote: > > Sorry Petro, I missed that files! > > Maybe Greg could explain why it is missing or if it is not necessary. i'm interested in the answer to this. > > Should be nice if we could find a wait to instruct the compiler (or > the buildi