Re: Introduction + incoming RISC-V port(s)

2021-06-22 Thread Robert Lipe
On Mon, Jun 14, 2021 at 1:02 PM Alan Carvalho de Assis wrote: > Normally only common code on NuttX needs to follow the C89 standard > The presubmit flips out about C99 comments. Even that's too radical. So much for being king. :-) > Also should use tools/checkpatch.sh to check your patch/files

Re: Introduction + incoming RISC-V port(s)

2021-06-22 Thread Alan Carvalho de Assis
Hi Robert, On 6/22/21, Robert Lipe wrote: > On Mon, Jun 14, 2021 at 1:02 PM Alan Carvalho de Assis > wrote: > >> Normally only common code on NuttX needs to follow the C89 standard >> > > The presubmit flips out about C99 comments. Even that's too radical. So > much for being king. :-) > You ca

Re: Introduction + incoming RISC-V port(s)

2021-06-22 Thread Alan Carvalho de Assis
s/forgot/forget/ On 6/22/21, Alan Carvalho de Assis wrote: > Hi Robert, > > On 6/22/21, Robert Lipe wrote: >> On Mon, Jun 14, 2021 at 1:02 PM Alan Carvalho de Assis >> >> wrote: >> >>> Normally only common code on NuttX needs to follow the C89 standard >>> >> >> The presubmit flips out about C9

Re: Introduction + incoming RISC-V port(s)

2021-06-22 Thread Robert Lipe
> > > > The presubmit flips out about C99 comments. Even that's too radical. So > > much for being king. :-) > > You can use C99, but you cannot forgot to follow the Coding Style, // > comments shouldn't be used :-) > It's actually worse than that. You can use C99 comments at the end of a line but