Hi,
Any new files developed at the ASF should have ASF headers [1] you also note it
down;t have a copyright line.
Thanks,
Justin
1. https://www.apache.org/legal/src-headers.html#headers
Hi,\
Same issue with the headers here.
Thanks,
Justin
Hi,
Wrong header here as well - please fix.
Thanks,
Justin
Any new files developed at the ASF should have ASF headers [1] you also note it
down;t have a copyright line.
1. https://www.apache.org/legal/src-headers.html#headers
That page gives the text of the ASF header but not the form of the
header in code.
The NuttX coding standard would add t
FYI, you can see the coding standard document at
https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard. It
shows the form of a NuttX file and has some references to the BSD
license that should be updated.
Any new files developed at the ASF should have ASF headers [1] you
also note
Hi, Brennan,
Is there any problem with this? I will update the NuttX coding
standard to match.
I need to update the coding standard document. The mast copies of all
NuttX documentation is in HTML format at
https://github.com/apache/incubator-nuttx/tree/master/Documentation so
that versione
When we do get this figured out. Can we put templates in a folder in the
nuttx repo named something like:
template_c_file.txt
template_h_file.txt
template_Make_file.txt
template_ld_file.txt
template_script_file.txt
-Original Message-
From: Gregory Nutt [mailto:spudan...@gmail.com]
Sent: S
When we do get this figured out. Can we put templates in a folder in the
nuttx repo named something like:
template_c_file.txt
template_h_file.txt
template_Make_file.txt
template_ld_file.txt
template_script_file.txt
There are already templates at the end of the coding standard document
for .
My argument for this is the coding standard document can reference the
directory and `cp` or `copy` can be used to get a properly formatted staring
point file. This is opposed to cutting and pasting from a web browser and
possibly really getting garbage in the file.
Less tools, less margin for err
My argument for this is the coding standard document can reference the
directory and `cp` or `copy` can be used to get a properly formatted staring
point file. This is opposed to cutting and pasting from a web browser and
possibly really getting garbage in the file.
Less tools, less margin for
So everything needs to be inlined (css, images, etc...) or the wiki will
not render the pages correctly. So I used this tool
https://github.com/remy/inliner
❯ npm install inliner
❯ ./node_modules/inliner/cli/index.js
../incubator-nuttx/Documentation/NuttXCCodingStandard.html >
NuttXCCodingStandard.
On Sun, Feb 2, 2020 at 9:11 AM Gregory Nutt wrote:
>
> > My argument for this is the coding standard document can reference the
> > directory and `cp` or `copy` can be used to get a properly formatted
> staring
> > point file. This is opposed to cutting and pasting from a web browser and
> > poss
Any new files developed at the ASF should have ASF headers [1] you
also note it down;t have a copyright line.
1. https://www.apache.org/legal/src-headers.html#headers
That page gives the text of the ASF header but not the form of the
header in code.
The NuttX coding standard would add
On Sat, Feb 1, 2020 at 10:57 PM Abdelatif Guettouche <
abdelatif.guettou...@gmail.com> wrote:
> They are? I think they got redirected to commit@.
> Only the testing repo still got its discussions forwarded to dev@.
> At least this is how I see them.
I stand corrected, those must have been the on
Please review and commit on the license headers in the coding standard:
https://github.com/apache/incubator-nuttx/pull/201/files
Any new files developed at the ASF should have ASF headers [1] you also note it
down;t have a copyright line.
1. https://www.apache.org/legal/src-headers.html#head
A couple more questions:
1) Historically, we have put the file name at the top of each file.
This form would retain that convention. Is this acceptable?
2) The line length in the coding standard is 78 bytes. The longest
line in the same is 62 bytes. That looks weird. Can we use the 78
Instead of creating template files in the repo, maybe a script in tools
that creates the files with all the proper contents?
Why not create an entire project framework is the spirit of VisualStudio:
I want to create:
[ ] Device driver
[ ] An MTD driver
[ ] A new board
[ ] etc.
Then create
Instead of creating template files in the repo, maybe a script in tools
that creates the files with all the proper contents?
Why not create an entire project framework is the spirit of VisualStudio:
I want to create:
[ ] Device driver
[ ] An MTD driver
[ ] A new board
[ ] etc.
Then creat
On Sun, Feb 2, 2020 at 10:03 AM Gregory Nutt wrote:
> 3) The coding standard permits a one line description of the file as the
> third line, juat after the file path. People do not often use this, but
> I think it should also be permitted. It certainly helpful having a one
> liner telling you w
3) The coding standard permits a one line description of the file as the
third line, juat after the file path. People do not often use this, but
I think it should also be permitted. It certainly helpful having a one
liner telling you what the file is.
I agree, and I'd even propose to make that
So everything needs to be inlined (css, images, etc...) or the wiki will
not render the pages correctly. So I used this tool
https://github.com/remy/inliner
❯ npm install inliner
❯ ./node_modules/inliner/cli/index.js
../incubator-nuttx/Documentation/NuttXCCodingStandard.html >
NuttXCCodingStand
On Sun, Feb 2, 2020, 5:53 PM Gregory Nutt wrote:
>
> > So everything needs to be inlined (css, images, etc...) or the wiki will
> > not render the pages correctly. So I used this tool
> > https://github.com/remy/inliner
> > ❯ npm install inliner
> > ❯ ./node_modules/inliner/cli/index.js
> > ../in
Not really and there is at least one icon in that file, and some had
bullets that were images. Now that the change is merged I'll generate the
wiki version tonight. It takes all of 30sec for me since I have everything
setup. We can come up with a better solution another time.
Thanks. Search
Yeah, but most are either leveraging nodejs because it already is really
good at understanding the dom and javascript, or are only doing css.
I'm not a fan of nodejs, but I also like that this tool just seems to work.
Anyway. The wiki is updated and in the attachment view you can see the old
versi
Yeah, but most are either leveraging nodejs because it already is really
good at understanding the dom and javascript, or are only doing css.
I'm not a fan of nodejs, but I also like that this tool just seems to work.
Anyway. The wiki is updated and in the attachment view you can see the old
v
Hi,
>> The NuttX coding standard would add to this in .C and C++ files:=
Which should be fine.
> 1) Historically, we have put the file name at the top of each file. This
> form would retain that convention. Is this acceptable?
I would put it after the header, but it may be OK. I would need t
Hi,
>> 1) Historically, we have put the file name at the top of each file. This
>> form would retain that convention. Is this acceptable?
>> 2) The line length in the coding standard is 78 bytes. The longest line in
>> the same is 62 bytes. That looks weird. Can we use the 78 character line
On Sun, Feb 2, 2020 at 3:21 PM Justin Mclean
wrote:
> Hi,
>
> >> 1) Historically, we have put the file name at the top of each file.
> This form would retain that convention. Is this acceptable?
> >> 2) The line length in the coding standard is 78 bytes. The longest
> line in the same is 62 byt
> I stand corrected, those must have been the ones from testing. Maybe it
> needs to be redirected to commits@, I don't know.
We would probably want that as well.
testing is expected to see more traffic in the up coming days.
liuguo09 commented on a change in pull request #3: Initial checkin CI related
scripts and testlist files
URL:
https://github.com/apache/incubator-nuttx-testing/pull/3#discussion_r373958263
##
File path: cibuild.sh
##
@@ -0,0 +1,171 @@
+#!/usr/bin/env bash
+
+# Licensed to
liuguo09 commented on a change in pull request #3: Initial checkin CI related
scripts and testlist files
URL:
https://github.com/apache/incubator-nuttx-testing/pull/3#discussion_r373958156
##
File path: cibuild.sh
##
@@ -0,0 +1,171 @@
+#!/usr/bin/env bash
+
Review comm
liuguo09 commented on a change in pull request #3: Initial checkin CI related
scripts and testlist files
URL:
https://github.com/apache/incubator-nuttx-testing/pull/3#discussion_r373960759
##
File path: cibuild.sh
##
@@ -0,0 +1,171 @@
+#!/usr/bin/env bash
+
+# Licensed to
liuguo09 commented on a change in pull request #3: Initial checkin CI related
scripts and testlist files
URL:
https://github.com/apache/incubator-nuttx-testing/pull/3#discussion_r373961076
##
File path: cibuild.sh
##
@@ -0,0 +1,171 @@
+#!/usr/bin/env bash
+
+# Licensed to
liuguo09 commented on a change in pull request #3: Initial checkin CI related
scripts and testlist files
URL:
https://github.com/apache/incubator-nuttx-testing/pull/3#discussion_r373961129
##
File path: cibuild.sh
##
@@ -0,0 +1,171 @@
+#!/usr/bin/env bash
+
+# Licensed to
liuguo09 commented on a change in pull request #3: Initial checkin CI related
scripts and testlist files
URL:
https://github.com/apache/incubator-nuttx-testing/pull/3#discussion_r373961326
##
File path: cibuild.sh
##
@@ -0,0 +1,171 @@
+#!/usr/bin/env bash
+
+# Licensed to
35 matches
Mail list logo
