Re: tools/testbuild.sh breaks non-git usage

2020-04-03 Thread Nathan Hartman
On Fri, Apr 3, 2020 at 1:09 AM Xiang Xiao wrote: > Takashi provide a patch fix this issue: > https://github.com/apache/incubator-nuttx/pull/701 > The new behivour is: > 1.The default action restore to "make distclean" > 2.-G option trigger "git clean -xfdq" > Thank you to everyone! This script i

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Xiang Xiao
Takashi provide a patch fix this issue: https://github.com/apache/incubator-nuttx/pull/701 The new behivour is: 1.The default action restore to "make distclean" 2.-G option trigger "git clean -xfdq" On Fri, Apr 3, 2020 at 10:10 AM Xiang Xiao wrote: > > On Fri, Apr 3, 2020 at 8:52 AM Gregory Nutt

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Xiang Xiao
On Fri, Apr 3, 2020 at 8:52 AM Gregory Nutt wrote: > > > > Do we have a platform-independent way to detect whether the NuttX > > distribution is a git clone or not? > Yes, just do a check if the directory at $TOPDIR/.git exists. > > Also, doesn't 'make distclean' clean in apps as well as nuttx? Be

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 8:52 PM Gregory Nutt wrote: > > Do we have a platform-independent way to detect whether the NuttX > > distribution is a git clone or not? > Yes, just do a check if the directory at $TOPDIR/.git exists. Ok. More below. > > Also, doesn't 'make distclean' clean in apps as wel

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Gregory Nutt
I opened issue #698 -- https://github.com/apache/incubator-nuttx/issues/698. Issues are good.  Someday they will be fixed but it might be weeks or months.  If you really want a quick turnaround, a PR (or patch) is the only way to do that.

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Gregory Nutt
Do we have a platform-independent way to detect whether the NuttX distribution is a git clone or not? Yes, just do a check if the directory at $TOPDIR/.git exists. Also, doesn't 'make distclean' clean in apps as well as nuttx? Because I think 'git cleanup' won't clean apps. It will also trash

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 7:59 PM Gregory Nutt wrote: > You should open an issue, or better, push a PR. I opened issue #698 -- https://github.com/apache/incubator-nuttx/issues/698.

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
On Thu, Apr 2, 2020 at 7:59 PM Gregory Nutt wrote: > On 4/2/2020 5:50 PM, Nathan Hartman wrote: > > Regarding commit 27142b2e3c4c6498dc198818ec9b260d812f, this means > > that tools/testbuild.sh now depends on git and on the NuttX > > distribution being a git clone. > > You should open an issue

Re: tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Gregory Nutt
You should open an issue, or better, push a PR. On 4/2/2020 5:50 PM, Nathan Hartman wrote: Hi all, I didn't catch this before the PR was merged, so apologies for being slightly late... Regarding commit 27142b2e3c4c6498dc198818ec9b260d812f, this means that tools/testbuild.sh now depends on

tools/testbuild.sh breaks non-git usage

2020-04-02 Thread Nathan Hartman
Hi all, I didn't catch this before the PR was merged, so apologies for being slightly late... Regarding commit 27142b2e3c4c6498dc198818ec9b260d812f, this means that tools/testbuild.sh now depends on git and on the NuttX distribution being a git clone. Previously we discussed this when a simi