Re: syncfs() method of fs

2024-02-15 Thread Saurav Pal
Hi Greg, I've added a comment about `syncfs` in the issue you mentioned. Thanks for pointing out the issue list. I'm looking into adding VFS documentation now, and after that I'll look into this. Thanks and Regards, SP On Thu, Feb 15, 2024 at 8:03 PM Gregory Nutt wrote: > > > However, I think

Re: syncfs() method of fs

2024-02-15 Thread Gregory Nutt
However, I think it is a mistake to put the hooks in for syncfs and not implement syncfs for other file systems that need it.   From what you say, syncfs() would be a no-op for those other file systems which is (usually) wrong.  Perhaps they could just call fsync() from sync()?  Doing nothing

Re: syncfs() method of fs

2024-02-15 Thread Gregory Nutt
I have no idea what is going on with syncfs.  There have been some recent changes: Documentation/ReleaseNotes/NuttX-12.1.0:* [#8092](https://github.com/apache/nuttx/pull/8092) fs: Map syncfs to fsync Documentation/ReleaseNotes/NuttX-12.3.0:* [#10764](https://github.com/apache/nutt

Re: syncfs() method of fs

2024-02-15 Thread Saurav Pal
Hi Greg, Thanks for the info! Can you tell me the reason why none of the existing file systems in NuttX implement it? Regards, SP On Wed, Feb 14, 2024 at 9:27 PM Gregory Nutt wrote: > It implementes the syncfs file system interface: > https://linux.die.net/man/2/syncfs > > On 2/14/2024 8:16 AM

Re: syncfs() method of fs

2024-02-14 Thread Gregory Nutt
It implementes the syncfs file system interface:  https://linux.die.net/man/2/syncfs On 2/14/2024 8:16 AM, Saurav Pal wrote: Hi all, I was going through the codebase of different file systems, and I haven't yet understood the syncfs() method of mountpt operations. There aren't any existing fi

syncfs() method of fs

2024-02-14 Thread Saurav Pal
Hi all, I was going through the codebase of different file systems, and I haven't yet understood the syncfs() method of mountpt operations. There aren't any existing filesystems in the codebase that implement it, and I couldn't understand what exactly is required from this method (like what it do