Re: nxstyle questions

2020-04-27 Thread Gregory Nutt
Yes! Should I do the same workaround as Greg mentions there, namely to add an additional "Included Files" section for the conditional includes? We have just been ignoring this style error in previous PRs. If you want someone to ignore and nxstyle complaint, I think the the etiquette is to a

Re: nxstyle questions

2020-04-27 Thread Nathan Hartman
On Mon, Apr 27, 2020 at 1:29 PM Abdelatif Guettouche wrote: > Here are the supported sections: > https://github.com/apache/incubator-nuttx/blob/master/tools/nxstyle.c#L131 > (There is an "s" too many in what I wrote above, it's "Public Function > Prototypes") Thanks. More below: > On Mon, Apr 27

Re: nxstyle questions

2020-04-27 Thread Abdelatif Guettouche
Here are the supported sections: https://github.com/apache/incubator-nuttx/blob/master/tools/nxstyle.c#L131 (There is an "s" too many in what I wrote above, it's "Public Function Prototypes") On Mon, Apr 27, 2020 at 7:20 PM Abdelatif Guettouche wrote: > > > (1) arch/arm/include/stm32/stm32f40xxx_

Re: nxstyle questions

2020-04-27 Thread Abdelatif Guettouche
> (1) arch/arm/include/stm32/stm32f40xxx_irq.h:361:3: error: Invalid > section for this file type For a header file the section "Public Functions" should not exist, it's actually "Public Functions Prototypes" > (2) arch/arm/include/stm32/irq.h:81:3: warning: #include outside of > 'Included Files'

nxstyle questions

2020-04-27 Thread Nathan Hartman
I am not sure what to do about the following nxstyle complaints: (1) arch/arm/include/stm32/stm32f40xxx_irq.h:361:3: error: Invalid section for this file type Should I just remove the section? What to do with the unused __ASSEMBLY__, __cplusplus, and extern "C" stuff? (2) arch/arm/include/stm32/