Re: Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

gt; https://urldefense.com/v3/__https://github.com/apache/nuttx/pull/16466__;!!O7_YSHcmd9jp3hj_4dEAcyQ!1y3RB5EUXoBosi8vAEcjSyRXMCiRnRtrGSfJEO84MiLP3anDf6k6445X2RlUvrB55u8lzti4-TaTVNIzppE$ >> >> Best regads >> Alin >> >> >> Från:

Re: Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

her > architectures. > > If there is still something left to improve, let me know. Thanks. > > On 2025-06-11 13:42, alin.jerpe...@sony.com wrote: > > Hi KR, > > > > I added your comments > > > > Best regards > > Alin > > __

Re: Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

@nuttx.apache.org Ämne: Re: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, thanks. Here is a response to xiaoxiang781216's review: > could we extract a common typedef to avoid #ifdef/#else/#endif spread > the code base? Can do - sbuf_size_t seems unused throughou

Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

Hi KR, I added your comments Best regards Alin Från: kr@kerogit.eu Skickat: den 11 juni 2025 07:54 Till: dev@nuttx.apache.org Ämne: Re: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, thanks. Here is a response to xiaoxiang781216&#

Re: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

Best regads Alin Från: kr@kerogit.eu Skickat: den 9 juni 2025 12:12 Till: dev@nuttx.apache.org Ämne: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, reworked version of the series is in branch uart_fixes_rfc3 and also attached. This version incorporates

Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

Hi KR, the patches have been updated https://github.com/apache/nuttx/pull/16466 Best regads Alin Från: kr@kerogit.eu Skickat: den 9 juni 2025 12:12 Till: dev@nuttx.apache.org Ämne: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

Hello, reworked version of the series is in branch uart_fixes_rfc3 and also attached. This version incorporates xiaoxiang781216's suggestion on GitHub to simply make the buffer size stored in uint8_t variable if the architecture cannot handle 16-bit loads atomically. Fix for TOCTOU in waterm

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

Hello, based on the feedback in GitHub review, I will redo the patch differently and reduce the size of the circular buffers so the variables fit into uint8_t. To respond to xiaoxiang781216's comment about using atomic_xxx API instead the critical section - I was considering that as well but

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

Jun 2, 2025 at 3:21 PM MIGUEL ALEXANDRE WISINTAINER < tcpipc...@hotmail.com> wrote: wow, I see that sorry! De: Alan C. Assis Enviado: segunda-feira, 2 de junho de 2025 18:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/se

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

ipc...@hotmail.com> wrote: > wow, > I see that sorry! > > De: Alan C. Assis > Enviado: segunda-feira, 2 de junho de 2025 18:58 > Para: dev@nuttx.apache.org > Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c > > Hi Miguel

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

nable the RS-485 > > De: kr@kerogit.eu > Enviado: segunda-feira, 2 de junho de 2025 16:58 > Para: dev@nuttx.apache.org > Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c > > Hello, > > I noticed a review from A

RE: Sv: RFC: fix race conditions in drivers/serial/serial.c

wow, I see that sorry! De: Alan C. Assis Enviado: segunda-feira, 2 de junho de 2025 18:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hi Miguel, Which kind of modification are you looking for? RS-485 is

RE: Sv: RFC: fix race conditions in drivers/serial/serial.c

should be good change too this driver to enable the RS-485 De: kr@kerogit.eu Enviado: segunda-feira, 2 de junho de 2025 16:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, I noticed a review from

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

Hello, I noticed a review from Allan C. Assis about a spelling error. Updated patches are attached and also available in repository in uart_fixes_rfc2 branch. (Sorry about the extra work, I was even trying to check the word using web search... but I didn't spot that the search autocorrected it

Sv: RFC: fix race conditions in drivers/serial/serial.c

Hi KR, thank for submitting the patches They have been uploaded to mainline and are under review https://github.com/apache/nuttx/pull/16466 Best regards Alin Från: kr@kerogit.eu Skickat: den 1 juni 2025 22:42 Till: dev@nuttx.apache.org Ämne: RFC: fix race