> So in px4, I end up seeing stack usage 100% on some threads (in "ps"), which
> I want to fix.
PR #1900 (https://github.com/apache/incubator-nuttx/pull/1900) fixes the issue.
> In the past (9 or so years ago) there was an issue with floating point that
> required the stack to be 8 byte aligned.
Sure! Go ahead and fix it the way you see best, thanks!
-Jukka
Schock, Johannes - NIVUS GmbH kirjoitti perjantai 25. syyskuuta 2020:
> > 1. Set the stack size as aligned already in
> > arch/arm/src/common/arm_createstack.c:
> >
> > - tcb->adj_stack_size = stack_size;
> > + tcb->adj_sta
Hi,
Yes it happens on master (just tested a minute ago). I think everything
else is in order, but stack coloring is broken at the top of the stack,
if the stack size is not aligned.
-Jukka
On 25.9.2020 11.08, Schock, Johannes - NIVUS GmbH wrote:
Is this happening on master as well? I've co
Hi!
I just encountered a problem with do_stackcheck(), and wanted to ask for
an opinion...
In my (PX4) software I have got some threads, who define their stack
size unaligned by 4 bytes (uint32_t). The stack coloring works on
uint32, and thus doesn't color the topmost bytes of the stack whe
In the past (9 or so years ago) there was an issue with floating point that
required the stack to be 8 byte aligned. It was too long ago, so I do not
remember the details, j
(There is a note in the release notes, "ARM EABI: Fix stack alignment
required for passing floating point values.") But I
-
From: Schock, Johannes - NIVUS GmbH [mailto:johannes.sch...@nivus.com]
Sent: Friday, September 25, 2020 5:49 AM
To: dev@nuttx.apache.org
Subject: RE: Stack size alignment on arm
> 1. Set the stack size as aligned already in
> arch/arm/src/common/arm_createstack.c:
>
> - tcb-&g
> 1. Set the stack size as aligned already in
> arch/arm/src/common/arm_createstack.c:
>
> - tcb->adj_stack_size = stack_size;
> + tcb->adj_stack_size = STACK_ALIGN_DOWN(stack_size);
>
> 2. fix the do_stackcheck in a way that it doesn't start at (unaligned)
> top, but at the first align
Is this happening on master as well? I've commited a change (#1562 ) to ARM
stack management not long ago.
Perhaps I missed something.
I'll have a look.
Johannes
> I just encountered a problem with do_stackcheck(), and wanted to ask for
> an opinion...
>
> In my (PX4) software I have got some t
Hi!
I just encountered a problem with do_stackcheck(), and wanted to ask for
an opinion...
In my (PX4) software I have got some threads, who define their stack
size unaligned by 4 bytes (uint32_t). The stack coloring works on
uint32, and thus doesn't color the topmost bytes of the stack whe
