Re: Problems and a bug in samd2l2 ADC code

2020-11-04 Thread Bernd Walter
On Wed, Nov 04, 2020 at 06:56:50PM -0300, Alan Carvalho de Assis wrote: > Hi Bernd, > > Did you disable the serial console? > > CONFIG_NO_SERIAL_CONSOLE=y (Device Drivers -> Serial Driver Support -> > Serial console (No serial console) ). [194]nuttx-devel> grep CONSOLE contrib/nuttx/.config # CO

Re: Problems and a bug in samd2l2 ADC code

2020-11-04 Thread Alan Carvalho de Assis
Hi Bernd, Did you disable the serial console? CONFIG_NO_SERIAL_CONSOLE=y (Device Drivers -> Serial Driver Support -> Serial console (No serial console) ). BR, Alan On 11/3/20, Bernd Walter wrote: > On Tue, Nov 03, 2020 at 03:34:46PM +0100, Bernd Walter wrote: >> On Mon, Nov 02, 2020 at 03:09:

Re: Problems and a bug in samd2l2 ADC code

2020-11-04 Thread Alan Carvalho de Assis
Hi Bernd, On 11/3/20, Bernd Walter wrote: > On Mon, Nov 02, 2020 at 03:09:12PM +0100, Bernd Walter wrote: >> On Mon, Nov 02, 2020 at 10:17:41AM -0300, Alan Carvalho de Assis wrote: >> > This should be a better idea because you will have 32KB of RAM. They >> > after getting it working you can remo

Re: Problems and a bug in samd2l2 ADC code

2020-11-03 Thread Bernd Walter
On Tue, Nov 03, 2020 at 03:34:46PM +0100, Bernd Walter wrote: > On Mon, Nov 02, 2020 at 03:09:12PM +0100, Bernd Walter wrote: > > On Mon, Nov 02, 2020 at 10:17:41AM -0300, Alan Carvalho de Assis wrote: > > > This should be a better idea because you will have 32KB of RAM. They > > > after getting it

Re: Problems and a bug in samd2l2 ADC code

2020-11-03 Thread Bernd Walter
On Fri, Oct 30, 2020 at 12:26:33PM +0100, Bernd Walter wrote: > On Thu, Oct 29, 2020 at 07:39:16PM -0300, Alan Carvalho de Assis wrote: > > Ok, now I understood the issue you found > > > > Yes, arch/arm/include/samd2l2/sam_adc.h is wrong. > > > > I think this file shouldn't exit, it doesn't exist

Re: Problems and a bug in samd2l2 ADC code

2020-11-03 Thread Bernd Walter
On Mon, Nov 02, 2020 at 03:09:12PM +0100, Bernd Walter wrote: > On Mon, Nov 02, 2020 at 10:17:41AM -0300, Alan Carvalho de Assis wrote: > > This should be a better idea because you will have 32KB of RAM. They > > after getting it working you can remove not necessary features to > > eventually get i

Re: Problems and a bug in samd2l2 ADC code

2020-11-02 Thread Alan Carvalho de Assis
Hi Bernd, On 11/2/20, Bernd Walter wrote: sic > > Well, thiss is all weird. > My Chip is a SAMD21E17A, so it has only 16k RAM. > I had been using in in another project with my own IO code and NXFFS on > an SPI flash (W25), but had to reduce stack sizes to have enough RAM > for the NXFFS. Well, 1

Re: Problems and a bug in samd2l2 ADC code

2020-11-02 Thread Bernd Walter
On Fri, Oct 30, 2020 at 12:26:33PM +0100, Bernd Walter wrote: > On Thu, Oct 29, 2020 at 07:39:16PM -0300, Alan Carvalho de Assis wrote: > > Ok, now I understood the issue you found > > > > Yes, arch/arm/include/samd2l2/sam_adc.h is wrong. > > > > I think this file shouldn't exit, it doesn't exist

Re: Problems and a bug in samd2l2 ADC code

2020-10-30 Thread Bernd Walter
On Thu, Oct 29, 2020 at 07:39:16PM -0300, Alan Carvalho de Assis wrote: > Ok, now I understood the issue you found > > Yes, arch/arm/include/samd2l2/sam_adc.h is wrong. > > I think this file shouldn't exit, it doesn't exist to other arches. OK - I will take a look into this and change it to matc

Re: Problems and a bug in samd2l2 ADC code

2020-10-29 Thread Alan Carvalho de Assis
Ok, now I understood the issue you found Yes, arch/arm/include/samd2l2/sam_adc.h is wrong. I think this file shouldn't exit, it doesn't exist to other arches. Its content should be inside the arch/arm/src/samd2l2/sam_adc.h BR, Alan On 10/29/20, Bernd Walter wrote: > On Thu, Oct 29, 2020 at 0

Re: Problems and a bug in samd2l2 ADC code

2020-10-29 Thread Bernd Walter
On Thu, Oct 29, 2020 at 06:33:46PM -0300, Alan Carvalho de Assis wrote: > I don't think it is wrong. Well - inlcuding and requiring two files with the same protector clearly is wrong. > See: arch/arm/src/stm32/stm32_adc.h There is no arch/arm/include/stm32/stm32_adc.h There is a arch/arm/src/stm

Re: Problems and a bug in samd2l2 ADC code

2020-10-29 Thread Alan Carvalho de Assis
I don't think it is wrong. See: arch/arm/src/stm32/stm32_adc.h Now look inside boards/arm/stm32/ and you will find many board that includes this file same way. BR, Alan On 10/29/20, Bernd Walter wrote: > On Thu, Oct 29, 2020 at 05:42:58PM -0300, Alan Carvalho de Assis wrote: >> Hello, >> >> O

Re: Problems and a bug in samd2l2 ADC code

2020-10-29 Thread Bernd Walter
On Thu, Oct 29, 2020 at 05:42:58PM -0300, Alan Carvalho de Assis wrote: > Hello, > > On 10/29/20, Bernd Walter wrote: > > On Thu, Oct 29, 2020 at 08:51:13AM -0300, Alan Carvalho de Assis wrote: > >> Hi Bernd, > >> > >> It was "working" few mont ago. I put working covered by quotes because > >> th

Re: Problems and a bug in samd2l2 ADC code

2020-10-29 Thread Alan Carvalho de Assis
Hello, On 10/29/20, Bernd Walter wrote: > On Thu, Oct 29, 2020 at 08:51:13AM -0300, Alan Carvalho de Assis wrote: >> Hi Bernd, >> >> It was "working" few mont ago. I put working covered by quotes because >> the ADC convertion wasn't linear. I think the calibration process was >> failing. > > arch

Re: Problems and a bug in samd2l2 ADC code

2020-10-29 Thread Bernd Walter
On Thu, Oct 29, 2020 at 08:51:13AM -0300, Alan Carvalho de Assis wrote: > Hi Bernd, > > It was "working" few mont ago. I put working covered by quotes because > the ADC convertion wasn't linear. I think the calibration process was > failing. arch/arm/src/samd2l2/sam_adc.h was previously named arc

Re: Problems and a bug in samd2l2 ADC code

2020-10-29 Thread Alan Carvalho de Assis
Hi Bernd, It was "working" few mont ago. I put working covered by quotes because the ADC convertion wasn't linear. I think the calibration process was failing. I tested it on Arduino Zero board (SAMD21). BR, Alan On 10/29/20, Bernd Walter wrote: > arch/arm/src/samd2l2/sam_adc.c requires two f