Hi,
Thanks for the tip! I've created an issue and a PR, now waiting for a
review.
Regards,
Saurav
On Sat, Feb 3, 2024 at 1:57 AM Alan C. Assis wrote:
> Hi Saurav,
>
> You can follow the steps here:
> https://nuttx.apache.org/docs/latest/contributing/index.html
>
> After running the checkpatch.
Hi Saurav,
You can follow the steps here:
https://nuttx.apache.org/docs/latest/contributing/index.html
After running the checkpatch.sh and confirming everything is fine, you can
create a commit.
Basically your commit should be like this:
-
Hi Alan,
Yeah I'll add an issue in the repo, and put a PR for fixing this. A quick
question...is there any standard on commit names, or should I just use my
own like "FIX: VFAT macro Issue#123"?
About why side effects have not been seen...like Lwazi explained,
macro DIRSEC_BYTENDX(f,
i) is always
Hi Saurav,
I think you found a BUG!
Please report it at https://github.com/apache/nuttx/issues to keep a track
of it and when you we submit a PR it could be closed automatically (since
you link it at your PR).
In fact looking both macros the f to fs mistake becomes clear:
#define DIRSEC_NDXMASK
Hi,
Thanks for the confirmation and an explanation as to why it works even as
it is!
Regards,
Saurav
On Fri, 2 Feb, 2024, 22:35 Lwazi Dube, wrote:
> It is a typo. Please change to DIRSEC_NDXMASK(f)
> There are no errors because fs is already available in every function that
> "calls" DIRSEC_BY
It is a typo. Please change to DIRSEC_NDXMASK(f)
There are no errors because fs is already available in every function that
"calls" DIRSEC_BYTENDX.
On Fri, 2 Feb 2024 at 11:55, Saurav Pal wrote:
> Hi Alan,
>
> Thank you for looking at our code base and planning to add Documentation,
> > that is
Hi Alan,
Thank you for looking at our code base and planning to add Documentation,
> that is really important!
>
> NuttX has a long history but our Documentation is still lagging behind, so
> your work will be very beneficial for our community.
>
I'll try my best to contribute some documentation
Hi Saurav,
Thank you for looking at our code base and planning to add Documentation,
that is really important!
NuttX has a long history but our Documentation is still lagging behind, so
your work will be very beneficial for our community.
I took a look at that macro you asked and seems it was wr
