Re: Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

apache.org > Ämne: Re: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c > > Hello, thanks. Here is a response to xiaoxiang781216's review: > could > we extract a common typedef to avoid #ifdef/#else/#endif spread > the > code base? Can do - sbuf_size_t seem

Re: Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

her > architectures. > > If there is still something left to improve, let me know. Thanks. > > On 2025-06-11 13:42, alin.jerpe...@sony.com wrote: > > Hi KR, > > > > I added your comments > > > > Best regards > > Alin > > __

Re: Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

@nuttx.apache.org Ämne: Re: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, thanks. Here is a response to xiaoxiang781216's review: > could we extract a common typedef to avoid #ifdef/#else/#endif spread > the code base? Can do - sbuf_size_t seems unused throughou

Sv: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

Hi KR, I added your comments Best regards Alin Från: kr@kerogit.eu Skickat: den 11 juni 2025 07:54 Till: dev@nuttx.apache.org Ämne: Re: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, thanks. Here is a response to xiaoxiang781216&#

Re: Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

Best regads Alin Från: kr@kerogit.eu Skickat: den 9 juni 2025 12:12 Till: dev@nuttx.apache.org Ämne: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, reworked version of the series is in branch uart_fixes_rfc3 and also attached. This version incorporates

Sv: Sv: RFC: fix race conditions in drivers/serial/serial.c

Hi KR, the patches have been updated https://github.com/apache/nuttx/pull/16466 Best regads Alin Från: kr@kerogit.eu Skickat: den 9 juni 2025 12:12 Till: dev@nuttx.apache.org Ämne: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

pache.org Ämne: RFC: fix race conditions in drivers/serial/serial.c While going through the code in drivers/serial/serial. c, I noticed this comment: The head and tail pointers are 16-bit values. The only time that the following could be unsafe is if the CPU made two non-atomic 8-bit accesses t

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

gards Alin Från: kr@kerogit.eu Skickat: den 1 juni 2025 22:42 Till: dev@nuttx.apache.org Ämne: RFC: fix race conditions in drivers/serial/serial.c While going through the code in drivers/serial/serial. c, I noticed this comment: The head and tail pointers are 16-bit values. The only tim

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

Jun 2, 2025 at 3:21 PM MIGUEL ALEXANDRE WISINTAINER < tcpipc...@hotmail.com> wrote: wow, I see that sorry! De: Alan C. Assis Enviado: segunda-feira, 2 de junho de 2025 18:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/se

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

ipc...@hotmail.com> wrote: > wow, > I see that sorry! > > De: Alan C. Assis > Enviado: segunda-feira, 2 de junho de 2025 18:58 > Para: dev@nuttx.apache.org > Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c > > Hi Miguel

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

nable the RS-485 > > De: kr@kerogit.eu > Enviado: segunda-feira, 2 de junho de 2025 16:58 > Para: dev@nuttx.apache.org > Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c > > Hello, > > I noticed a review from A

RE: Sv: RFC: fix race conditions in drivers/serial/serial.c

wow, I see that sorry! De: Alan C. Assis Enviado: segunda-feira, 2 de junho de 2025 18:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hi Miguel, Which kind of modification are you looking for? RS-485 is

RE: Sv: RFC: fix race conditions in drivers/serial/serial.c

should be good change too this driver to enable the RS-485 De: kr@kerogit.eu Enviado: segunda-feira, 2 de junho de 2025 16:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, I noticed a review from

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

/pull/16466 Best regards Alin Från: kr@kerogit.eu Skickat: den 1 juni 2025 22:42 Till: dev@nuttx.apache.org Ämne: RFC: fix race conditions in drivers/serial/serial.c While going through the code in drivers/serial/serial. c, I noticed this comment: The head and

Sv: RFC: fix race conditions in drivers/serial/serial.c

conditions in drivers/serial/serial.c While going through the code in drivers/serial/serial. c, I noticed this comment: The head and tail pointers are 16-bit values. The only time that the following could be unsafe is if the CPU made two non-atomic 8-bit accesses to obtain the 16-bit While

RFC: fix race conditions in drivers/serial/serial.c

While going through the code in drivers/serial/serial.c, I noticed this comment: The head and tail pointers are 16-bit values. The only time that the following could be unsafe is if the CPU made two non-atomic 8-bit accesses to obtain the 16-bit head index. This is what happens for (at least)