Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-09 Thread kr . git
Hello, reworked version of the series is in branch uart_fixes_rfc3 and also attached. This version incorporates xiaoxiang781216's suggestion on GitHub to simply make the buffer size stored in uint8_t variable if the architecture cannot handle 16-bit loads atomically. Fix for TOCTOU in waterm

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-04 Thread kr . git
Hello, based on the feedback in GitHub review, I will redo the patch differently and reduce the size of the circular buffers so the variables fit into uint8_t. To respond to xiaoxiang781216's comment about using atomic_xxx API instead the critical section - I was considering that as well but

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-04 Thread kr . git
Jun 2, 2025 at 3:21 PM MIGUEL ALEXANDRE WISINTAINER < tcpipc...@hotmail.com> wrote: wow, I see that sorry! De: Alan C. Assis Enviado: segunda-feira, 2 de junho de 2025 18:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/se

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-03 Thread Matteo Golin
ipc...@hotmail.com> wrote: > wow, > I see that sorry! > > De: Alan C. Assis > Enviado: segunda-feira, 2 de junho de 2025 18:58 > Para: dev@nuttx.apache.org > Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c > > Hi Miguel

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-02 Thread Alan C. Assis
nable the RS-485 > > De: kr@kerogit.eu > Enviado: segunda-feira, 2 de junho de 2025 16:58 > Para: dev@nuttx.apache.org > Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c > > Hello, > > I noticed a review from A

RE: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-02 Thread MIGUEL ALEXANDRE WISINTAINER
wow, I see that sorry! De: Alan C. Assis Enviado: segunda-feira, 2 de junho de 2025 18:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hi Miguel, Which kind of modification are you looking for? RS-485 is

RE: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-02 Thread MIGUEL ALEXANDRE WISINTAINER
should be good change too this driver to enable the RS-485 De: kr@kerogit.eu Enviado: segunda-feira, 2 de junho de 2025 16:58 Para: dev@nuttx.apache.org Assunto: Re: Sv: RFC: fix race conditions in drivers/serial/serial.c Hello, I noticed a review from

Re: Sv: RFC: fix race conditions in drivers/serial/serial.c

2025-06-02 Thread kr . git
Hello, I noticed a review from Allan C. Assis about a spelling error. Updated patches are attached and also available in repository in uart_fixes_rfc2 branch. (Sorry about the extra work, I was even trying to check the word using web search... but I didn't spot that the search autocorrected it