Re: PR85 Question for Xiao Xiang

2020-01-12 Thread Xiang Xiao
On Sun, Jan 12, 2020 at 2:20 AM Gregory Nutt wrote: > > > > I fixed this section of code because it had ETIMEOUT instead of > > ETIMEDOUT and so caused a compilation failure. > > > > Looking more carefully, net_timedwait() will return -ETIMEDOUT on the > > timeout. So shouldn't the condition be (

Re: PR85 Question for Xiao Xiang

2020-01-11 Thread Gregory Nutt
I fixed this section of code because it had ETIMEOUT instead of ETIMEDOUT and so caused a compilation failure. Looking more carefully, net_timedwait() will return -ETIMEDOUT on the timeout.  So shouldn't the condition be (ret == -ETIMEDOUT && acked == state.snd_acked).  I will change the cod

PR85 Question for Xiao Xiang

2020-01-11 Thread Gregory Nutt
I fixed this section of code because it had ETIMEOUT instead of ETIMEDOUT and so caused a compilation failure. Looking more carefully, net_timedwait() will return -ETIMEDOUT on the timeout.  So shouldn't the condition be (ret == -ETIMEDOUT && acked == state.snd_acked).  I will change the code