Re: PR 5782 and code reviee process

2022-04-01 Thread Xiang Xiao
On Sat, Apr 2, 2022 at 3:16 AM Jukka Laitinen wrote: > I am not the author there, just feel that the process is not fair for the > author. > > The PR has over 300 comments, and they come in bunches of 20, every day > one bunch more. Most of them are just of type "please replace xxxyyy with > xxx_

Re: PR 5782 and code reviee process

2022-04-01 Thread Alan Carvalho de Assis
Fixed! On 4/1/22, Jukka Laitinen wrote: > I am not the author there, just feel that the process is not fair for the > author. > > The PR has over 300 comments, and they come in bunches of 20, every day one > bunch more. Most of them are just of type "please replace xxxyyy with > xxx_yyy", or "ple

Re: PR 5782 and code reviee process

2022-04-01 Thread Jukka Laitinen
I am not the author there, just feel that the process is not fair for the author. The PR has over 300 comments, and they come in bunches of 20, every day one bunch more. Most of them are just of type "please replace xxxyyy with xxx_yyy", or "please move these lines 20 lines above". That is, pur

Re: PR 5782 and code reviee process

2022-04-01 Thread Alan Carvalho de Assis
Hi Jukka, I think everybody want RISC-V with Kernel mode support on NuttX. Sometimes we get really angry because some comments seem too picky, but we need to believe in the "The Wisdom of Crowds" (i.e.: https://www.youtube.com/watch?v=Qfh-k9P8ZPI ) So, instead getting mad about it, please try to

PR 5782 and code reviee process

2022-04-01 Thread Jukka Laitinen
Hi, If RISC-V S-mode and CONFIG_BUILD_KERNEL support is not wanted into NuttX, please say it out loud instead of playing unfair review games. The team has better things to do than re-write code letter-by letter via code review, week after week. The code is good quality and working, and is d