Re: Extending UORB for thermocouples

2025-01-20 Thread Xiang Xiao
Android define both: https://github.com/apache/nuttx/pull/15610 On Mon, Jan 20, 2025 at 1:14 AM Tomek CEDRO wrote: > On Sat, Jan 18, 2025 at 8:30 AM raiden00pl wrote: > > Can we just rename `SENSOR_TYPE_AMBIENT_TEMPERATURE` to > > `SENSOR_TYPE_TEMPERATURE` > > and update the comments that this

Re: Extending UORB for thermocouples

2025-01-19 Thread Tomek CEDRO
On Sat, Jan 18, 2025 at 8:30 AM raiden00pl wrote: > Can we just rename `SENSOR_TYPE_AMBIENT_TEMPERATURE` to > `SENSOR_TYPE_TEMPERATURE` > and update the comments that this type is "a general temperature sensor"? > The current definition is taken from Android, but NuttX is a more general > OS, used

Re: Extending UORB for thermocouples

2025-01-18 Thread Matteo Golin
Hello, I have no qualms with renaming the existing type to just be temperature, I just figured that renaming this macro might break some existing user code. If the NuttX team thinks renaming is a better solution then I'd be happy to go that route! Matteo On Sat, Jan 18, 2025, 2:30 AM raiden00pl

Re: Extending UORB for thermocouples

2025-01-17 Thread raiden00pl
Can we just rename `SENSOR_TYPE_AMBIENT_TEMPERATURE` to `SENSOR_TYPE_TEMPERATURE` and update the comments that this type is "a general temperature sensor"? The current definition is taken from Android, but NuttX is a more general OS, used in various embedded scenarios that go far beyond those of An

Re: Extending UORB for thermocouples

2025-01-17 Thread 董九柱
hello Matteo Golin: I'm Donny. About these questions, i have some suggestions. Regarding the first question, we first need to clarify what data the sensor reports. Can only temperature and time suffice? If they can, try to reuse the sensor_temp structure instead of introducing a new type. If th

Re: Extending UORB for thermocouples

2025-01-16 Thread Matteo Golin
Here I am already with another additional question: I want to somewhat unify the options that these thermocouple sensors would have, and one of those options would be configuring the type of thermocouple. For instance, the MCP9600 supports K, J, T, ..., etc. types of thermocouples. I'm wondering i

Extending UORB for thermocouples

2025-01-16 Thread Matteo Golin
Hello everyone, I am working on writing drivers for some of InSpace's new sensors for our hybrid control system. Of these sensors, one of them is the MCP9600 thermocouple amplifier for reading temperatures off of our oxidizer tank and combustion chamber. I wrote this driver using the legacy for