Re: Duplicate task_spawn()

2021-07-01 Thread Xiang Xiao
Thanks for reporting this issue. There a method to simplify the implementation and keep the compatibility, please try these patch: https://github.com/apache/incubator-nuttx/pull/4027 https://github.com/apache/incubator-nuttx-apps/pull/791 On Thu, Jul 1, 2021 at 8:40 PM Sebastien Lorquet wrote: >

Re: Duplicate task_spawn()

2021-07-01 Thread Sebastien Lorquet
I see that around the time of this discussion the userland API of task_spawn has been changed in incompatible ways. by this commit: https://github.com/apache/incubator-nuttx-apps/commit/58293abb8e896bb04f3a76bf8b48206debe68f26?branch=58293abb8e896bb04f3a76bf8b48206debe68f26&diff=unified My app

Re: Duplicate task_spawn()

2020-06-01 Thread Gregory Nutt
On 5/30/2020 1:27 AM, Yang Chung Fan wrote: Hi, Did anyone also noticed that when building with CONFIG_LIB_SYSCALL=y, the linker is unhappy about the duplicated task_spawn() symbols? One of them is in sched/ and other one is in libs/libc. PR 1168 should take care of this.

RE: Duplicate task_spawn()

2020-05-31 Thread Xiang Xiao
x.apache.org > Subject: Re: Duplicate task_spawn() > > > > Any static should be conditioned on CONFIG_LIB_SYSCALL for the > > task_spawn() version in sched/task/task_spawn.c, however, that is not > > really necessary either because that version is not linked into the &g

Re: Duplicate task_spawn()

2020-05-30 Thread Yang Chung Fan
> > Any static should be conditioned on CONFIG_LIB_SYSCALL for the > task_spawn() version in sched/task/task_spawn.c, however, that is not > really necessary either because that version is not linked into the same > binary as is the version in libs/libc/spawn. > > I suppose a user could enable CONF

Re: Duplicate task_spawn()

2020-05-30 Thread Gregory Nutt
Any static should be conditioned on CONFIG_LIB_SYSCALL for the task_spawn() version in sched/task/task_spawn.c, however, that is not really necessary either because that version is not linked into the same binary as is the version in libs/libc/spawn. I suppose a user could enable CONFIG_LIB

Re: Duplicate task_spawn()

2020-05-30 Thread Gregory Nutt
On 5/30/2020 9:22 AM, Gregory Nutt wrote: On 5/30/2020 3:44 AM, Xiang Xiao wrote: It seems that the version inside sched/task/task_spawn.c need become a static function. I think that the version of task_spawn in lib/libc/spawn need to exist only if CONFIG_LIB_SYSCALL is selected.  In that cas

Re: Duplicate task_spawn()

2020-05-30 Thread Gregory Nutt
On 5/30/2020 3:44 AM, Xiang Xiao wrote: It seems that the version inside sched/task/task_spawn.c need become a static function. I think that the version of task_spawn in lib/libc/spawn need to exist only if CONFIG_LIB_SYSCALL is selected.  In that case, the one in sched/task/task_spawn.c sho

RE: Duplicate task_spawn()

2020-05-30 Thread Xiang Xiao
It seems that the version inside sched/task/task_spawn.c need become a static function. > -Original Message- > From: Yang Chung Fan > Sent: Saturday, May 30, 2020 3:27 PM > To: dev@nuttx.apache.org > Subject: Duplicate task_spawn() > > Hi, > > Did an

Duplicate task_spawn()

2020-05-30 Thread Yang Chung Fan
Hi, Did anyone also noticed that when building with CONFIG_LIB_SYSCALL=y, the linker is unhappy about the duplicated task_spawn() symbols? One of them is in sched/ and other one is in libs/libc. -- Yang