Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Xiang Xiao
All issues already provide the fix: https://github.com/apache/incubator-nuttx-apps/pull/3 https://github.com/apache/incubator-nuttx/pull/23 Sorry, Kconfig system is too flexible to cover all combinations. The automation build check is very impotant to ensure the change can pass all possible configu

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Nathan Hartman
On Thu, Jan 2, 2020 at 3:48 PM Gregory Nutt wrote: > > Please tell me if two patches appear now... > > yes, I got them an incorporated them. > > We need to fix that. Most users will be submitting changes with the > .patch suffix. Deja vu? I thought we had this discussion and asked infra to make

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
Please tell me if two patches appear now... yes, I got them an incorporated them. We need to fix that.  Most users will be submitting changes with the .patch suffix. Greg

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Nathan Hartman
On Thu, Jan 2, 2020 at 1:59 PM Gregory Nutt wrote: > > Still don't see it > > On 1/2/2020 11:19 AM, Nathan Hartman wrote: > > On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt wrote: > >>> Recently this warning started showing up in builds: > > ... > >>> Patch attached. > >> I don't see anything attac

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Nathan Hartman
On Thu, Jan 2, 2020 at 1:59 PM Gregory Nutt wrote: > Still don't see it > > On 1/2/2020 11:19 AM, Nathan Hartman wrote: > > On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt > wrote: > >>> Recently this warning started showing up in builds: > > ... > >>> Patch attached. > >> I don't see anything atta

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
Still don't see it On 1/2/2020 11:19 AM, Nathan Hartman wrote: On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt wrote: Recently this warning started showing up in builds: ... Patch attached. I don't see anything attached. It would help if I attached the file. :-) Retrying... Nathan

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
Xiao Xiang, These are all errors created by your recent changes to nxsem_ code and also the the .updated target in the apps/ build system. You should provide the fixes.

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
On 1/2/2020 11:24 AM, Gregory Nutt wrote: Same problem in dirvers/modem/altair/altmdm_sys.c -- but worse. More undedefined nxsem_* functions and the build with that driver also fails with "undefined reference to nxsem_timedwait_uninterruptible' LOTs of code breakage with the last PRs!  We ne

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Nathan Hartman
On Thu, Jan 2, 2020 at 12:21 PM Nathan Hartman wrote: > > On Thu, Jan 2, 2020 at 12:08 PM Gregory Nutt wrote: > > I am doing a build test now. Yes, I am seeing this new warning too (A > > LOT). But I am also seeing 'ret may be used uninitialized in this > > function" in the return value of icmp

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
Same problem in dirvers/modem/altair/altmdm_sys.c -- but worse. More undedefined nxsem_* functions and the build with that driver also fails with "undefined reference to nxsem_timedwait_uninterruptible' LOTs of code breakage with the last PRs!  We need a proper workflow to prevent this from

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
Recently this warning started showing up in builds: icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler': icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function 'nxsem_post'; did you mean 'sem_post'? [-Wimplicit-function-declaration] nxsem_post(info->fds->sem);

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Nathan Hartman
On Thu, Jan 2, 2020 at 12:08 PM Gregory Nutt wrote: > I am doing a build test now. Yes, I am seeing this new warning too (A > LOT). But I am also seeing 'ret may be used uninitialized in this > function" in the return value of icmp_pollsetup() in the same file, > icmp/icmp_netpoll.c Interesting

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Nathan Hartman
On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt wrote: > > Recently this warning started showing up in builds: ... > > Patch attached. > > I don't see anything attached. It would help if I attached the file. :-) Retrying... Nathan

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
Recently this warning started showing up in builds: icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler': icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function 'nxsem_post'; did you mean 'sem_post'? [-Wimplicit-function-declaration] nxsem_post(info->fds->sem);

Re: [PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Gregory Nutt
Recently this warning started showing up in builds: icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler': icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function 'nxsem_post'; did you mean 'sem_post'? [-Wimplicit-function-declaration] nxsem_post(info->fds->sem);

[PATCH] Fix build warning: Implicit declaration nxsem_post()

2020-01-02 Thread Nathan Hartman
Recently this warning started showing up in builds: icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler': icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function 'nxsem_post'; did you mean 'sem_post'? [-Wimplicit-function-declaration] nxsem_post(info->fds->sem);