[Breaking change] Default behavior of pty

2023-03-19 Thread Huang Qi
Hi, all: I have a PR (drivers/pty: Echo input by default by no1wudi ・ Pull Request #8846 ・ apache/nuttx (github.com)) which align the pty behavior to linux/bsd, Also fix the ECHO issue with microadb after #8691

Default behavior of cu

2023-03-13 Thread Huang Qi
Hi all, There excatly are some issues after echo input in driver (https://github.com/apache/nuttx/pull/8691), the default behavior of cu is one of them should be discussed. [https://opengraph.githubassets.com/d9287525ac4414548917840a0f06e871d6208b7ef78597353c79478a6ee0199f/apache/nuttx/pull/8691

Re: Changes in Common Line Editor

2023-03-10 Thread Huang Qi
> There are bandaid fixes going in that try to recover from the primary bad > fix. That is not > good. That is only making things worse. We need to fix > the root cause of the problem > no just change the behavior of individual apps to hide the problem. The root > cause is > that the serial

RE: [Breaking change] Echo character by serial driver

2023-03-10 Thread Huang Qi
ith very small flash size. BTW, for this thread, I think we can try to optimize the new approach about ECHO and fix all issue found. If it's not possible or not the right way, let's revert the change. What's your opinion? On 3/10/2023 7:44 PM, Huang Qi wrote: > >> The

RE: [Breaking change] Echo character by serial driver

2023-03-10 Thread Huang Qi
>> The ECHO behavior can be disabled ONLY if TERMIOS are enabled. >> TERIMIOS is now required by POSIX and, further, if TERMIOS is not >> system, many features are now broken. Like hiding the password when >> logging into NSH. > Yes maybe we should select TERMIOS if some features really ne