Re: Makefile vs Make.defs

2024-01-02 Thread Bill Rees
I mention avoiding targets because most developers don't notice, as I didn't, that the upper level makefile is included at the end so any targets should follow that inclusion. Given how little many devs no about Makefiles that little tidbit becomes difficult to debug. Specifically any tar

Re: debugassert vs assert in apps

2024-01-02 Thread Xiang Xiao
Here is the issue to track debug.h created before: https://github.com/apache/nuttx/issues/8986 On Wed, Jan 3, 2024 at 2:30 AM Gregory Nutt wrote: > > On Tue, Jan 2, 2024 at 11:16 AM Fotis Panagiotopoulos > > wrote: > >> DEBUGASSERT shall only be used for the kernel. > >> assert shall only be u

Re: debugassert vs assert in apps

2024-01-02 Thread Gregory Nutt
On Tue, Jan 2, 2024 at 11:16 AM Fotis Panagiotopoulos wrote: DEBUGASSERT shall only be used for the kernel. assert shall only be used for apps. Rationale: DEBUGASSERT is a custom macro that only exists in the NuttX world. As such it is best being used in NuttX-specific code. assert on the ot

Re: debugassert vs assert in apps

2024-01-02 Thread Nathan Hartman
This is an excellent summary! I suggest this should be documented somewhere in Documentation, with a more summarized version in the comment block of these macros. This way, the discussion and its conclusions will not be forgotten in the future!! Happy New Year, Nathan On Tue, Jan 2, 2024 at 11:16

Re: debugassert vs assert in apps

2024-01-02 Thread Fotis Panagiotopoulos
Hello everyone, and happy new year! After discussing this with Tim, I would like to present my opinion on this topic, in the hope we build better code conventions (or maybe understand better how apps are developed in Nuttx, as I don't use them often). So the idea is: DEBUGASSERT shall only be us