Double-free + Overlapping Chunks for mm_malloc

2022-02-18 Thread Ilya Grishchenko
Good day, I guess I found an interesting behavior when a chunk is double-freed (DF): afterwards mm_malloc goes in a loop(?): Allocated 6 chunks: 0x562d7ef9a690 0x562d7ef9a6b0 0x562d7ef9a6d0 0x562d7ef9a6f0 0x562d7ef9a710 0x562d7ef9a730 Free 2 Free 4 Free 2 Allocated 6 chunks: 0x562d7ef9a6d0 0x5

Re: [DISCUSS] Default state of NDEBUG

2022-02-18 Thread Nathan Hartman
On Thu, Feb 17, 2022 at 4:08 AM Petro Karashchenko wrote: > My point about two config options was more because I think that apps > and kernel are two separate entities and if there is a need to add > extra debugging capabilities to the kernel it does not mean that it > needs to be added for apps a

Re: [DISCUSS]: Self merge and Single company/organization merge gating

2022-02-18 Thread Nathan Hartman
On Fri, Feb 18, 2022 at 5:27 AM Xiang Xiao wrote: > > On Fri, Feb 18, 2022 at 3:52 PM Petro Karashchenko < > petro.karashche...@gmail.com> wrote: > > > Hi, > > > > I agree that auto-merge should not be used. > > > > But I disagree that "as it is now since almost all patches follow the > > rule and

Re: [DISCUSS]: Self merge and Single company/organization merge gating

2022-02-18 Thread Xiang Xiao
On Fri, Feb 18, 2022 at 3:52 PM Petro Karashchenko < petro.karashche...@gmail.com> wrote: > Hi, > > I agree that auto-merge should not be used. > > But I disagree that "as it is now since almost all patches follow the > rule and seldom someone self-merges a patch". Here is a list of > patches that

Re: [DISCUSS]: Self merge and Single company/organization merge gating

2022-02-18 Thread Petro Karashchenko
Hi Alin, The original discussion came from https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020379240 after I merged my PR that was approved my Alan. Me and Alan do not represent the same organization, so probably we need to clarify what the "self merge" is. Best regards, Petro

Re: [DISCUSS]: Self merge and Single company/organization merge gating

2022-02-18 Thread Alin Jerpelea
Hi Petro, for me self merge meant also without review from someone else In the mentioned cases the Author had at least 1 review from someone else (even from another company) Best regards Alin On Fri, Feb 18, 2022 at 8:52 AM Petro Karashchenko < petro.karashche...@gmail.com> wrote: > Hi, > > I