Ok, now I understood the issue you found
Yes, arch/arm/include/samd2l2/sam_adc.h is wrong.
I think this file shouldn't exit, it doesn't exist to other arches.
Its content should be inside the arch/arm/src/samd2l2/sam_adc.h
BR,
Alan
On 10/29/20, Bernd Walter wrote:
> On Thu, Oct 29, 2020 at 0
On Thu, Oct 29, 2020 at 06:33:46PM -0300, Alan Carvalho de Assis wrote:
> I don't think it is wrong.
Well - inlcuding and requiring two files with the same protector clearly
is wrong.
> See: arch/arm/src/stm32/stm32_adc.h
There is no arch/arm/include/stm32/stm32_adc.h
There is a arch/arm/src/stm
I don't think it is wrong.
See: arch/arm/src/stm32/stm32_adc.h
Now look inside boards/arm/stm32/ and you will find many board that
includes this file same way.
BR,
Alan
On 10/29/20, Bernd Walter wrote:
> On Thu, Oct 29, 2020 at 05:42:58PM -0300, Alan Carvalho de Assis wrote:
>> Hello,
>>
>> O
On Thu, Oct 29, 2020 at 05:42:58PM -0300, Alan Carvalho de Assis wrote:
> Hello,
>
> On 10/29/20, Bernd Walter wrote:
> > On Thu, Oct 29, 2020 at 08:51:13AM -0300, Alan Carvalho de Assis wrote:
> >> Hi Bernd,
> >>
> >> It was "working" few mont ago. I put working covered by quotes because
> >> th
Hello,
On 10/29/20, Bernd Walter wrote:
> On Thu, Oct 29, 2020 at 08:51:13AM -0300, Alan Carvalho de Assis wrote:
>> Hi Bernd,
>>
>> It was "working" few mont ago. I put working covered by quotes because
>> the ADC convertion wasn't linear. I think the calibration process was
>> failing.
>
> arch
Hi Bernd,
Thank you very much!
Yes, it appears correct! Let's wait the CI to complete, but so far so good!
BR,
Alan
On 10/29/20, Bernd Walter wrote:
> On Thu, Oct 29, 2020 at 08:48:56AM -0300, Alan Carvalho de Assis wrote:
>> Hi Bernd,
>>
>> Nice finding! Could you please submit a Pull Reques
On Thu, Oct 29, 2020 at 08:51:13AM -0300, Alan Carvalho de Assis wrote:
> Hi Bernd,
>
> It was "working" few mont ago. I put working covered by quotes because
> the ADC convertion wasn't linear. I think the calibration process was
> failing.
arch/arm/src/samd2l2/sam_adc.h was previously named arc
On Thu, Oct 29, 2020 at 08:48:56AM -0300, Alan Carvalho de Assis wrote:
> Hi Bernd,
>
> Nice finding! Could you please submit a Pull Request?
https://github.com/apache/incubator-nuttx/pull/2162
Hope it is correct - this is my first pull request.
>
> This is very easy, just fork the
> https://gi
Hi Bernd,
It was "working" few mont ago. I put working covered by quotes because
the ADC convertion wasn't linear. I think the calibration process was
failing.
I tested it on Arduino Zero board (SAMD21).
BR,
Alan
On 10/29/20, Bernd Walter wrote:
> arch/arm/src/samd2l2/sam_adc.c requires two f
Hi Bernd,
Nice finding! Could you please submit a Pull Request?
This is very easy, just fork the
https://github.com/apache/incubator-nuttx to github user, apply your
patch and click on Pulll requests -> New pull request
Thank you very much!
BR,
Alan
On 10/29/20, Bernd Walter wrote:
> When us
Hi Frank-Christian,
Last time I converted your patch to a PR, but it would be nice if you
could send the PR directly to github, this is how people are
contributing today. ;-)
This is very easy, just fork the
https://github.com/apache/incubator-nuttx to user github, apply your
patch and click on P
arch/arm/src/samd2l2/sam_adc.c requires two files to be includes:
arch/arm/src/samd2l2/sam_adc.h
and
arch/arm/include/samd2l2/sam_adc.h
Both however use the same inlcude protector define.
I've changed one of them locally.
When I try to register as /dev/adc0 I get error 17.
I could trace it furthe
When using an I2C master, the file won't compile without the change,
because BUSY is undefined
diff --git a/contrib/nuttx/arch/arm/src/samd2l2/sam_i2c_master.c
b/contrib/nuttx/arch/arm/src/samd2l2/sam_i2c_master.c
index 0874a66716..588b355336 100644
--- a/contrib/nuttx/arch/arm/src/samd2l2/sam_i2
13 matches
Mail list logo
