Build failed in Jenkins: NuttX-Nightly-Build #65

See Changes: -- [...truncated 501.55 KB...] Copy files Select CONFIG_HOST_LINUX=y Refreshing... Building NuttX... --

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599307751 @btashton thanks, I'll look into it and feedback later.

RE: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Hi Adam, Hmmm…Would the shortest path, on this issue, be to add some -NuttX options and submit a PR to upstream or Fork it? It may be that time spent training Clang-format is better than time spent on nstyle, as it is a "shorter haul" with a much, much greater return. David *From:* Adam

Re: Should we relax precheck a little bit?

Yeah I thought about the too But think of the can of worm on the commit history: Every PR touches the cfg file. I don't see that.  Modifications to the white list file, whatever it is called, would be very rare.  Only when a new non-compliant name is added which should be never. We s

Re: Should we relax precheck a little bit?

How about we put this special treatment to another file(e.g. nxstyle.cfg)? So we don't pollute the source code. +1 I like it.  I just suggested basically the same think in the PR.  I suggested the name .nxignore. If a .nxignore file exists in the same directory as the file under test, the

RE: Should we relax precheck a little bit?

Yeah I thought about the too But think of the can of worm on the commit history: Every PR touches the cfg file. Rebase HELL! Yuch! Fix or replace the tool! -Original Message- From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] Sent: Sunday, March 15, 2020 6:08 AM To: dev@nuttx.apach

RE: Question of PR Etiquette

Helping someone is not a bad thing. Consider the effect on the community and the code. What use to happen with patches: patches were emailed, ***modified*** and committed. Submitted != Committed - Was that BAD Etiquette? What use to happen with a PR: PR were submitted, 1-N more commits were mad

Re: Should we relax precheck a little bit?

How about we put this special treatment to another file(e.g. nxstyle.cfg)? So we don't pollute the source code. On Sun, Mar 15, 2020 at 7:47 PM Schock, Johannes - NIVUS GmbH wrote: > > Hello, > I filed a pull request that introduces an idea of controlling the behaviour > of nxstyle from inside

Re: Should we relax precheck a little bit?

I am oppose to modyfing source files to support the tool.  I don't think we should go that direction.Sent from Samsung tablet. Original message From: "Schock, Johannes - NIVUS GmbH" Date: 3/15/20 5:47 AM (GMT-06:00) To: dev@nuttx.apache.org Subject: Re: Should we relax preche

Re: Should we relax precheck a little bit?

Hello, I filed a pull request that introduces an idea of controlling the behaviour of nxstyle from inside the file under test. https://github.com/apache/incubator-nuttx/pull/569 This would allow to address some special requirements that are needed in cornercases (e.g. whitelisting), and, by using

Re: Question of PR Etiquette

Completely forbidding this functionality will deprive us from a useful feature. We may need it now to help with overwhelming style complaints that were not introduced by the PR or in the future if the contributor asks for some sort of help. We just need some moderation and resort to this only after

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599183244 @liuguo09 Sorry this took me so long. Have a look at what I have done over here: https://github

Re: Question of PR Etiquette

Hi, > So what you suggest it that we as committer don't need disscuss > anything with the contributor, we just need take his PR and do what we > think the right modification then merge directly. You could either discuss it with them or accept the PR and improve it. What you do may be decided on

Re: Question of PR Etiquette

On Sun, Mar 15, 2020 at 12:59 PM Justin Mclean wrote: > > Hi, > > > Yes, this is last resort. It's better to discuss PR in the github and > > let the contributor fix the problem by self. The collaboration model > > can decrease the divergence and improve the community health. > > In my experience