Re: Jenkins CI

2020-01-07 Thread Haitao Liu
In my opionion, it's best setup job here in https://builds.apache.org Justin Mclean 于2020年1月8日周三 下午12:00写道: > Hi, > > Changing subjects. > > > Since code check part is available now, could I and Duo prepare to setup > > Jenkins CI job firstly? > > Where are you intending to set up this job? Her

Re: Jenkins CI

2020-01-07 Thread Haitao Liu
Greg, all the CI specific scripts would only be in Jenkins Job Server. They won't come into nuttx/ and apps/ end-user directories. Gregory Nutt 于2020年1月8日周三 下午12:03写道: > >> Since code check part is available now, could I and Duo prepare to setup > >> Jenkins CI job firstly? > > Where are you int

Re: Working Effectively (was Point of Order)

2020-01-07 Thread Haitao Liu
Greg, Jenkins CI would not touch nuttx/ and apps/ end-user directories. Gregory Nutt 于2020年1月8日周三 上午11:58写道: > > Since code check part is available now, could I and Duo prepare to setup > > Jenkins CI job firstly? > > At fist, start to do the PR check stage according to the workflow option > > c

Re: Jenkins CI

2020-01-07 Thread Disruptive Solutions
Is there a “code style” formatter possible for say Eclipse for Apache Nuttx? This can be custom made and gives the quality already while coding? Or is this not preferred adding it to a backend styling in git? Just thinking. Verstuurd vanaf mijn iPhone > Op 8 jan. 2020 om 05:03 heeft Gregor

Re: Jenkins CI

2020-01-07 Thread Gregory Nutt
Since code check part is available now, could I and Duo prepare to setup Jenkins CI job firstly? Where are you intending to set up this job? Here [1] or elsewhere? Hopefully not in the end-user directories :-\ Greg

Re: Working Effectively (was Point of Order)

2020-01-07 Thread Gregory Nutt
Since code check part is available now, could I and Duo prepare to setup Jenkins CI job firstly? At fist, start to do the PR check stage according to the workflow option chosen, then go to the build stage  in the next couple of days. We could optimize all the stages step by step once we start w

Jenkins CI

2020-01-07 Thread Justin Mclean
Hi, Changing subjects. > Since code check part is available now, could I and Duo prepare to setup > Jenkins CI job firstly? Where are you intending to set up this job? Here [1] or elsewhere? Thanks, Justin 1. https://builds.apache.org

Re: Working Effectively (was Point of Order)

2020-01-07 Thread Gregory Nutt
Since code check part is available now, could I and Duo prepare to setup Jenkins CI job firstly? At fist, start to do the PR check stage according to the workflow option chosen, then go to the build stage in the next couple of days. We could optimize all the stages step by step once we start work

Re: Working Effectively (was Point of Order)

2020-01-07 Thread Haitao Liu
Greg, Xiang and All, Since code check part is available now, could I and Duo prepare to setup Jenkins CI job firstly? At fist, start to do the PR check stage according to the workflow option chosen, then go to the build stage in the next couple of days. We could optimize all the stages step by st

Re: Working Effectively (was Point of Order)

2020-01-07 Thread Xiang Xiao
David, why you think this tool promote the violation? With -p or -c option, we can ensure no new code violate the coding style. With -f option, we can review and correct the current code base. The jenkins job can select one option base on the workflow definition, the tool self hasn't any preference

Side-effects of removing (void)

2020-01-07 Thread Gregory Nutt
The removal of (void) from all functions whose return value has been ignored has introduced several new warnings into the build test output.  For example in lpc3_appinit(), I now see this: #  define nsh_spifi_initialize() (OK) and nsh_spifi_initialize(); which now generates a new warni

Imxrt 1050

2020-01-07 Thread Embedded Systems
Hello I wish to ask for little bti help. I updated my nuttx to the latest version since i want to update my work with the latest Nuttx version, because i will resume working on drivers for Imxrt1050, but i am facing a strange problem when i tried the new Nuttx builded the imxrt1050-evk:nsh uploade

Re: Imxrt 1050

2020-01-07 Thread Embedded Systems
Hello, I found what is cousin that behaviour it is the WFI instruction in the idle task. Please excuse me for bothering you. Best regards, Ivan Ucherdzhiev On Tue, Jan 7, 2020 at 3:15 PM Embedded Systems wrote: > Hello > > I wish to ask for little bti help. I updated my nuttx to the > latest v

RE: Working Effectively (was Point of Order)

2020-01-07 Thread David Sidrane
+1 Adding a tool that promotes violating the INVIOLABLES.txt on several aspect (expedience and non conformant code into the repo) feels like a very bad choice. How is this being justified? David -Original Message- From: Alin Jerpelea [mailto:jerpe...@gmail.com] Sent: Tuesday, January 0

Re: Working Effectively (was Point of Order)

2020-01-07 Thread Xiang Xiao
https://github.com/apache/incubator-nuttx/pull/47 checkpatch.sh is ready, you can invoke it like this: tools/checkpatch.sh -p patch-list tools/checkpatch.sh -c commit-list tools/checkpatch.sh -f file-list The first two just check the modified portion, the last one check the whole content. And with

Re: Build testing

2020-01-07 Thread Alin Jerpelea
I am using the same scripts on my test machine and if anyone would like I can dump the daily logs on a github for refference Alin On Thu, Jan 2, 2020 at 6:50 PM Disruptive Solutions < disruptivesolution...@gmail.com> wrote: > Very interesting... I would like to use build scripts in the Jenkins

Re: Working Effectively (was Point of Order)

2020-01-07 Thread Alin Jerpelea
I think that we should update all code with nxstyle then we start with a clean code on which patches will be checked Alin On Tue, Dec 31, 2019 at 3:42 PM Haitao Liu wrote: > Greg, I'll finish the nxstyle & check script these days firstly and then > take time to handle the two issues you mentio