On Friday, January 3, 2020, Gregory Nutt wrote:
>
> Is that because there are more places that don't do it than places that do?
>>
> Yes.. and I think just a matter of personal preference.
>
>> Because it seems to me that the right thing to do is to leave compliant
>> code alone and bring non-com
Ok, got USBDEV_TRACE working and got the NuttX NDIS gadget to connect to my
Linux host, it appears when I do lsusb.
I had to add some NDIS initialization code for the SAMA5D3-xplained board
and debug it using the SEGGER J-Link in order to get it working. I'll post
a PR when I get it working all th
I tried enabling the following config options to turn on USB tracing, but
didn't get any tracing output when I rebooted:
CONFIG_DEBUG_FEATURES=y
> CONFIG_USBDEV_TRACE=y
> CONFIG_USBDEV_TRACE_NRECORDS=5000
> CONFIG_USBDEV_TRACE_STRINGS=y
> CONFIG_NSH_USBDEV_TRACE=n
> CONFIG_NSH_ARCHINIT=y
> CONFIG_
On Thu, Jan 2, 2020 at 10:31 PM Gregory Nutt wrote:
>
> > Ok. I'm okay with that.
>
> Perhaps you could merge this for me:
>
> https://github.com/apache/incubator-nuttx/pull/31
>
> I cannot merge my own contributions. This is a trivial change to the
> the coding standard; Nothing functional is c
Hi,
I am trying to get Ethernet over USB working on the SAMA5D36. I am using
Ubuntu Linux. I configured NuttX as per Alan's video here:
https://www.youtube.com/watch?v=8noH8v7xNgs
https://www.youtube.com/watch?v=dk3jqhn9XQ4
I can compile NuttX and get a shell. I have the ping command.
I don't s
Ok. I'm okay with that.
We do have to avoid making this a habit, however. In this case, we are
talking about an obscure and little know requirement that is not
critical to the overall coding standard.
However, I take responsibility for the faux pas, I forget that it was in
the coding stand
Ok. I'm okay with that.
Perhaps you could merge this for me:
https://github.com/apache/incubator-nuttx/pull/31
I cannot merge my own contributions. This is a trivial change to the
the coding standard; Nothing functional is changed. In this case, you
should just be able to merge the chan
patacongo opened a new pull request #31:
Documentation/NuttXCCodingStandard.html: Remove requirement to decor…
URL: https://github.com/apache/incubator-nuttx/pull/31
Documentation/NuttXCCodingStandard.html: Remove requirement to decorate
ignored returned values with (void).
On Thu, Jan 2, 2020 at 9:59 PM Gregory Nutt wrote:
>
> > Is that because there are more places that don't do it than places that
> do?
> Yes.. and I think just a matter of personal preference.
> > Because it seems to me that the right thing to do is to leave compliant
> > code alone and bring non
Is that because there are more places that don't do it than places that do?
Yes.. and I think just a matter of personal preference.
Because it seems to me that the right thing to do is to leave compliant
code alone and bring non-compliant code into compliance with the standard,
otherwise ther
On Thu, Jan 2, 2020 at 9:47 PM Gregory Nutt wrote:
> At this point, I think we have no real option but to change the coding
> standard to match the code as-is.
Is that because there are more places that don't do it than places that do?
Because it seems to me that the right thing to do is to le
At this point, I think we have no real option but to change the coding
standard to match the code as-is.
On 1/2/2020 8:27 PM, Gregory Nutt wrote:
What is the reason for the recent commits to nuttx and apps that removed
the (void) for ignored return values in thousands of places?
It is also
patacongo merged pull request #30: fix modem/altair semaphore related compiler
warning
URL: https://github.com/apache/incubator-nuttx/pull/30
This is an automated message from the Apache Git Service.
To respond to the messag
patacongo commented on issue #30: fix modem/altair semaphore related compiler
warning
URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570439283
Yes, sorry. The problem was my branch.
This is an automated
patacongo commented on issue #30: fix modem/altair semaphore related compiler
warning
URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570438960
But when I changed the base branch, it went back to 13 commits and 1,647
files. let me recreate the branch.
patacongo commented on issue #30: fix modem/altair semaphore related compiler
warning
URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570438609
Yes, now it says one commit, two files changed. Thanks!
This
What is the reason for the recent commits to nuttx and apps that removed
the (void) for ignored return values in thousands of places?
It is also a coding style issue because the coding style requires (void)
if you choose to ignore the return value from a function
http://nuttx.org/Documentat
xiaoxiang781216 commented on issue #30: fix modem/altair semaphore related
compiler warning
URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570438325
Done, do you see any change?
This is an automated messa
What is the reason for the recent commits to nuttx and apps that removed
the (void) for ignored return values in thousands of places?
Nathan
On Fri, Jan 3, 2020 at 3:10 AM Gregory Nutt wrote:
>
> Here is the summary of build test problems that I have seen. I may
> still encounter more.
>
> Question: Who is going to do the PRs for all of these? I will merge
> the PRs an retest them, but someone else needs to submit them. I have
> su
patacongo commented on issue #30: fix modem/altair semaphore related compiler
warning
URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570437654
Or perhaps just rebase your fork from upstream?
This is an au
patacongo commented on issue #30: fix modem/altair semaphore related compiler
warning
URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570437294
I think your fork is corrupted. It says there are 13 commits and 1,647
files changed. I think you need a new fork.
xiaoxiang781216 opened a new pull request #30: fix modem/altair semaphore
related compiler warning
URL: https://github.com/apache/incubator-nuttx/pull/30
Change-Id: Icfb7af6f1e31397dcadf3e652590cd2a55dc96a7
Signed-off-by: Xiang Xiao
-
All issues already provide the fix:
https://github.com/apache/incubator-nuttx-apps/pull/3
https://github.com/apache/incubator-nuttx/pull/23
Sorry, Kconfig system is too flexible to cover all combinations.
The automation build check is very impotant to ensure the change can
pass all possible configu
On Thu, Jan 2, 2020 at 3:48 PM Gregory Nutt wrote:
> > Please tell me if two patches appear now...
>
> yes, I got them an incorporated them.
>
> We need to fix that. Most users will be submitting changes with the
> .patch suffix.
Deja vu? I thought we had this discussion and asked infra to make
Xiao Xiang, can you fix and verify this one. I think it probably only
needs to include nuttx/semaphore.h too.
You understand that under the newer rules, I have to ask to make this
(probably) small change. I cannot cannot (or should not) contribute the
change as a PR then also merge it.
patacongo merged pull request #29: LPC17xx serial updates
URL: https://github.com/apache/incubator-nuttx/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
macman88 opened a new pull request #29: LPC17xx serial updates
URL: https://github.com/apache/incubator-nuttx/pull/29
For LPC17xx/LPC40xx parts:
- Adds hardware RS-485 support on UART1
- Avoids compiling up_earlyserialinit when USE_EARLYSERIALINIT is not defined
- Incorporates the U
Please tell me if two patches appear now...
yes, I got them an incorporated them.
We need to fix that. Most users will be submitting changes with the
.patch suffix.
Greg
Nathan fixed the problems with icmp/icmp_poll.c. Only this problem
remains (so far).
Xiao Xiang, can you fix and verify this one. I think it probably only
needs to include nuttx/semaphore.h too.
Configuration: spresense:lte
Recommended Fixer: Xiao Xiang
Error:
modem/altair/altmdm_sys.c:
Here is the UPDATED summary of build test problems that I have seen
(Updated). Some of the previously reported errors have been fixed and I
had a configuration problem in apps/ so only these remain for today. I
may still encounter more. later.
Question: Who is going to do the PRs for all of
acassis commented on issue #28: arch/arm/src/stm32/stm32_fmc.c: Missing
semicolons cause compilation errors.
URL: https://github.com/apache/incubator-nuttx/pull/28#issuecomment-570322897
Ok
This is an automated message from
patacongo commented on issue #28: arch/arm/src/stm32/stm32_fmc.c: Missing
semicolons cause compilation errors.
URL: https://github.com/apache/incubator-nuttx/pull/28#issuecomment-570322631
Duplicate of pr27
This is an automa
patacongo closed pull request #28: arch/arm/src/stm32/stm32_fmc.c: Missing
semicolons cause compilation errors.
URL: https://github.com/apache/incubator-nuttx/pull/28
This is an automated message from the Apache Git Service
patacongo merged pull request #27: arch/arm/src/stm32/stm32_fmc.c: fix
compilation error
URL: https://github.com/apache/incubator-nuttx/pull/27
This is an automated message from the Apache Git Service.
To respond to the mess
patacongo opened a new pull request #28: arch/arm/src/stm32/stm32_fmc.c:
Missing semicolons cause compilation errors.
URL: https://github.com/apache/incubator-nuttx/pull/28
This is an automated message from the Apache Git S
On Thu, Jan 2, 2020 at 1:59 PM Gregory Nutt wrote:
>
> Still don't see it
>
> On 1/2/2020 11:19 AM, Nathan Hartman wrote:
> > On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt wrote:
> >>> Recently this warning started showing up in builds:
> > ...
> >>> Patch attached.
> >> I don't see anything attac
acassis merged pull request #26: arch/arm/src/imxrt/imxrt_enet.c: Fix some
warnings found in build te…
URL: https://github.com/apache/incubator-nuttx/pull/26
This is an automated message from the Apache Git Service.
To resp
raiden00pl opened a new pull request #27: arch/arm/src/stm32/stm32_fmc.c: fix
compilation error
URL: https://github.com/apache/incubator-nuttx/pull/27
This is an automated message from the Apache Git Service.
To respond to t
patacongo opened a new pull request #26: arch/arm/src/imxrt/imxrt_enet.c: Fix
some warnings found in build te…
URL: https://github.com/apache/incubator-nuttx/pull/26
arch/arm/src/imxrt/imxrt_enet.c: Fix two warnings found in build testing at
lines 1657 and 1705: "warning: unused variab
Here is the summary of build test problems that I have seen. I may
still encounter more.
Question: Who is going to do the PRs for all of these? I will merge
the PRs an retest them, but someone else needs to submit them. I have
suggested those committers most reponsible for the the bad comm
On Thu, Jan 2, 2020 at 1:59 PM Gregory Nutt wrote:
> Still don't see it
>
> On 1/2/2020 11:19 AM, Nathan Hartman wrote:
> > On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt
> wrote:
> >>> Recently this warning started showing up in builds:
> > ...
> >>> Patch attached.
> >> I don't see anything atta
Still don't see it
On 1/2/2020 11:19 AM, Nathan Hartman wrote:
On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt wrote:
Recently this warning started showing up in builds:
...
Patch attached.
I don't see anything attached.
It would help if I attached the file. :-)
Retrying...
Nathan
wingunder commented on issue #14: Fixed includes in
arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14#issuecomment-570303541
Hi @patacongo & @acassis,
Thank you for you feedback. I accept your reasoning.
Regards
-
patacongo merged pull request #25: SAME5x Ethernet Support
URL: https://github.com/apache/incubator-nuttx/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
patacongo commented on issue #24: Fix wait loop and void cast
URL: https://github.com/apache/incubator-nuttx/pull/24#issuecomment-570288836
Removing the (void) cast actually violates the coding standard. Look at:
http://nuttx.org/Documentation/NuttXCCodingStandard.html#retvalues
macman88 opened a new pull request #25: Same54
URL: https://github.com/apache/incubator-nuttx/pull/25
Adds basic support for Microchip SAM E54 Xplained Pro board.
Adds an Ethernet driver for the SAME5x family (based on the SAMA5 GMAC
driver).
Xiao Xiang,
These are all errors created by your recent changes to nxsem_ code and
also the the .updated target in the apps/ build system.
You should provide the fixes.
On 1/2/2020 11:24 AM, Gregory Nutt wrote:
Same problem in dirvers/modem/altair/altmdm_sys.c -- but worse. More
undedefined nxsem_* functions and the build with that driver also
fails with "undefined reference to nxsem_timedwait_uninterruptible'
LOTs of code breakage with the last PRs! We ne
Very interesting... I would like to use build scripts in the Jenkins solution I
have running to test my STM book configs...
Verstuurd vanaf mijn iPhone
> Op 2 jan. 2020 om 18:40 heeft Gregory Nutt het volgende
> geschreven:
>
>
>> I have some scripts that I use to perform build testing. T
I have some scripts that I use to perform build testing. That is,
just build as many configurations. This only verifies that no
existing builds are broken. It does not prove that a change is
correct or that a change will not break a build that actually uses the
change. It would take a muc
I have some scripts that I use to perform build testing. That is, just
build as many configurations. This only verifies that no existing
builds are broken. It does not prove that a change is correct or that a
change will not break a build that actually uses the change. It would
take a much
On Thu, Jan 2, 2020 at 12:21 PM Nathan Hartman wrote:
>
> On Thu, Jan 2, 2020 at 12:08 PM Gregory Nutt wrote:
> > I am doing a build test now. Yes, I am seeing this new warning too (A
> > LOT). But I am also seeing 'ret may be used uninitialized in this
> > function" in the return value of icmp
Same problem in dirvers/modem/altair/altmdm_sys.c -- but worse. More
undedefined nxsem_* functions and the build with that driver also
fails with "undefined reference to nxsem_timedwait_uninterruptible'
LOTs of code breakage with the last PRs! We need a proper workflow to
prevent this from
Recently this warning started showing up in builds:
icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler':
icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function
'nxsem_post'; did you mean 'sem_post'?
[-Wimplicit-function-declaration]
nxsem_post(info->fds->sem);
On Thu, Jan 2, 2020 at 12:08 PM Gregory Nutt wrote:
> I am doing a build test now. Yes, I am seeing this new warning too (A
> LOT). But I am also seeing 'ret may be used uninitialized in this
> function" in the return value of icmp_pollsetup() in the same file,
> icmp/icmp_netpoll.c
Interesting
On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt wrote:
> > Recently this warning started showing up in builds:
...
> > Patch attached.
>
> I don't see anything attached.
It would help if I attached the file. :-)
Retrying...
Nathan
Recently this warning started showing up in builds:
icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler':
icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function
'nxsem_post'; did you mean 'sem_post'?
[-Wimplicit-function-declaration]
nxsem_post(info->fds->sem);
Recently this warning started showing up in builds:
icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler':
icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function
'nxsem_post'; did you mean 'sem_post'?
[-Wimplicit-function-declaration]
nxsem_post(info->fds->sem);
Recently this warning started showing up in builds:
icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler':
icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function
'nxsem_post'; did you mean 'sem_post'?
[-Wimplicit-function-declaration]
nxsem_post(info->fds->sem);
patacongo merged pull request #24: Fix wait loop and void cast
URL: https://github.com/apache/incubator-nuttx/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
patacongo merged pull request #4: Application.mk remove _main suffix from
REGLIST
URL: https://github.com/apache/incubator-nuttx-apps/pull/4
This is an automated message from the Apache Git Service.
To respond to the message
patacongo merged pull request #5: Unify the void cast usage
URL: https://github.com/apache/incubator-nuttx-apps/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
xiaoxiang781216 opened a new pull request #24: Fix wait loop and void cast
URL: https://github.com/apache/incubator-nuttx/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log
xiaoxiang781216 opened a new pull request #5: Unify the void cast usage
URL: https://github.com/apache/incubator-nuttx-apps/pull/5
1.Remove void cast for function because many place ignore the returned value
witout cast
2.Replace void cast for variable with UNUSED macro
Change-Id:
Is it possible to update Nuttx over the air? Via, for example, the TCP/IP
stack?
Yes, of course, but you would have to implement the update logic. It is
not a part of the OS.
patacongo merged pull request #23: Minor fix
URL: https://github.com/apache/incubator-nuttx/pull/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
acassis merged pull request #22: Add FMC SDRAM for STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
xiaoxiang781216 opened a new pull request #4: Application.mk remove _main
suffix from REGLIST
URL: https://github.com/apache/incubator-nuttx-apps/pull/4
since the file generated by REGISTER macro don't have such suffix
Change-Id: I6814f5bd257563f897c63d9698f8892d9649dcef
Signed-of
xiaoxiang781216 opened a new pull request #23: Minor fix
URL: https://github.com/apache/incubator-nuttx/pull/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Is it possible to update Nuttx over the air? Via, for example, the TCP/IP
stack?
Hi Nathan
On Thursday, January 2, 2020, Nathan Hartman
wrote:
> On Wed, Jan 1, 2020 at 7:27 PM Alan Carvalho de Assis
> wrote:
>
>> HI Nathan,
>>
>> On 1/1/20, Nathan Hartman wrote:
>> > On Wed, Jan 1, 2020 at 1:14 PM Alan Carvalho de Assis <
acas...@gmail.com
>> >
>> > wrote:
>> >> On 1/1/20,
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362422489
##
File path: arch/arm/include/stm32h7/chip.h
##
@@ -167,9 +167,9 @@
#endif
#if defined(CONFIG_STM32F7_HA
yukihiratype2 commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362421158
##
File path: arch/arm/src/stm32h7/hardware/stm32_fmc.h
##
@@ -0,0 +1,390 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362419439
##
File path: arch/arm/src/stm32h7/hardware/stm32_fmc.h
##
@@ -0,0 +1,390 @@
+/**
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362418718
##
File path: arch/arm/src/stm32/stm32_fmc.c
##
@@ -1,7 +1,7 @@
/**
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362412188
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,196 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362412237
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,196 @@
+/***
That would be very nice!
Op wo 1 jan. 2020 19:57 schreef Dave Marples :
> Ben,
>
> I have this up and running on an imxrt with a 'generic' spi driver
> (i.e.that should work with any spi device rather than the platform specific
> one that was previously in use). When I'm back at my desk this even
yukihiratype2 commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362405763
##
File path: arch/arm/src/stm32h7/Make.defs
##
@@ -141,6 +141,10 @@ ifeq ($(CONFIG_STM32H7_DMA),y)
CHIP_
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362405230
##
File path: arch/arm/src/stm32h7/Make.defs
##
@@ -141,6 +141,10 @@ ifeq ($(CONFIG_STM32H7_DMA),y)
CHIP_CSR
yukihiratype2 commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362404120
##
File path: arch/arm/src/stm32h7/stm32_fmc.h
##
@@ -0,0 +1,159 @@
+/
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362403843
##
File path: arch/arm/src/stm32h7/hardware/stm32_fmc.h
##
@@ -0,0 +1,390 @@
+/**
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362403221
##
File path: arch/arm/src/stm32h7/stm32_fmc.h
##
@@ -0,0 +1,159 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362402369
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,193 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362402038
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,193 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362401691
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,193 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362400857
##
File path: arch/arm/src/stm32h7/Kconfig
##
@@ -41,6 +41,7 @@ config STM32H7_STM32H7X3XX
select ARM
88 matches
Mail list logo
