[PATCH] doubt about fwrite

2019-12-22 Thread wei peng
hi~ I connected the target board to terminal via "telnet" , in some cases the terminal will be frozen. Here are detailed steps: 1. Enable "CONFIG_IOB_DEBUG"[necessary]. 2. New two terminals and connect to target board via "telnet". 3. Input "dmesg" command,and the terminal will show in

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
xiaoxiang781216 commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568378194 @btashton @davids5 What I mean here is that we don't need modify Makefile, is engouh to add a script invoke nxstyle(maybe build it too) to check

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360783003 ## File path: tools/check_code_style.sh ## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + +if [ -z "$1" ]; then +

Re: problem booting NuttX on SAMA5D3-Xplained

2019-12-22 Thread Gregory Nutt
Make sure you compile with debug info enabled and no optimization. Then, since you mentioned you have a Segger J-Link JTAG probe, I highly recommend you use Segger’s debugger Ozone (free J-Link probes) — you’ll be able to easily single-step and determine what’s going wrong… If you have a J-L

Re: problem booting NuttX on SAMA5D3-Xplained

2019-12-22 Thread David S. Alessio
Hello Adam, Make sure you compile with debug info enabled and no optimization. Then, since you mentioned you have a Segger J-Link JTAG probe, I highly recommend you use Segger’s debugger Ozone (free J-Link probes) — you’ll be able to easily single-step and determine what’s going wrong… Regard

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Brennan Ashton
On Sun, Dec 22, 2019 at 8:18 PM Nathan Hartman wrote: > > Yesterday I wrote a detailed email giving the exact outline of what needs > to be in that workflow document. > > Do we really have no volunteers to bang out even a rough draft of that > document? > > You both sucked me in again... But thi

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
The danger of what is happening now is that it will become grandfathered in with no proper workflow in place, no proper criteria for processing changes, and no clear documentation that helps committers or the public to contribute. If that comes to pass, I think I would be forced to resign. Ap

[GitHub] [incubator-nuttx] btashton commented on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
btashton commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568350703 @xiaoxiang781216 You can create a script that you recommend is run as pre-commit, but the actual hooks are outside of the git working directory, so it

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
The danger of what is happening now is that it will become grandfathered in with no proper workflow in place, no proper criteria for processing changes, and no clear documentation that helps committers or the public to contribute. We have to decline any attempt to include an test framework co

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Nathan Hartman
On Sun, Dec 22, 2019 at 9:02 PM Gregory Nutt wrote: > > > But the #1 most critical thing facing this project is adopting even > > just the requirements for the workflow. None of the other issues have > > any significant importance > > > > So I have to be opposed to any obstacles that jeopardize

Re: problem booting NuttX on SAMA5D3-Xplained

2019-12-22 Thread Gregory Nutt
My question is: Should I be able to see a NSH console on the debug serial port? Or the USB serial port? I don't see either devices when I look at the host system's /dev/ directory. You would have to look at the SERIAL_CONSOLE setting in the configuration file to find out.  I don't recall.

Re: problem booting NuttX on SAMA5D3-Xplained

2019-12-22 Thread Gregory Nutt
Check the configuration that you are using.  What is the UART used in the NuttX configuration for the serial console?  What is the UART that connects to the debug port? Do you have a jtag debugger?  There should be instructions in the README explaining how to single step into the OS.  You shou

Fwd: [nuttx] [PATCH] doubt about fwrite

2019-12-22 Thread Gregory Nutt
Forwarded Message Subject:[nuttx] [PATCH] doubt about fwrite Date: Sun, 22 Dec 2019 18:30:04 -0800 (PST) From: wei peng Reply-To: nu...@googlegroups.com To: NuttX hi~   I connected the target board to terminal via "telnet" , in some cases the terminal

[GitHub] [incubator-nuttx] btashton commented on issue #1: imxrt fixes

2019-12-22 Thread GitBox
btashton commented on issue #1: imxrt fixes URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568330736 @davids5 This touches some of the same IO stuff that I have been working on on the imxrt platform, some of the changes are style. Did you make these changes via one of

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
But the #1 most critical thing facing this project is adopting even just the requirements for the workflow.  None of the other issues have any significant importance So I have to be opposed to any obstacles that jeopardize or distract from the #1 priority thing. One of the dangers of dela

[GitHub] [incubator-nuttx] Ouss4 commented on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
Ouss4 commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568320150 > I must have hit close again? I don't know, it never said re-opened, eventhough it should re-open the moment you comment.

[GitHub] [incubator-nuttx] patacongo commented on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568319546 @Ouss4 Thanks! It said it was open in my page. I must have hit close again? It is kind of goosey but I attribute that to the fact the I am a github

[GitHub] [incubator-nuttx] davids5 opened a new pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 opened a new pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2 @patacongo - This will get us off the ground on the formatting tool we can get in to the workfow. We are going to need your expertise on the the makefile

[GitHub] [incubator-nuttx] Ouss4 commented on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
Ouss4 commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568318466 Yes close without merging is like decline. It's still closed btw. This is an automated

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
I will be stepping away from all further discussion on the work flow topic as I have soured on it and don't have a real vote beyond proposing it. You are lucky that you have that option.  I would too if it were possible.  This no way that anyone should have to waste there life. But the #1

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo edited a comment on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600 What is this? How did I do this? What does closed mean? Is that like declined? What was closed? Do I need to unclose something? ...

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo edited a comment on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600 What is this? How did I do this? What does closed mean? Is that like declined? What was closed? Do I need to unclose something? -

[GitHub] [incubator-nuttx] patacongo commented on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600 What is this? How did I do this? What does closed mean? What was closed? This is an

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
I don't like it because it is not the workflow that has been discussed and I can never support a slam dunk of any workflow that is not described in the workflow requirements document. I will vote -1 if we cannot be assured that this this cannot become a disease that we cannot shake.  My propos

Re: Subscribe nuttx Apache Email List

2019-12-22 Thread Duo Zhang
Please send an email to dev-subscr...@nuttx.apache.org for subscribing. Nii Jyeni 于2019年12月23日周一 上午5:25写道: > Hi, > I want to contribute to Nuttx, > I want to share some idea to Nuttx. > > BR > NiiJyeni >

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Brennan Ashton
I proposed this because I think it is a solid flow and in alignment with other stable opensource projects that I contribute to including one under the FSF complexity. It is NOT a rush and I don't think it is out of line. Multiple +1 were given, so I don't think it's that far off what will work.

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
There are several things I don't like about this proposal: - It is in complete conflict with everything we have discussed about the commit workflow - I think is is suggest out of panic.  We have plenty of times to do things right or to do things better.  There will be no pressi

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
There are several things I don't like about this proposal: - It is in complete conflict with everything we have discussed about the commit workflow - I think is is suggest out of panic.  We have plenty of times to do things right or to do things better.  There will be no pressing nee

[VOTE] - votes must say [VOTE]

2019-12-22 Thread David Sidrane
Please accept my most humble apologies for not including the correct details in the original email This is a Consensus approval vote and it will close 72 hours after it was opened. -- Forwarded message - From: David Sidrane Date: Sun, Dec 22, 2019, 7:14 AM Subject: Re: [VOTE] - vo

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo edited a comment on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568309238 I added Xiao Xiang to the reviewers. We need to have a lot of concurrence here since this PR implements a portion of the workflow while there n

[GitHub] [incubator-nuttx] patacongo commented on issue #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568309238 I added Xiao Xiang to the reviewers. We need to have a lot of concurrence here since this PR implements a portion of the workflow while there no workf

[GitHub] [incubator-nuttx] patacongo closed pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo closed pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360732967 ## File path: tools/check_code_style.sh ## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + Review comment: Missing li

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730444 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730444 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730399 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

Subscribe nuttx Apache Email List

2019-12-22 Thread Nii Jyeni
Hi, I want to contribute to Nuttx, I want to share some idea to Nuttx. BR NiiJyeni

Re: [VOTE] - votes must say [VOTE]

2019-12-22 Thread Justin Mclean
HI, > Also, if you don't specify the criteria for accepting the vote, I assume that > it must be a simple majority of those who vote. Votes, are almost never a simple majority, releases come close where a -1 is not a veto but you need 3 +1 votes. Please see [1] and [2]. For most decision make

Re: votes must say [VOTE]

2019-12-22 Thread Justin Mclean
HI, > Should the [VOTE] phase also be preceded by a [DISCUSS] phase so that people > can have a chance to discuss, debate, haggle, argue, first? It’s best if that is done, as I’ve mentioned before yes. Votes shod be used to confirm consensus not split the community. > A follow on questions is

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360729083 ## File path: tools/nxstyle.c ## @@ -140,7 +207,7 @@ int main(int argc, char **argv, char **envp) maxline = 7

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728886 ## File path: tools/nxstyle.c ## @@ -171,20 +238,21 @@ int main(int argc, char **argv, char **envp) } else

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728789 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728732 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728415 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728147 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728147 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT)

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727717 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -C "

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727720 ## File path: tools/check_code_style.sh ## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + +if [ -z "$1" ]; then + FILES

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727718 ## File path: tools/check_code_style.sh ## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + +if [ -z "$1" ]; then + FILES

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727667 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT) all

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727398 ## File path: tools/check_code_style.sh ## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + +if [ -z "$1" ]; then + FI

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727425 ## File path: tools/check_code_style.sh ## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + +if [ -z "$1" ]; then + FI

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727266 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727266 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623 ## File path: tools/Makefile.unix ## @@ -697,3 +704,8 @@ apps_distclean: ifneq ($(APPDIR),) $(Q) $(MAKE) -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726498 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726228 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(F

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726015 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(F

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725880 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATA

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725846 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATA

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725908 ## File path: tools/nxstyle.c ## @@ -61,6 +100,34 @@ static void show_usage(char *progname, int exitcode) exit(exit

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726048 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATAL,

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725892 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATA

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725965 ## File path: tools/nxstyle.c ## @@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp) (strcmp(l

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725490 ## File path: tools/nxstyle.c ## @@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp) (strcm

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725833 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATA

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725817 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATA

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725723 ## File path: tools/nxstyle.c ## @@ -171,20 +238,21 @@ int main(int argc, char **argv, char **envp) } else

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725633 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT) all

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725573 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT)

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725585 ## File path: tools/nxstyle.c ## @@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp) (strcmp(l

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725573 ## File path: tools/Makefile.unix ## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725490 ## File path: tools/nxstyle.c ## @@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp) (strcm

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725443 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATA

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725416 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATA

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725475 ## File path: tools/nxstyle.c ## @@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp) (strcm

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725448 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(FATAL,

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725385 ## File path: tools/nxstyle.c ## @@ -61,6 +100,34 @@ static void show_usage(char *progname, int exitcode) exit(e

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725366 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(F

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725335 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(F

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725352 ## File path: tools/nxstyle.c ## @@ -50,6 +50,45 @@ #define LINE_SIZE512 +#define FATAL(m) message(F

[GitHub] [incubator-nuttx] davids5 opened a new pull request #2: Master pr nxstyle improvments

2019-12-22 Thread GitBox
davids5 opened a new pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2 @patacongo - This will get us off the ground on the formatting tool we can get in to the workfow. We are going to need your expertise on the the makefile

Re: Community

2019-12-22 Thread Gregory Nutt
Don't feel bad if there is haggling. Any document, no matter who writes it or how well, will need more work to fill in missing pieces, edit, etc., to bring it to "shipping quality." I will try to help as much as I can in the coming days, but as I said I'm really swamped right now. But there a

Re: Community

2019-12-22 Thread Nathan Hartman
On Sun, Dec 22, 2019 at 2:16 PM Gregory Nutt wrote: > > > > >> Hopefully someone with technical writing skills will volunteer to > >> read that > >> email and start working on that document. If not, I'll do it, but it > >> will > >> be delayed because I am completely swamped right now. > > > > I

Re: Community

2019-12-22 Thread Gregory Nutt
Hopefully someone with technical writing skills will volunteer to read that email and start working on that document. If not, I'll do it, but it will be delayed because I am completely swamped right now. I think that the other people most active in the discussion are DavidS and myself, b

Re: Away for two weeks

2019-12-22 Thread Alin Jerpelea
Enjoy vacation! On Sat, Dec 21, 2019, 08:18 David Sidrane wrote: > Enjoy! > > -Original Message- > From: Justin Mclean [mailto:jus...@classsoftware.com] > Sent: Friday, December 20, 2019 5:07 PM > To: dev@nuttx.apache.org > Subject: Away for two weeks > > H, > > I’m off on a two week bre

Re: Community

2019-12-22 Thread Gregory Nutt
Hopefully someone with technical writing skills will volunteer to read that email and start working on that document. If not, I'll do it, but it will be delayed because I am completely swamped right now. I think that the other people most active in the discussion are DavidS and myself, but f

Re: Community

2019-12-22 Thread Nathan Hartman
On Sun, Dec 22, 2019 at 9:00 AM Gregory Nutt wrote: > Writing directly into the repository was certainly the wrong thing at > the wrong time since I was tasked to maintain the repository. But I > relinquish both the task of personally reviewing and managing the flow > all changes. So now it is

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
I don't think that were will be much that has to be acted on during the holidays. And, in any event, I would rather see a backlog of work build up than to to see an interim, wrong workflow put in place. Doing things right is more important that doing things quickly. I would add that I do no

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
Let's get everyone's thoughts on the table I suppose that we should keep the discussion for 72 hours then call the vote.  We need to allow time for everyone to comment and with the holidays, we may not be able to get good feedback. Should we still call a vote if people are not participatin

Re: [DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
1) The timeline. Two weeks over the holiday to come to a formal agreement is going to be tough and I also don't think just because we have a path forward people will stop caring about proposing a better solution.  From what I'm seeing the longer term proposal will likely get into the weeds of

[DISCUSS] Simple Workflow Proposal

2019-12-22 Thread Gregory Nutt
Let's get everyone's thoughts on the table I did not call for a vote because I did not think I could as I'm just a community member, I would like my proposal formally voted it on as is. As for the two concerns that I saw raised. 1) The timeline. Two weeks over the holiday to come to a formal

Re: Simple Workflow Proposal

2019-12-22 Thread Brennan Ashton
I did not call for a vote because I did not think I could as I'm just a community member, I would like my proposal formally voted it on as is. As for the two concerns that I saw raised. 1) The timeline. Two weeks over the holiday to come to a formal agreement is going to be tough and I also don'

Re: [VOTE] - votes must say [VOTE]

2019-12-22 Thread Alin Jerpelea
+1 On Sun, Dec 22, 2019, 17:45 Gregory Nutt wrote: > > > I thought I was being humorous in replying with +1. But [VOTE] is in > > the title so I guess this is a real, binding vote. That wasn't clear > > from the text. I am so confused. Anway, my +1 vote still stands, > > just not as funny an

Re: [VOTE] - votes must say [VOTE]

2019-12-22 Thread Gregory Nutt
I thought I was being humorous in replying with +1.  But [VOTE] is in the title so I guess this is a real, binding vote.  That wasn't clear from the text.  I am so confused.  Anway, my +1 vote still stands, just not as funny anymore. You did not mention how long the vote will be open for.

Re: [VOTE] - votes must say [VOTE]

2019-12-22 Thread Gregory Nutt
I thought I was being humorous in replying with +1.  But [VOTE] is in the title so I guess this is a real, binding vote.  That wasn't clear from the text.  I am so confused.  Anway, my +1 vote still stands, just not as funny anymore. You did not mention how long the vote will be open for. 

Re: votes must say [VOTE]

2019-12-22 Thread Gregory Nutt
Should the [VOTE] phase also be preceded by a [DISCUSS] phase so that people can have a chance to discuss, debate, haggle, argue, first?  Calling a vote out the blue leaves people in a position of having to make a decision cold. On 12/22/2019 9:26 AM, Gregory Nutt wrote: Removing the initial [

votes must say [VOTE]

2019-12-22 Thread Gregory Nutt
Removing the initial [VOTE] in an attempt at removing ambiguity (although [VOTE] is still in the tile). Let's dispense with the ALL ambiguity We should assume if it does not say [VOTE] it is not a vote? A follow on questions is who can call a binding vote?  I searched apache a little, but did

  1   2   >