Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196988395
I am a +1 on merging this PR in (once commits have been squashed).
I reviewed the code, did a contrib check build and did basic testing with
ActiveMQ. With @di
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196861594
Agreed and the JIRA is https://issues.apache.org/jira/browse/NIFI-1628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196858986
i am on the same page of this being a good start oleg provided the JIRA is
created to enable ssl context to provide info for providers that want it. We
don't have support
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196855425
So the problem with Tibco and SSL is that Tibco does things differently
then other providers. In other words they don't use SSLContext and instead rely
on setting individual
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196535593
I'll look at it. I think I know what's going on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user mosermw commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196532379
Yep, that's what I did. The TibjmsConnectionFactory must not see the
truststore I set in the SSL Context Service. I'm worried that different JMS
providers require differ
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196527092
@mosermw shouldn't you just be able to create a typical SSL controller
service and set the "SSL Context Service" property to point to it? This should
automatically use
Github user mosermw commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196508227
Tested using Tibco with SSL, didn't work.
ERROR o.a.n.jms.processors.PublishJMS
org.springframework.jms.JmsSecurityException: Can not initialize SSL client: no
tr
Github user digitalplummer commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-196402216
Tested on IBM MQ 7.5 and greater
WebSphere
Tibco
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195528105
Build is still failing contrib check after the latest patches due to:
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @
nifi-jms-cf-service ---
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195428868
Why are the docs needed as place holders? It is not a breaking change to
adding additional documentation pages in the future. Details regarding simple
capability descri
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195427526
We'll be adding more docs in there in the future related to specific
providers (e.g., IBM, Tibco etc), so treat it as place holder
---
If your project is set up for it, yo
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195427093
What was the motivation for creating an additional details page for the
Publish/Consume processors that is just a summary and an overview of the
configuration? Both of
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195413029
New commits fail contrib-check for these reasons:
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @
nifi-jms-processors ---
[WARNING]
src/main/
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-195006367
Following the pattern for Controller Services and their API in
nifi-standard-services, JMSConnectionFactoryProviderDefinition should be in
it's own package.
---
If y
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/222#issuecomment-194997331
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/222#discussion_r53622460
--- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/.gitignore
---
@@ -0,0 +1 @@
+/lib/
--- End diff --
It isn't ;)
---
If your proj
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/222#discussion_r53268977
--- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/.gitignore
---
@@ -0,0 +1 @@
+/lib/
--- End diff --
why is this necessary?
---
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/222
NIFI-614 Added initial support for new style JMS
NIFI-614 finalized JMSConnectionFactoryProvider ControllerService
NIFI-614 finalized implementation of both Processors and ControllerService
20 matches
Mail list logo
