Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/478
looks good. if you don't mind, I'll amend the commit and throw a static on
that constant before pushing
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65299383
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65223758
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65219394
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65196703
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/478
I've started reviewing this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jskora closed the pull request at:
https://github.com/apache/nifi/pull/430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user jskora commented on the pull request:
https://github.com/apache/nifi/pull/430#issuecomment-222580134
This as it was replaced by [Pull Request
478](https://github.com/apache/nifi/pull/478).
---
If your project is set up for it, you can reply to this email and have your
rep
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/478
NIFI-1754 Rollback log messages should include the flowfile filename â¦
â¦and UUID to assist in flow management. Incorporates debug logging into
StandardProcessSession.rollback() to list Flowfile re
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63410760
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63405577
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlowDebugger.java
---
@@ -0,0 +1,414
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63405091
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63296926
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java ---
@@ -109,6 +109,19 @@
void rollback(boolean penalize);
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63296904
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63279086
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63279016
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java ---
@@ -109,6 +109,19 @@
void rollback(boolean penalize);
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63277496
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -21,13 +21,19 @@
public abstract class AbstractProcessor extends
A
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63277482
--- Diff: nifi-api/pom.xml ---
@@ -21,5 +21,12 @@
0.7.0-SNAPSHOT
nifi-api
-jar
+jar
+
+
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63242199
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlowDebugger.java
---
@@ -0,0 +1,414
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63241990
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository/TestStandardProcessSession.j
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63241497
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63239852
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63239617
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63238261
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java ---
@@ -109,6 +109,19 @@
void rollback(boolean penalize);
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r6323
--- Diff: nifi-assembly/pom.xml ---
@@ -322,6 +322,10 @@ language governing permissions and limitations under
the License. -->
30
sec
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63237500
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java ---
@@ -109,6 +109,19 @@
void rollback(boolean penalize);
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63235023
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -21,13 +21,19 @@
public abstract class AbstractProcessor extends
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63233681
--- Diff: nifi-api/pom.xml ---
@@ -21,5 +21,12 @@
0.7.0-SNAPSHOT
nifi-api
-jar
+jar
+
+
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/430
NIFI-1754 Rollback log messages should include the flowfile filename and
UUID
* Add optional functionality for the Processor framework to maintain a
count of flowfile rollbacks in a flowfile attribute
29 matches
Mail list logo
