Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/294#issuecomment-200355764
@mcgilman I looked at the commit that you proposed. Looks good! +1. Thanks
for jumping in there and fixing that!
---
If your project is set up for it, you can reply to t
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/294#issuecomment-23951
@markap14 Proposed commit for my comments [1]. If this looks good to you,
I'll include them in your PR.
[1]
https://github.com/mcgilman/nifi/commit/9796e7620cb06
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/294#issuecomment-199837163
Also, in nf-cluster-search.js we can delete line 72 and 172. We no longer
need to set:
`nf.SummaryTable.systemDiagnosticsUrl`
Setting the clusterNodeId o
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/294#issuecomment-199835774
@markap14 Unfortunately, the changeset is too big for me to comment on
directly. But in nf-counters-table.js the Ajax request on line 281 does not
need to set the nodewis
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/294#discussion_r56988394
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/CounterDTO.java
---
@@ -98,4 +98,12
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/294#discussion_r56984358
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/CounterDTO.java
---
@@ -98,4 +98,12
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/294#discussion_r56890522
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/pom.xml
---
@@ -26,5 +26,13 @@
com.wordnik
s
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/294#issuecomment-199458161
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/294
NIFI-1563: Federate requests and merge responses from nodes instead oâ¦
â¦f storing bulletins and stats at NCM
- Updating UI to support restructured status history DTO.
Return 'Ins
10 matches
Mail list logo
