[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 Hey @mans2singh, I'm really busy this week and I won't be able to have a look before next week :( In the meantime, you can fix the conflicts against master. And maybe @apiri will hav

[GitHub] nifi pull request #599: NIFI-2156: Add ListDatabaseTables processor

2016-06-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/599#discussion_r69217243 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java

[GitHub] nifi pull request #599: NIFI-2156: Add ListDatabaseTables processor

2016-06-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/599#discussion_r69216929 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListDatabaseTables.java

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-27 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 Hi @mans2singh, I didn't find time to give it a new try, but I hope I will this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r68430574 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2016-06-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/379 Thanks for the review @apiri! I still need to take into account some of your comments but I rebased the PR against master. While doing some additional testing, for a reason I can't explai

[GitHub] nifi pull request #379: NIFI-1022 Added Tachyon/Alluxio processors

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/379#discussion_r67956841 --- Diff: nifi-nar-bundles/nifi-alluxio-bundle/nifi-alluxio-processors/src/main/java/org/apache/nifi/processors/alluxio/AbstractAlluxioProcessor.java

[GitHub] nifi pull request #379: NIFI-1022 Added Tachyon/Alluxio processors

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/379#discussion_r67956421 --- Diff: nifi-nar-bundles/nifi-alluxio-bundle/nifi-alluxio-processors/src/main/java/org/apache/nifi/processors/alluxio/GetAlluxio.java --- @@ -0,0 +1,184

[GitHub] nifi pull request #379: NIFI-1022 Added Tachyon/Alluxio processors

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/379#discussion_r67956263 --- Diff: nifi-nar-bundles/nifi-alluxio-bundle/nifi-alluxio-processors/src/main/java/org/apache/nifi/processors/alluxio/AbstractAlluxioProcessor.java

[GitHub] nifi pull request #379: NIFI-1022 Added Tachyon/Alluxio processors

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/379#discussion_r67956202 --- Diff: nifi-nar-bundles/nifi-alluxio-bundle/nifi-alluxio-processors/src/main/java/org/apache/nifi/processors/alluxio/AbstractAlluxioProcessor.java

[GitHub] nifi issue #551: Removed duplicate dependency declaration from nifi-standard...

2016-06-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/551 Merged in master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi pull request #552: NIFI-2066 dynamic port allocation in SNMP processors...

2016-06-21 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/552 NIFI-2066 dynamic port allocation in SNMP processors unit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-2066

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r67826945 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestQueryDNS.java --- @@ -0,0 +1,164

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r67825492 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/AbstractEnrichProcessor.java --- @@ -0,0

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67825033 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-21 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67824794 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -36,7 +36,7 @@ public void testPenalizeFlowFileFromProcessor

[GitHub] nifi pull request #547: NIFI-2060 - fixed unit tests to be compatible with 2...

2016-06-20 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/547 NIFI-2060 - fixed unit tests to be compatible with 2.7.x It’s a shame to limit what is tested here (in terms of event types) but it seems to be the only way to have both 2.6 and 2.7 lines

[GitHub] nifi issue #398: NIFI-1751 Added proxy authentication in InvokeHttp processo...

2016-06-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/398 Yep, not sure it's worth it. I think it is fine to let the PR as is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] nifi issue #398: NIFI-1751 Added proxy authentication in InvokeHttp processo...

2016-06-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/398 Hey @apiri, Many thanks for the review! Regarding HTTPS, at the time I submitted the PR I was testing it with CCProxy (on Windows computer). I can't test it again with this

[GitHub] nifi issue #545: NIFI-2009 port for 0.x

2016-06-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/545 Thanks @olegz! I just merged it into 0.x, could you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #534: Fix for NIFI-1838 & NIFI-1152

2016-06-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/534 thanks @PuspenduBanerjee, I'm quite busy this WE, will have another look asap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] nifi issue #536: NIFI-1037 Ported processor for HDFS' inotify events to 0.x.

2016-06-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/536 Thanks @JPercivall! I didn't realize that... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #536: NIFI-1037 Ported processor for HDFS' inotify events to 0.x.

2016-06-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/536 @jjmeyer0 Thanks! I just merged it in 0.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request #401: NIFI-1832 Allowing expression language in properties...

2016-06-16 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 @jjmeyer0 LGTM +1 tested with workflows, mvn build OK. Merged in master, but would you mind opening a specific PR for 0.x branch (Java 7 compatible): GetHDFSEvents.java:[208,78] error: local

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67428396 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67424962 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -55,4 +55,35 @@ public void onTrigger(final ProcessContext ctx

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67423663 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67392290 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -55,4 +55,35 @@ public void onTrigger(final ProcessContext ctx

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67391289 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -36,7 +36,7 @@ public void testPenalizeFlowFileFromProcessor

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67390898 --- Diff: nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java --- @@ -16,6 +16,9 @@ */ package org.apache.nifi.util

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67390752 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile

[GitHub] nifi pull request #534: Fix for NIFI-1838 & NIFI-1152

2016-06-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/534#discussion_r67390513 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -587,13 +589,15 @@ public void transfer(final FlowFile flowFile, final

[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor

2016-06-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/272 It should be OK, let me know if not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #257: NIFI-1537 Added SNMP processors

2016-06-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/257 @olegz half-time ;) done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi issue #527: NIFI-2009 removed 'annotationData' and 'validationContextFa...

2016-06-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/527 @olegz It seems it is in conflict with 0.x branch, could you check if I am wrong and if not submit a PR for 0.x? --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #527: NIFI-2009 removed 'annotationData' and 'validationContextFa...

2016-06-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/527 LGTM +1. Do you mind fixing the import auto-ordering? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-14 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 @mans2singh Just had a new look and ran a workflow to test the processor. Few remarks even though I am not familiar with Ignite... First, I am not sure to see how I can check the content of

[GitHub] nifi issue #521: NIFI-1998: Upgraded Cassandra driver to 3.0.2

2016-06-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/521 LGTM +1. Merged both in 0.x and master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #521: NIFI-1998: Upgraded Cassandra driver to 3.0.2

2016-06-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/521 reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 Your changes look good to me. Let me know if you want to have a look to enable EL/RegEx on HDFS_PATH_TO_WATCH property (ReplaceText processor seems to accept both regex and expression language on

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 Thanks @mans2singh ! I'll have a look asap (probably on Sunday or next week). Regarding the provenance event, I think we could have a SEND event for each flow file successfully sent to I

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 @jjmeyer0 Yes you're absolutely right, I was not suggesting to have the three options together but rather think about what could be done to give more flexibility. I think there is a processor

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66516313 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/resources/ignite-client.xml --- @@ -0,0 +1,26 @@ + + +http

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66515866 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/AbstractIgniteProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66514230 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/AbstractIgniteCacheProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66514855 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66514607 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66513705 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66513495 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66513208 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66512938 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r66510540 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/AbstractIgniteProcessor.java

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-06-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 @mans2singh Could you check all the lines marked as removed? I believe there should not be any and this is probably because of some settings in your IDE. --- If your project is set up for it, you

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-08 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 I have played with it and it works great. One remark: I am wondering if the 'HDFS_PATH_TO_WATCH' property should be improved: - accept the expression language to handle ti

[GitHub] nifi issue #257: NIFI-1537 Added SNMP processors

2016-06-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/257 @trixpan @olegz @michalklempa I rebased the PR against master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #493: NIFI-1037 Created processor that handles HDFS' inotify even...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/493 Once comments are addressed, I'll have another look and give it a try but it looks good to me. It's a nice feature! --- If your project is set up for it, you can reply to this email and

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65967740 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65966688 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65961941 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65957598 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/EventAttributes.java --- @@ -0,0

[GitHub] nifi issue #487: NIFI-1956 added 'keyboard-interactive' option to SFTPTransf...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/487 Agree. Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65879551 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/EventAttributes.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65878804 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65878313 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi pull request #493: NIFI-1037 Created processor that handles HDFS' inoti...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/493#discussion_r65878170 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/inotify/GetHDFSEvents.java --- @@ -0,0

[GitHub] nifi issue #486: NIFI-1929: Improvements for PutHDFS attribute handling

2016-06-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/486 +1 @mattyb149 merged in master and 0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #487: NIFI-1956 added 'keyboard-interactive' option to SFTPTransf...

2016-06-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/487 @olegz Just to be sure before merging in: do you plan to add a unit test? My guess is that it is not possible to simulate this server-side behavior, but I want to confirm. --- If your

[GitHub] nifi issue #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/492 I am running out of time right now, but will have a deeper look later and give it a try asap. As a general comment, I'd say, even if I know how boring it can be, that some comments in the

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65755925 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java --- @@ -0,0 +1,352

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65755477 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java --- @@ -0,0 +1,352

[GitHub] nifi issue #490: NIFI-1959 Added length and timestamp to detect rollover

2016-06-02 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/490 It remains an issue I have not been able to solve at this point: the case where the new file contains more data than the tailed file before being moved. In this case we ends up in the same

[GitHub] nifi pull request #490: NIFI-1959 Added length and timestamp to detect rollo...

2016-06-02 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/490 NIFI-1959 Added length and timestamp to detect rollover It improves robustness of the processor in case the property “Rolling filename pattern” is not set and the tailed file is moved for some

[GitHub] nifi issue #481: NiFi 1945 - Corrects minor issue in HashContent "

2016-06-01 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/481 Good catch. Will merge. However not sure why the travis build failed... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1915 Fixed '$' escape logic.

2016-06-01 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/466 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] nifi pull request: NIFI-1942 Processor to validate CSV against use...

2016-05-30 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/476 NIFI-1942 Processor to validate CSV against user-supplied schema This processor is designed to validate a CSV formatted FlowFile against a user-supplied schema. It leverages Cell

[GitHub] nifi pull request: NIFI-1913 Properly removing flowfile in HandleH...

2016-05-23 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/462#issuecomment-221058590 There is a double space on line 160 in test class. Travis seems not to be run on 0.x branch so I don't know if contrib check would fail because of that (c

[GitHub] nifi pull request: NIFI-1811 Removed ProcessorLog and updated depe...

2016-05-19 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/403#issuecomment-220421867 No problem @apiri. I agree: the sooner the better. Let me know if you need something from my side. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request: NIFI-1822 ExecuteScript should allow concurrent...

2016-05-17 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/443#issuecomment-219855457 Maven build with contrib-check OK. Reviewed and it LGTM, nice unit testing. Tested with two different flows and it is working as expected. I'm a +1 -

[GitHub] nifi pull request: NIFI-1296, NIFI-1680, NIFI-1764, NIFI-1837, NIF...

2016-05-17 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/366#issuecomment-219830951 Reviewed and tested. LGTM. All tested flows were OK. Few minor remarks: - I'd update @CapabilityDescription to help users differentiate Publish/Put

[GitHub] nifi pull request: NIFI-1213 (branch 0.x) Added the possibility to...

2016-05-17 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1213 (branch 0.x) Added the possibility to...

2016-05-17 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/451 NIFI-1213 (branch 0.x) Added the possibility to register FlowFile ass… …ertions in mock framework You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request: NIFI-1866 ProcessException handling in Standard...

2016-05-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/439#discussion_r63429069 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository

[GitHub] nifi pull request: NIFI-1866 ProcessException handling in Standard...

2016-05-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/439#discussion_r63423341 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository

[GitHub] nifi pull request: NIFI-1213 Added the possibility to register Flo...

2016-05-16 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/404#issuecomment-219539616 Thanks @olegz PR updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] nifi pull request: NIFI-1755 (0.x branch) Fixed remote process gro...

2016-05-16 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1866 ProcessException handling in Standard...

2016-05-12 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/439 NIFI-1866 ProcessException handling in StandardProcessSession You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-1866

[GitHub] nifi pull request: NIFI-1564: No supported viewer issue

2016-05-12 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/421#issuecomment-218876809 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: NIFI-1755 (0.x branch) Fixed remote process gro...

2016-05-12 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/438 NIFI-1755 (0.x branch) Fixed remote process group status counts by on… …ly considering connected remote ports You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi pull request: NIFI-1755 Fixed remote process group status cou...

2016-05-12 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/347#issuecomment-218867090 @olegz Thanks Oleg! Not exactly what I had in mind but it does the trick :) (I was trying to set up an environment with two simple processors sending flow files to RPG

[GitHub] nifi pull request: NIFI-1863 extended caught exception in cleaning...

2016-05-09 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/428 NIFI-1863 extended caught exception in cleaning task for HTTPContextMap You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI

[GitHub] nifi pull request: NIFI-1816 Added provenance event SEND in Handle...

2016-05-07 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/389#issuecomment-217620180 @JPercivall Done. Let me know if I missed something. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request: NIFI-1814 Extended caught exceptions

2016-05-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/382#discussion_r62359879 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java

[GitHub] nifi pull request: NIFI-1814 Extended caught exceptions

2016-05-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/382#discussion_r62359651 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java

[GitHub] nifi pull request: NIFI-1732 Added timeout property to override 30...

2016-05-06 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/337#issuecomment-217500797 Thanks @JPercivall Few remarks: - when there is a timeout, what I observed is a request with a dispatcher type set to ERROR (I've never seen ASYNC s

[GitHub] nifi pull request: NIFI-1296, NIFI-1680, NIFI-1764, NIFI-1837, NIF...

2016-05-04 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/366#issuecomment-216917150 @olegz No problem ;) I was quite in a hurry and I understand why it is not clear at all. You are correct. By dumping topic content with Kafka CLI, I can

[GitHub] nifi pull request: NIFI-1296, NIFI-1680, NIFI-1764, NIFI-1837, NIF...

2016-05-04 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/366#issuecomment-216842191 I just played a little bit with the processors and here are some remarks: - Cosmetic remarks 1. add the duration in provenance events 2. add the number

[GitHub] nifi pull request: NIFI-1755 Fixed remote process group status cou...

2016-05-03 Thread pvillard31
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/347#issuecomment-216631894 @olegz I must admit I tried to use your code as mentioned in your link and got it working but I didn't find a way to validate the change since it seems to simulat

[GitHub] nifi pull request: NIFI-1806 Set file encoding to UTF-8 when runni...

2016-05-03 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1840 Added compression type property in Ki...

2016-05-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/409 NIFI-1840 Added compression type property in Kite processors You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-1840

  1   2   >