Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/613
NIFI-2157: Add GenerateTableFetch processor
NOTE: This PR depends on #599. I put the DB-specific stuff in an interface
and used ServiceLoader to get at them, but I welcome your comments perhaps on
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/601
+1 LGTM, ran all tests and manually verified error messages, etc. Merging
into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/601
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
+1 LGTM, merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
Ok sounds good. I gave the Integration Test thing (and the QueryCassandra
-- actually in AbstractCassandraProcessor) fix a try, the ITs don't work (yet)
but feel free to take a look:
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
@jeffoxenberg After your fix is applied, I tried a QueryCassandra to get
the values out of the table, and I'm getting a similar codec error then. Should
we edit the Jira to fix both cases, or d
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
@jeffoxenberg mind squashing your commits into one? Please and thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
You're right, we'd need some integration tests (possibly using
CassandraUnit) to show this. I will verify your change then merge as-is, we can
add an improvement Jira or something to add i
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
Can you put your template in a Gist? I'll give it a try too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
Were there quotes (single or double) in the real flow's value?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
I cherry-picked in the commits that added unit tests, to show that they
would fail without your fix, however they pass. Any idea how the tests differ
from the error that spawned the Jira?
---
If
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69357965
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
An example could be another test just like that one with cql.args.10.value
set to "I'm not a timestamp" or a timestamp not in ISO-8601 format like
"07.01.2016". Not sa
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69355805
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69355562
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69353249
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r6935
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69351536
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69351172
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69346410
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/602
Looks good, mind adding unit test(s) to try various good and bad values?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69325929
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/pom.xml
---
@@ -56,6 +56,11 @@ language governing permissions and
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320414
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319909
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319637
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319591
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69318800
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69318859
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69318666
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/pom.xml
---
@@ -56,6 +56,11 @@ language governing permissions and
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/599#discussion_r69224252
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/599#discussion_r69224117
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListDatabaseTables.java
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/599
NIFI-2156: Add ListDatabaseTables processor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2156
Alternatively you can
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/595
This PR appears to be a collection of merge commits, were you trying to
issue a PR with new code against the master branch? If so can you point me at
the commit, I can help get the PR into the
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/591
I found this, could it be a property of the dialog?
http://www.saxonica.com/documentation9.5/extensions/output-extras/indent-spaces.html
---
If your project is set up for it, you can reply to this
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/500
Also it looks like like you've got a merge commit in your chain here. Can
you start with a fresh master branch, apply your patch, then push the pull
request? If you have two commits, perhap
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/500
The file "NIFI-1922-patch" is included in this commit and should not be,
just the changes it implies (which have been applied). Can you remove this file
from the commit? Please and thanks
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68668099
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/576
Per an offline discussion with @JPercivall, Multi-Get and/or Search
capabilities are not really right for the FetchXYZ processor idiom. A better
solution may be a List/Search/Execute processor for
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/576
Yep will do!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/586
+1 LGTM, merged to 0.x and master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/534#discussion_r68438921
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/576
NIFI-2068: Add Elasticsearch HTTP processors
- Renamed original AbstractElasticsearchProcessor to
AbstractElasticsearchTransportClientProcessor, as a base class for the original
ES processors
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/558
+1 LGTM, tested with plenty of provenance events, verified the "Skipping
search" entry appeared in the log.
---
If your project is set up for it, you can reply to this email and have
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/550
+1 LGTM, reproduced the error then applied the patch and retested, verified
that a connection cannot be moved if its destination has active threads (even
if stopped).
---
If your project is set up
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/477#discussion_r68073235
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ConvertAvroToORC.java
---
@@ -0,0 +1,303
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/477#discussion_r68072879
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ConvertAvroToORC.java
---
@@ -0,0 +1,303
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/477#discussion_r68072906
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ConvertAvroToORC.java
---
@@ -0,0 +1,303
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/534#discussion_r67970007
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/550
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/254
@acesir Mind rebasing against the latest master? Please and thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/248#discussion_r67605391
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
---
@@ -154,75
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67562782
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,245
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/255
+1 LGTM, built and ran tests, also ran a few sample documents through the
flow to exercise the index, update, and upsert logic. Thanks for the
contribution! will merge to 0.x and master
---
If
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/397#discussion_r67451461
--- Diff:
nifi-nar-bundles/nifi-ocr-bundle/nifi-ocr-processors/src/test/resources/tessdata/tessconfigs/nobatch
---
@@ -0,0 +1 @@
+
--- End diff
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67392432
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,245
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/256
+1 LGTM, can you squash your commits into 1? should make it easier to
rebase (will need to change the version to 0.7.0-SNAPSHOT) unless after you
squash you want to issue another PR against 0.x? If
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67281209
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,243
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/255#discussion_r67277159
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/248#discussion_r67246009
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
---
@@ -154,75
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/458#discussion_r67230976
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java
---
@@ -0,0 +1,499
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/475
The arg part is useful for more than just this case, perhaps it could be
set to a more generic property such as "nifi.additional.java.args" or
something, and done as a separate i
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/475
The more I think about this, especially with the inclusion of
elements for specific vendors, I tend to agree with the settings.xml approach.
Should be easy to describe in a blog post or email to
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/475#discussion_r67174016
--- Diff:
nifi-nar-bundles/nifi-hadoop-libraries-bundle/nifi-hadoop-libraries-nar/pom.xml
---
@@ -21,19 +21,70 @@
true
true
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67162014
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,243
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/477
Just updated the POM to use Orc 1.1.1 (and changed the hard-coded version
to a property)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/475#discussion_r67157439
--- Diff: nifi-assembly/pom.xml ---
@@ -470,6 +470,15 @@ language governing permissions and limitations under
the License
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67039275
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,238
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67039181
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,238
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/248#discussion_r67017365
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
---
@@ -154,75
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67014112
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,238
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r67014211
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/PutSlack.java
---
@@ -0,0 +1,238
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/256
@adamonduty I will review. Can you rebase this against the latest master
branch? It can't be merged as-is. Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/508#discussion_r66990173
--- Diff: nifi-commons/nifi-security-utils/pom.xml ---
@@ -30,6 +30,21 @@
org.apache.commons
commons-lang3
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/508
+1 LGTM, built and ran with Java 7 and 8 on 0.x branch. Mind squashing the
commits? Then I'll merge to 0.x and master, thanks!
---
If your project is set up for it, you can reply to this emai
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/508#discussion_r66900343
--- Diff:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/CertificateUtilsTest.groovy
---
@@ -272,4 +275,179 @@ class
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/508#discussion_r66900061
--- Diff:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/CertificateUtilsTest.groovy
---
@@ -272,4 +275,179 @@ class
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/255
@joaohf will you have a chance to make the suggested updates? The PMC is
looking to cut a 0.7.0 release soon and are wondering if this ticket can/should
be included. Thanks!
---
If your project is
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/475
MapR against a MapR cluster, the client is ok and I used the same
*-site.xml files, although they are notably silent due to the need to install
the client. Do I need additional measures to add the
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/477
@omalley Thanks! I updated the version in the POM to 1.1.0 and force-pushed
the branch. Hopefully Travis will find the release JARs and complete
successfully :)
---
If your project is set up for
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/475
Do you mind filing a Jira case for this, and updating the PR title with the
Jira case number? It will make things easier to track, please and thanks!
I am having trouble with PutHDFS at the
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/521
NIFI-1998: Upgraded Cassandra driver to 3.0.2
This should apply cleanly to both master and 0.x branches
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/516
+1 LGTM, tested #515 with and without this commit, verified the test fails
without this commit. Merged to master
---
If your project is set up for it, you can reply to this email and have your
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/475
As an optional Maven build profile I would imagine it's ok but will defer
to @joewitt and others. In the meantime I will review and test this profile
(and its absence) against various Hadoop di
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/516
What's a good test? Successful build? Or something more?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/492
+1 LGTM, built and ran tests and contrib-check. Ran a NiFi flow with
multiple EVTX files exercising all relationships and granularities.
Great contribution, thanks much! Merging to master
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/492#discussion_r66292230
--- Diff:
nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/test/java/org/apache/nifi/processors/evtx/ParseEvtxTest.java
---
@@ -0,0 +1,318
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/510
+1 LGTM, built and ran tests, also started NiFi and tried various delete
operations including an attempt to delete a processor that had an incoming
connection. All behavior was as expected
---
If
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/492
The nifi-evtx-nar needs to be added to the top-level POM and the
nifi-assembly POM, otherwise it will not be included in the distro.
---
If your project is set up for it, you can reply to this
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/477
They're evaluating RC3 as of this writing, I will be doing the same but I
expect good results and an imminent release :)
---
If your project is set up for it, you can reply to this email and
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/505
+1 LGTM, tested it with and without command-line options, verified they are
passed to bower
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/504
+1 LGTM, tested on Apache and GitHub and tests are passing. Merging to 0.x
and master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/504
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/255#discussion_r66067616
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/248
I can continue the review on this one, mind rebasing against the latest
master or 0.x branch? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/492#discussion_r66000949
--- Diff:
nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java
---
@@ -0,0 +1,353
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/492#discussion_r66000706
--- Diff:
nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java
---
@@ -0,0 +1,353
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/492#discussion_r66000567
--- Diff:
nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java
---
@@ -0,0 +1,353
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/492#discussion_r66000431
--- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/pom.xml ---
@@ -0,0 +1,68 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmln
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/492#discussion_r66000380
--- Diff:
nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-nar/src/main/resources/META-INF/NOTICE
---
@@ -0,0 +1,36 @@
+nifi-evtx-nar
+Copyright 2016 The
1 - 100 of 247 matches
Mail list logo
