Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/563
This currently has conflicts with master and needs to be rebased before it
can be merged (sorry for taking so long to review the PR).
---
If your project is set up for it, you can reply to this
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69829659
--- Diff:
nifi-api/src/main/java/org/apache/nifi/components/state/ExternalStateManager.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69829390
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumeKafka.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69828743
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestGetKafka.java
---
@@ -166,4 +170,44
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69827581
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -481,4 +496,51
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69827217
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -218,11 +232,13
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r69827142
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
---
@@ -184,6 +195,9
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/563
@ijokarumawak I believe you're right about it only being Kafka. I looked
through them as well and couldn't find an instance of external state.
While surprised I am definitely hap
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/612
+1
Reviewed code, did a contrib check build, created a cluster to demonstrated
the problem and then recreated with the fix and the issue was resolved. Thanks
Mark will merge it in to 0.x
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69802769
--- Diff: minifi-docs/LICENSE ---
@@ -0,0 +1,235 @@
+
+ Apache License
+ Version
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69802803
--- Diff: LICENSE ---
@@ -0,0 +1,235 @@
+
+ Apache License
+ Version 2.0, January
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69802152
--- Diff: README.md ---
@@ -18,7 +18,100 @@ MiNiFi is a child project effort of Apache NiFi
## Table of Contents
+- [Features
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/29#discussion_r69801770
--- Diff: NOTICE ---
@@ -0,0 +1,9 @@
+Apache NiFi - MiNiFi
+Copyright 2014-2016 The Apache Software Foundation
+
+This product includes
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/576
+1
Did a contrib check build, reviewed the code and comments were addressed,
and did a functional test using vanilla ES as well as one secured with Shield.
Thanks for the contribution
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69745504
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69745293
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69603973
--- Diff: minifi-bootstrap/src/test/resources/Working_with_Logs.yml ---
@@ -0,0 +1,253 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69603609
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
---
@@ -0,0 +1,342
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69602801
--- Diff: minifi-toolkit/minifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,16 @@
+Apache NiFi
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/563
Starting to review.
Unless if I'm missing something, why is external state only added for
GetKafka and ConsumeKafka? Aren't there many other processors that manage state
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69586209
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69584216
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69582751
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69582549
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/24#discussion_r69504541
--- Diff:
minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/notifiers/util/TestRestChangeNotifierCommon.java
---
@@ -84,6
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/25
MINIFI-22 Removing lingering parts of UI
Most of this work was done with MINIFI-38 but there were still some
lingering transitive dependencies being brought in that needed to be removed
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/24
MINIFI-49 Made TestRestChangeNotifier upload file system independent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/23#discussion_r69399569
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java
---
@@ -228,6 +233,9 @@ public static void main(String
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/23#discussion_r69399521
--- Diff:
minifi-commons/minifi-utils/src/main/test/java/org/apache/nifi/minifi/commons/status/TestStatusReport.java
---
@@ -0,0 +1,88
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/23#discussion_r69399489
--- Diff:
minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/util/StatusReportPopulator.java
---
@@ -0,0 +1,375
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/23
MINIFI-38 Removing reliance on JettyServer in order to add a flow staâ¦
â¦tus reporting end point. This also removes the UI and adds a
'flowstatus' option to minifi.sh to get i
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69371933
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
---
@@ -0,0 +1,342
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69357651
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69352051
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/test/resources/Splunk_Processors_with_Listen_TCP.xml
---
@@ -0,0 +1,18
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69342080
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/test/resources/Splunk_Processors_with_Listen_TCP.xml
---
@@ -0,0 +1,18
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/576
It would be nice to have integration tests similar to those in the original
Fetch/PutElasticSearch processors.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69324539
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69323436
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320973
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320905
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320860
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69320695
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/pom.xml
---
@@ -56,6 +56,11 @@ language governing permissions and
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319929
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319708
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319479
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69319085
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69318837
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69318008
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317662
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317330
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317281
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69317035
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69316350
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69316019
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69314307
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69314193
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69313807
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69313182
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69312668
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69312240
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69311424
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69309177
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69308812
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69307262
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/576#discussion_r69306232
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/pom.xml
---
@@ -56,6 +56,11 @@ language governing permissions and
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69218372
--- Diff: minifi-commons/minifi-commons-schema/pom.xml ---
@@ -0,0 +1,46 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi=
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69214705
--- Diff: minifi-toolkit/minifi-toolkit-configuration/pom.xml ---
@@ -0,0 +1,42 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69210176
--- Diff:
minifi-toolkit/minifi-toolkit-assembly/src/main/resources/config.sh ---
@@ -0,0 +1,133 @@
+#!/bin/sh
+#
+#Licensed to the
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69180850
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java
---
@@ -15,13 +15,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69178841
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java
---
@@ -15,13 +15,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69166517
--- Diff: minifi-toolkit/minifi-toolkit-assembly/pom.xml ---
@@ -0,0 +1,68 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69165759
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/BaseSchema.java
---
@@ -15,13 +15,17
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69162642
--- Diff: minifi-toolkit/minifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,21 @@
+Apache NiFi
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69159093
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/SchemaLoader.java
---
@@ -0,0 +1,52
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/21#discussion_r69157552
--- Diff: minifi-commons/minifi-commons-schema/pom.xml ---
@@ -0,0 +1,46 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi=
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/525
+1
Did a contrib check build, reviewed the code and any comments were
addressed. To test I ran three ConsumeWindowsEventLog processors following
multiple Windows channels and did a query
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68943688
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68799710
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68785240
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68780468
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68780983
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68777286
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68671269
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68666289
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68666372
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r68660039
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/576
There have already been comments asking for a multi-get function for
ElasticSearch[1] could this be added to FetchElasticSearchHTTP now and be added
as a new feature to PutElasticSearch later
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/20
MINIFI-43 Fixing provenance instantiation and making some default conâ¦
â¦structors private to prevent same problem in other classes
I made the no parameter constructor private
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/19#discussion_r68591275
--- Diff: minifi-bootstrap/pom.xml ---
@@ -43,6 +43,10 @@ limitations under the License.
org.apache.nifi
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/586
NIFI-2118 Addresssing License/Notice issues in nifi-assumbly
Jython's license and notice information can be found here:
https://hg.python.org/jython/file/tip
Jolt's license ca
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/573
+1
Fixes errors seen on Windows, code looks good and passes contrib-check.
Thanks Mark
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user JPercivall closed the pull request at:
https://github.com/apache/nifi/pull/569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/569
Thanks @olegz, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user JPercivall closed the pull request at:
https://github.com/apache/nifi/pull/568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/568
Got it, thanks @olegz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/570
NIFI-2098 Adding ignore annotation to testManyFilesOpened unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi NIFI-2098
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/569
NIFI-2097 Changing RemoteProcessGroupStatusTest.java to use a random open
port ...
... instead of a statically defined one
You can merge this pull request into a Git repository by running
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/568
NIFI-2092 Fixing unit tests which try to clean up directories before â¦
â¦stopping the FlowController that has locks opened.
You can merge this pull request into a Git repository by running
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/548
+1
Comments addressed, builds and addresses issue. Thanks @brosander will
merge it into 0.x and master
---
If your project is set up for it, you can reply to this email and have your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/556
+1
I reviewed the code, built locally, analyzed ~25gb of randoms files with it
and it performed well. Looks good to me @jskora. Can you squash your commits
and merge it into 0.x and master
1 - 100 of 445 matches
Mail list logo
