Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-13 Thread Mark Hobson
2010/1/13 Peter Lynch : > Mark, I ran the apt plugin with java 5 and 6 on OSX with your changes and > all works well - tests pass. I also tested it on my other project. No > problems. The only caveat is I can't seem to reproduce the original bug > reliably so have no way of knowing If I will ever s

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-13 Thread Peter Lynch
Mark, I ran the apt plugin with java 5 and 6 on OSX with your changes and all works well - tests pass. I also tested it on my other project. No problems. The only caveat is I can't seem to reproduce the original bug reliably so have no way of knowing If I will ever see the problem again. I think yo

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-12 Thread Mark Hobson
2010/1/11 Mark Hobson : > Sure, for (1) we'd also need to change the tests to use CLASS_TREE > instead of SOURCE_TREE, which does pass locally.  I'll add a unit test > to exercise the -s sourceOutputDirectory option in conjunction with > SOURCE_TREE for (3). > > I'll continue with this in the morni

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-11 Thread Mark Hobson
2010/1/11 Peter Lynch : > Re 1, no. Just changing -s to -d fails 16 unit tests on my system - just > confirmed. Keeping -s and -d pointing to same directory does work fine ( as > in patch). It seems both must be set - or perhaps I am being fooled since > just -s is working at the moment too - ugh.

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-11 Thread Peter Lynch
On Mon, Jan 11, 2010 at 12:25 PM, Mark Hobson wrote: > Thanks for the info guys, just trying to understand what's happening here. > > I've just looked at the ant task [1] and the original bug [2] for > adding apt to ant. Their discussion of the 'preprocessdir' parameter > in the bug comments has

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-11 Thread Ryan Ahearn
That matches my understanding. I also answers why I was having issues that were fixed by adding -d, as I was only generating xml files, not any java files. mihobson wrote: > > Thanks for the info guys, just trying to understand what's happening here. > > I've just looked at the ant task [1]

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-11 Thread Mark Hobson
Thanks for the info guys, just trying to understand what's happening here. I've just looked at the ant task [1] and the original bug [2] for adding apt to ant. Their discussion of the 'preprocessdir' parameter in the bug comments has clarified the somewhat confusing distinction between -d and -s

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-11 Thread Peter Lynch
Mark, here is what I know so far about this problem. - only reproduced in Java 1.6, but not always - happened on Mac OSX 10.5 and WinXP cygwin from two different people - appears inconsistently - when it appears, simply running the existing integration tests for the apt plugin will reproduce the p

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-11 Thread Ryan Ahearn
OS: Win XP + cygwin 1.5.25 (i think) JVM: 1.6.0_14 Maven: 2.2.1 (r801777; 2009-08-06 15:16:01-0400) apt-maven-plugin checked out from http://svn.codehaus.org/mojo/tags/apt-maven-plugin-1.0-alpha-3 mihobson wrote: > > Ryan, what environment were you using in that stack trace you posted? > (OS,

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-11 Thread Mark Hobson
Ryan, what environment were you using in that stack trace you posted? (OS, JVM, Maven.) Mark 2010/1/6 Mark Hobson : > How strange, thanks for retrying Peter.  I'd rather not apply a patch > without it demonstrably fixing something as it just confuses the code. > > Cheers, > > Mark > > 2010/1/6 Pe

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-06 Thread Mark Hobson
How strange, thanks for retrying Peter. I'd rather not apply a patch without it demonstrably fixing something as it just confuses the code. Cheers, Mark 2010/1/6 Peter Lynch : > I just went back and tested 1.0-alpha-3 again on my project and for some > reason it works fine without any changes.

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-06 Thread Peter Lynch
I just went back and tested 1.0-alpha-3 again on my project and for some reason it works fine without any changes. This is really weird. Although I think the patch is harmless, I'll mark the issue as Closed, can't reproduce. Thanks. On Tue, Jan 5, 2010 at 4:31 PM, Mark Hobson wrote: > Hi Peter

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2010-01-05 Thread Mark Hobson
Hi Peter, Apologies for the late reply. I'm still unsure as to what problem you're trying to fix here. Can you supply details on how to reproduce it? I've been using this plugin successfully for a while now. Cheers, Mark 2009/12/17 Peter Lynch : > Hi Mark, thanks for taking interest in my tr

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2009-12-17 Thread Peter Lynch
Hi Mark, thanks for taking interest in my troubles. See my updates to the issue with a new patch. If you run the tests with the new patch applied then the changes get suitably exercised by the ITs. Preferably you can run it on something other than OSX to verify. Let me know if I can be of more he

Re: [mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2009-12-17 Thread Mark Hobson
Hi Peter, I've never had a problem with apt generating resources in the wrong directory. Can you attach an example test project to demonstrate the problem here? Cheers, Mark 2009/12/17 Peter Lynch : > Hi, > > I created jira http://jira.codehaus.org/browse/MOJO-1478 and provided the > patch to

[mojo-dev] [apt] requesting a patch apply and release MOJO-1478

2009-12-16 Thread Peter Lynch
Hi, I created jira http://jira.codehaus.org/browse/MOJO-1478 and provided the patch to fix it. I thought I'd post here asking if someone is able to apply the patch for me? I tried irc first... I am offering any help in this regard. Anything from applying the patch to doing a release of apt-mave