Re: [REVIEW REQUEST] Maven Wrapper JDK Auto-Download Enhancement

+1 and I love the idea! (Am on phone only, so cannot review for a few more days) On Wed, Jul 23, 2025, 20:46 Guillaume Nodet wrote: > Hi Maven team, > > I'd like to request a review for a new Maven Wrapper enhancement that adds > automatic JDK download capabilities. > > PR Details: https://git

Re: [REVIEW REQUEST] Maven Wrapper JDK Auto-Download Enhancement

The feature is using the Disco API. I can easily imagine providing a different REST endpoint, but it would have to have the same API. As for OS / architecture, the Disco api is used to discover a JDK package corresponding to the current OS/arch. Le jeu. 24 juil. 2025 à 11:17, Sergey Chernov a écr

Re: [REVIEW REQUEST] Maven Wrapper JDK Auto-Download Enhancement

Hi, It's a great feature. I didn't check all the code but I would say maybe there should be some warning (or prompt to ask user) about something (here a jdk) will be installed on the current machine. Perso, I wouldn't be happy about a jdk being installed locally without my consent. I did some tests

Re: [DISCUSS] Maven 4.0 Namespace Strategy - Breaking Change Timing Discussion

It helps that the consumer pom still uses the old namespace, but that's still not everything. Tools still need to analyze and understand the build pom, not just the consumer pom. For instance, organizations that are as paranoid about security as Google (and with good reason) build everything from s

Re: [DISCUSS] Maven 4.0 Namespace Strategy - Breaking Change Timing Discussion

On Thu, Jul 24, 2025, 09:36 Elliotte Rusty Harold wrote: > It helps that the consumer pom still uses the old namespace, but > that's still not everything. Tools still need to analyze and > understand the build pom, not just the consumer pom. For instance, > organizations that are as paranoid abou

Re: [DISCUSS] Maven 4.0 Namespace Strategy - Breaking Change Timing Discussion

If I understand correctly - consumer pom is for consumers that accept binary artefacts. So do security reasons, if someone decides to build it internally from sources - this will not work and still needs to accept different build pom styles. We are aiming for build reproducibility anyway. Sylweste

Re: [DISCUSS] Maven 4.0 Namespace Strategy - Breaking Change Timing Discussion

No, when building you have the consumer pom locally too and anyway if we say this is an issue we just revert everything and stay on 4.0.0 which is very unlikely for all the reason we are discussing maven 4 so not sure we have the choice to be frank. Romain Manni-Bucau @rmannibucau

Re: [DISCUSS] Maven 4.0 Namespace Strategy - Breaking Change Timing Discussion

I don't get what you're saying Romain. I think building a project from sources without using Maven is a bad idea, it kinda means reinventing maven. Processing the build POM without relying on Maven libraries is also a bad idea for the same reason. Even reading the consumer POM and rebuilding the d

Re: [REVIEW REQUEST] Maven Wrapper JDK Auto-Download Enhancement

Nice feature! I see it's possible to specify vendor, version or direct distribution URL. Is it possible to use an internal corporate registry (like Nexus or Artifactory) with JDK distributions supporting multiple platforms and CPU arch? How to configure this? On Wed, Jul 23, 2025 at 8:46 PM Guill

Re: [DISCUSS] Maven 4.0 Namespace Strategy - Breaking Change Timing Discussion

Not sure it changes anything, you can still build from source, get the consumer pom and parse it. What we should encourage for sure is to NOT do it for build pom within the project since now we can change it anytime for new features (hopefully not too often but we enabled it cause it was an issue).

Re: [DISCUSS] Maven 4.0 Namespace Strategy - Breaking Change Timing Discussion

Le jeu. 24 juil. 2025 à 17:11, Guillaume Nodet a écrit : > I don't get what you're saying Romain. > > I think building a project from sources without using Maven is a bad idea, > It is more consuming the pom without maven nor resolver, this is very common and has some good reasons. My point was