I solved interpolation of boolean values
(http://jira.codehaus.org/browse/MASSEMBLY-743) in modello 1.8.3 and
r1644916.
I just though I'd like to add that the "new" solution with injection
through the Xpp3Reader turned out to be a fair bit "simpler" than the
old ObjectInterpolator strategy, it tur
The extension I added to Xpp3Reader is simple and is not coupled to
any kind of specific external code and is just a general purpose
extension point.
Swizzle looks cool. I'm not entirely convinced interpolation at the
stream level will be entirely without a round of gotchas, various
forms of xml r
Wouldn't it be easier to add interpolation with something like:
Model model = MavenXpp3Reader.read(new MyFilterInputStream(inputStream));
Instead of adding interpolation into Modello?
Swizzle has lots of nice filtering implementations:
http://svn.codehaus.org/swizzle/trunk/swizzle-stream/src/ma
I fixed interpolation in modello for Xpp3reader.
http://jira.codehaus.org/browse/MODELLO-290. Build 1.8.3-SNAPSHOT from
git if you want to test it.
I'll play around with base class generation for a day or two before
releasing 1.8.3 (maybe 1.9)
K
2014-12-07 12:22 GMT+01:00 Hervé BOUTEMY :
>> Do
> Do you think this is feasible ?
we maintain the generator, so anything is feasible if it's valid java :)
one hard part is to demonstrate the code you intend to generate before hacking
the generator, because hacking the generator is always hard
And I didn't really get the idea yet.
> There is
I have been thinking about adding a "generateSuperclasses" option to
modello that would actually put the generated classes in a subpackage
"generated" and let the actual implementation be up to the client (so
in this case I would implement the class
org.apache.maven.plugin.assembly.model.Assembly w
I don't think this is a good idea: in general, a modello generated model
doesn't support interpolation.
but you're right: something should be done in case of a model with
interpolation support
Regards,
Hervé
Le samedi 6 décembre 2014 12:28:20 Kristian Rosenvold a écrit :
> Reading my own sugg
Reading my own suggestion: I was suggesting to change modello to
always back boolean fields with strings.
2014-12-06 12:21 GMT+01:00 Kristian Rosenvold :
> Looking at the implications of changing all the 30+ boolean fields of
> the assembly plugin to String, I really start thinking "what is the
>
Looking at the implications of changing all the 30+ boolean fields of
the assembly plugin to String, I really start thinking "what is the
point of code generation". It looks to me like we should at least just
globally change the backing datatype of "boolean" to String, and
generate overloads setXXX
Robert beat me at it :)
Regards,
Hervé
Le vendredi 5 décembre 2014 18:55:55 Robert Scholte a écrit :
> Hi Kristian,
>
> AFIAK this is indeed the only way to solve this.
> Visit http://maven.apache.org/ref/3.2.3/maven-model/maven.html and search
> for "Boolean". You'll find elements which are ac
Hi Kristian,
AFIAK this is indeed the only way to solve this.
Visit http://maven.apache.org/ref/3.2.3/maven-model/maven.html and search
for "Boolean". You'll find elements which are actually a Boolean, but are
a String for technical reasons. e.g. make it possible to interpolate them.
Robert
You should create an issue at http://jira.codehaus.org/browse/MASSEMBLY
Hervé/Others:
Since the attachement made it through, I took a quick look. The
problem is that the modello-generated assembly descriptor has a
"boolean" type for this value. Since the assembly descriptor
interpolation happens
12 matches
Mail list logo
