Re: Future of palantir / spotless in Maven

2025-01-05 Thread Benjamin Marwell
Absolutely! This was only about palantir, the java formatter. Spotless (the plugin running palantir) can also do XML etc., so we can keep that! :) At work, I have the format goal in validate or initialize phase or so, the CI runs `mvn spotless:check` before running `mvn verify` -- this way, clean

Re: Future of palantir / spotless in Maven

2024-12-30 Thread Matthias Bünger
Am 30.12.2024 um 08:55 schrieb Guillaume Nodet: Le dim. 29 déc. 2024 à 16:12, Benjamin Marwell a écrit : We could instead configure checkstyle to make sure the style is as intended. I'd rather remove all rules, than going back to a state where we have very strong rules without any easy way t

Re: Future of palantir / spotless in Maven

2024-12-29 Thread Guillaume Nodet
Le dim. 29 déc. 2024 à 16:12, Benjamin Marwell a écrit : > > We could instead configure checkstyle to make sure the style is as intended. I'd rather remove all rules, than going back to a state where we have very strong rules without any easy way to apply them. When you write/modify a few lines o

Re: Future of palantir / spotless in Maven

2024-12-29 Thread Piotr P. Karwasz
Hi Benjamin, On 21.12.2024 13:48, Benjamin Marwell wrote: Hi Piotr, any news on this? You said you reached out to your palantir contacts? The least they could do is to give access to some more devs... Sorry for the delay, I have relaunched my request for info on the project status. Piotr

Re: Future of palantir / spotless in Maven

2024-12-29 Thread Benjamin Marwell
We could instead configure checkstyle to make sure the style is as intended. But I would prefer to have a plugin formatting the code automatically for us, if it had no issues. And unless we start using text blocks and anonymous lambda parameters, we are not running into issues. Am Sa., 21. Dez. 2

Re: Future of palantir / spotless in Maven

2024-12-21 Thread Elliotte Rusty Harold
Can I pick all of the above? That is, avoid spotless, text blocks, and anonymous lambda parameters. They all have issues that independently make me prefer code without them. On Thu, Nov 28, 2024 at 7:31 PM Benjamin Marwell wrote: > > Hello everyone! > > Sadly, palantir-java-format, used in Maven

Re: Future of palantir / spotless in Maven

2024-12-21 Thread Benjamin Marwell
Hi Piotr, any news on this? You said you reached out to your palantir contacts? The least they could do is to give access to some more devs... Am Fr., 29. Nov. 2024 um 10:33 Uhr schrieb Piotr P. Karwasz : > > Hi Benjamin, > > On 28.11.2024 20:31, Benjamin Marwell wrote: > > I was not able to reac

Re: Future of palantir / spotless in Maven

2024-11-29 Thread Konrad Windszus
I am a bit worried by https://github.com/palantir/palantir-java-format/issues/735. Although I know that also the Google Formatter suffers from this, I am not sure how resilient that is with respect to future JDK updates. Konrad > On 29. Nov 2024, at 10:33, Piotr P. Karwasz wrote: > > Hi Benja

Re: Future of palantir / spotless in Maven

2024-11-29 Thread Piotr P. Karwasz
Hi Benjamin, On 28.11.2024 20:31, Benjamin Marwell wrote: I was not able to reach out to the maintainer. What should we do about it? I have reached out to my Palantir contacts to see what is going on with that project. Input is appreciated. I found palantir/spotless very valuable and I would

Re: Future of palantir / spotless in Maven

2024-11-29 Thread Benjamin Marwell
+1 Palantir is by far the best formatter out there. Any means to keep it would be desirable, in ANY way. Donation or forking would be feasible when the maintainer is not able to keep up or needs more help. Not trying to rip it away from them, more like the thought of offering help. Is there anyo

Re: Future of palantir / spotless in Maven

2024-11-28 Thread Guillaume Nodet
Le jeu. 28 nov. 2024 à 22:33, Mark Derricutt a écrit : > On 29 Nov 2024 at 8:58:20 AM, Guillaume Nodet wrote: > > > Or https://github.com/palantir/palantir-java-format/pull/935 > > > > Having posted on that ticket previously, it sounds like it’s just waiting > on being reviewed/merged, even tho

Re: Future of palantir / spotless in Maven

2024-11-28 Thread Mark Derricutt
On 29 Nov 2024 at 8:58:20 AM, Guillaume Nodet wrote: > Or https://github.com/palantir/palantir-java-format/pull/935 > Having posted on that ticket previously, it sounds like it’s just waiting on being reviewed/merged, even tho it sounds like others have been using it a lot already. I’d posted

Re: Future of palantir / spotless in Maven

2024-11-28 Thread Guillaume Nodet
Or https://github.com/palantir/palantir-java-format/pull/935 Le jeu. 28 nov. 2024 à 20:43, Guillaume Nodet a écrit : > We could switch to a better supported code formatter ? > Not removing spotless, but using another java formatter such as > google-java-format, eclipse jdt, clean-that... > See h

Re: Future of palantir / spotless in Maven

2024-11-28 Thread Guillaume Nodet
We could switch to a better supported code formatter ? Not removing spotless, but using another java formatter such as google-java-format, eclipse jdt, clean-that... See https://github.com/diffplug/spotless/tree/main/plugin-maven#java Le jeu. 28 nov. 2024 à 20:31, Benjamin Marwell a écrit : > He