Hi,
I shared comments on PR 337 and discussed it with gnodet, but I think
posting here may better catch the attention of core committers.
First of all, I think the JDK auto-download feature is a valuable
enhancement, but I do have a few concerns I'd like to highlight:
* Scope Creep & Naming
Mav
+1
Very nice feature for users.
> On Jul 23, 2025, at 2:46 PM, Guillaume Nodet wrote:
>
> Hi Maven team,
>
> I'd like to request a review for a new Maven Wrapper enhancement that adds
> automatic JDK download capabilities.
>
> PR Details: https://github.com/apache/maven-wrapper/pull/337
>
>
Hi,
It's a great feature.
I didn't check all the code but I would say maybe there should be some
warning (or prompt to ask user) about something (here a jdk) will be
installed on the current machine.
Perso, I wouldn't be happy about a jdk being installed locally without
my consent.
I did some tests
The feature is using the Disco API. I can easily imagine providing a
different REST endpoint, but it would have to have the same API.
As for OS / architecture, the Disco api is used to discover a JDK package
corresponding to the current OS/arch.
Le jeu. 24 juil. 2025 à 11:17, Sergey Chernov a
écr
Nice feature!
I see it's possible to specify vendor, version or direct distribution URL.
Is it possible to use an internal corporate registry (like Nexus or
Artifactory) with JDK distributions supporting multiple platforms and CPU
arch?
How to configure this?
On Wed, Jul 23, 2025 at 8:46 PM Guill
+1 and I love the idea!
(Am on phone only, so cannot review for a few more days)
On Wed, Jul 23, 2025, 20:46 Guillaume Nodet wrote:
> Hi Maven team,
>
> I'd like to request a review for a new Maven Wrapper enhancement that adds
> automatic JDK download capabilities.
>
> PR Details: https://git
Hi Maven team,
I'd like to request a review for a new Maven Wrapper enhancement that adds
automatic JDK download capabilities.
PR Details: https://github.com/apache/maven-wrapper/pull/337
This enhancement integrates the Foojay Disco API to automatically download
and install JDKs when they're no
