Re: Enabling changelog verifier

> I thought of making it an approval step, but that seemed too forceful. There are good arguments for it though. Maybe we run the bot as is for a couple weeks, see how we like it, and change it if we think an approval step would be better? IMO having it as an approval step is not at all forceful.

Re: Enabling changelog verifier

Thank you Ankit! I appreciate the observations, and yes, the workflow does also label PRs with milestones, so hopefully that would have helped with the PR you mentioned. > Instead of commenting, should it be a step in the approval workflow? Adding the skip label indicates explicit intent, and shou

Re: Enabling changelog verifier

Just noticed that the logic for adding target milestones using the changelog entry is already there. Nice, thanks! Created small PR for updating the skip-changelog label string - https://github.com/apache/lucene/pull/14661 On Tue, May 13, 2025 at 2:12 PM Ankit Jain wrote: > Thanks Stefan for ad

Re: Enabling changelog verifier

Thanks Stefan for adding this very useful workflow. Few observations: - Instead of commenting, should it be a step in the approval workflow? Adding the skip label indicates explicit intent, and should make the approval step succeed. - Really minor: skip-changelog-check is slightly verb

Re: Enabling changelog verifier

Thank you Stefan! On Mon, May 12, 2025 at 11:09 AM Stefan Vodita wrote: > Hi everyone, > > We've been working on a bot to look at PRs, check for a CHANGES entry ( > #13898 ), and determine > the milestone the PR belongs to (#14190 >

Enabling changelog verifier

Hi everyone, We've been working on a bot to look at PRs, check for a CHANGES entry ( #13898 ), and determine the milestone the PR belongs to (#14190 ). I got a few approvals to enable this bot in #14644