Re: Add maxFields Option to IndexWriter

Bump for a review on this small PR: https://github.com/apache/lucene-solr/pull/2231 Best, Oren On Thu, Jan 21, 2021 at 5:57 PM Oren Ovadia wrote: > I have a PR ready here: https://github.com/apache/lucene-solr/pull/2231 > Thanks in advance for taking a look. > > Is anyone game to help me back p

Re: Add maxFields Option to IndexWriter

I have a PR ready here: https://github.com/apache/lucene-solr/pull/2231 Thanks in advance for taking a look. Is anyone game to help me back port this to the upcoming minor version in 8.7? Thank you, Oren On Tue, Jan 19, 2021 at 5:56 PM Oren Ovadia wrote: > Thanks for the responses and advice.

Re: Add maxFields Option to IndexWriter

Thanks for the responses and advice. Un-deprecating sounds great, it solves our issue and gives us the flexibility to choose different strategies to deal with it (soft/hard limits etc.). Created LUCENE-9680 to track this, I'll have a patch ready

Re: Add maxFields Option to IndexWriter

I think it makes sense to un-deprecate that API (why did we deprecate it?), but I'm not sure IW should be in the business of soft/hard limits on field count? I agree such limits make sense if the integrity of the index is at risk, e.g. IW does enforce a max number of unique documents in one index.

Re: Add maxFields Option to IndexWriter

I like Oren's idea and Simon's proposal of unlimited by default but configurable. Marcus On Thu, Jan 14, 2021 at 12:16 AM Simon Willnauer wrote: > I personally have pretty positive experience with what I call softlimits. > At elastic we use them all over the place to catch issues when a user > l

Re: Add maxFields Option to IndexWriter

I personally have pretty positive experience with what I call softlimits. At elastic we use them all over the place to catch issues when a user likely misconfigures something or if there is likely a issue on the users end. I think having an option on the IW that allows to limit the fieldnumbers.

Re: Add maxFields Option to IndexWriter

I don't like the idea of IndexWriter limiting field names, but I do like the idea of un-deprecating that method, which appeared to have a trivial implementation. Try commenting on the issue of it's deprecations, which has various watchers to get their attention. ~ David Smiley Apache Lucene/Solr

Add maxFields Option to IndexWriter

Hi All, I work on Lucene at MongoDB. I would like to limit the amount of fields in an index to prevent tenants from causing a mapping explosion. Since IndexWriter.getFieldNames has been deprecated , there is no way to do this without using a rea