Thanks Adrien, that makes sense. I was wondering how we'd ensure all API
breakages in a major release were covered with deprecation messages. Sounds
like this is the answer.
Cheers,
-Greg
On Thu, Nov 30, 2023 at 11:14 AM Adrien Grand wrote:
> My expectation is that we will do a 9.x minor at abo
My expectation is that we will do a 9.x minor at about the same time as
10.0 anyway, this is what we have done in the past for new majors. This
will give an opportunity to make sure we have deprecation warnings for all
breaking changes in 10.0.
Le jeu. 30 nov. 2023, 10:43, Chris Hegarty
a écrit :
> Thanks for raising the issue. I don’t have a strong opinion on whether or
not to do the deprecation in this release, and since you say that it is
minor, then I don’t see that it necessitates another respin. Since I had
already started an RC2 build, then I just continued with it (and since the
abo
For clarity, consider this vote cancelled. A new vote has been started on an
RC2 build.
> On 30 Nov 2023, at 16:22, Greg Miller wrote:
>
> If we're spinning a new RC, I'd like to ask this group if it would make sense
> to pull this very small method deprecation in:
> https://github.com/apache
OK, great. I wanted to post a +1 already. Will wait for 2nd RC.
Uwe
Am 30.11.2023 um 16:38 schrieb Michael McCandless:
On Thu, Nov 30, 2023 at 9:56 AM Chris Hegarty
wrote:
P.S. I’m less sure about this, but the RC 2 starts a 72hr voting
time again? (Just so I know what TTL to put on
If we're spinning a new RC, I'd like to ask this group if it would make
sense to pull this very small method deprecation in:
https://github.com/apache/lucene/pull/12854
If there's a chance we don't release a 9.10 and go directly to 10.0, this
would be our last opportunity to mark it deprecated on
for the sake of posterity, I did get a successful smoketest:
SUCCESS! [1:00:06.512261]
but +0 to release I guess since it's moot...
On Thu, Nov 30, 2023 at 10:38 AM Michael McCandless <
luc...@mikemccandless.com> wrote:
> On Thu, Nov 30, 2023 at 9:56 AM Chris Hegarty
> wrote:
>
> P.S. I’m less
On Thu, Nov 30, 2023 at 9:56 AM Chris Hegarty
wrote:
P.S. I’m less sure about this, but the RC 2 starts a 72hr voting time
> again? (Just so I know what TTL to put on that)
>
Yeah a new 72 hour clock starts with each new RC :)
Mike McCandless
http://blog.mikemccandless.com
Adrien,
> On 30 Nov 2023, at 14:51, Adrien Grand wrote:
>
> Yet another bug due to ghost fields. :( Thanks for fixing! For reference, I
> checked how postings work on SlowCompositeCodecReaderWrapper, since they are
> prone to ghost fields as well, and they seem to be ok.
Thanks for checking t
Yet another bug due to ghost fields. :( Thanks for fixing! For reference, I
checked how postings work on SlowCompositeCodecReaderWrapper, since they
are prone to ghost fields as well, and they seem to be ok.
I worry that it could actually occur in practice when enabling recursive
graph bisection,
SUCCESS! [0:33:10.432870]
+1
On Thu, Nov 30, 2023 at 2:59 PM Chris Hegarty
wrote:
> Hi Mike,
>
> On 30 Nov 2023, at 11:41, Michael McCandless
> wrote:
>
> +1 to release.
>
> I hit a corner-case test failure and opened a PR to fix it:
> https://github.com/apache/lucene/pull/12859
>
>
> Good fin
Hi Mike,
> On 30 Nov 2023, at 11:41, Michael McCandless
> wrote:
>
> +1 to release.
>
> I hit a corner-case test failure and opened a PR to fix it:
> https://github.com/apache/lucene/pull/12859
Good find! It looks like the fix for this issue is well in hand - great.
> I don't think this sh
SUCCESS! [0:47:11.013106]
+1
On Thu, Nov 30, 2023 at 7:16 AM Ignacio Vera wrote:
> SUCCESS! [0:52:59.891964]
>
>
> +1
>
> On Thu, Nov 30, 2023 at 12:42 PM Michael McCandless <
> luc...@mikemccandless.com> wrote:
>
>> +1 to release.
>>
>> I hit a corner-case test failure and opened a PR to fix i
SUCCESS! [0:52:59.891964]
+1
On Thu, Nov 30, 2023 at 12:42 PM Michael McCandless <
luc...@mikemccandless.com> wrote:
> +1 to release.
>
> I hit a corner-case test failure and opened a PR to fix it:
> https://github.com/apache/lucene/pull/12859
>
> I don't think this should block the release? --
+1 to release.
I hit a corner-case test failure and opened a PR to fix it:
https://github.com/apache/lucene/pull/12859
I don't think this should block the release? -- it looks exotic.
Thanks Chris!
Mike McCandless
http://blog.mikemccandless.com
On Thu, Nov 30, 2023 at 1:16 AM Patrick Zhai w
SUCCESS! [1:03:54.880200]
+1. Thank you Chris!
On Wed, Nov 29, 2023 at 8:45 PM Nhat Nguyen
wrote:
> SUCCESS! [1:11:30.037919]
>
> +1. Thanks, Chris!
>
> On Wed, Nov 29, 2023 at 8:53 AM Chris Hegarty
> wrote:
>
>> Hi,
>>
>>
>> Please vote for release candidate 1 for Lucene 9.9.0
>>
>>
>> The ar
SUCCESS! [1:11:30.037919]
+1. Thanks, Chris!
On Wed, Nov 29, 2023 at 8:53 AM Chris Hegarty
wrote:
> Hi,
>
>
> Please vote for release candidate 1 for Lucene 9.9.0
>
>
> The artifacts can be downloaded from:
>
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.9.0-RC1-rev-92a5e5b02e0e083
Hi,
Please vote for release candidate 1 for Lucene 9.9.0
The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.9.0-RC1-rev-92a5e5b02e0e083126c4122f2b7a02426c21a037
You can run the smoke tester directly with this command:
python3 -u dev-tools/scripts/smokeT
18 matches
Mail list logo
