[GitHub] lucene-solr pull request #455: SOLR-12638

2018-11-28 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r237364758 --- Diff: solr/core/src/test/org/apache/solr/cloud/AtomicUpdateBlockShardedTest.java --- @@ -130,7 +130,7 @@ public void doNestedInplaceUpdateTest() th

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-11-07 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r231567341 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -1164,6 +1225,31 @@ public void processGetUpdates(Respo

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-11-07 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r231566214 --- Diff: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java --- @@ -259,9 +264,8 @@ public boolean doInPlaceUpdateMer

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-11-06 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r231127727 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -639,12 +651,32 @@ public static SolrInputDocument get

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-27 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r228734114 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -609,9 +618,11 @@ public static SolrInputDocument get

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-25 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r228197896 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -609,9 +618,10 @@ public static SolrInputDocument getI

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-25 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r228174440 --- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java --- @@ -262,6 +263,11 @@ private void flattenAnonymous(List unwrappedDocs, So

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-24 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r228032204 --- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java --- @@ -262,6 +263,11 @@ private void flattenAnonymous(List unwrappedDocs, S

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-24 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r228026284 --- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java --- @@ -262,6 +263,11 @@ private void flattenAnonymous(List unwrappedDocs, So

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-21 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r226858107 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -59,39 +52,147 @@ public void before() {

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-19 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r226709714 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -59,39 +52,147 @@ public void before() { @

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-19 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r226709264 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -59,39 +52,147 @@ public void before() { @

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224133917 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache S

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224127559 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache S

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r223747918 --- Diff: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java --- @@ -442,5 +442,58 @@ protected void doRemoveRegex(Sol

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224306158 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -639,12 +650,30 @@ public static SolrInputDocument get

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224306892 --- Diff: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java --- @@ -1360,24 +1385,47 @@ boolean getUpdatedDocument(Ad

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r223747455 --- Diff: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java --- @@ -442,5 +442,58 @@ protected void doRemoveRegex(Sol

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224307768 --- Diff: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java --- @@ -1360,24 +1385,47 @@ boolean getUpdatedDocument(Ad

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224306195 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -661,6 +690,21 @@ public static SolrInputDocument getI

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224209409 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache S

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224283996 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -609,9 +618,10 @@ public static SolrInputDocument getI

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224300831 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -639,12 +650,30 @@ public static SolrInputDocument get

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224130315 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache S

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r223749656 --- Diff: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java --- @@ -111,6 +114,8 @@ public static final String

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224131263 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache S

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r224131571 --- Diff: solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java --- @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache S

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-10-09 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/455#discussion_r223741723 --- Diff: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java --- @@ -461,5 +466,33 @@ private static boolean isChildD

[GitHub] lucene-solr pull request #455: SOLR-12638

2018-09-17 Thread moshebla
GitHub user moshebla opened a pull request: https://github.com/apache/lucene-solr/pull/455 SOLR-12638 You can merge this pull request into a Git repository by running: $ git pull https://github.com/moshebla/lucene-solr SOLR-12638 Alternatively you can review and apply these c