[GitHub] lucene-solr pull request #486: SOLR-12801: Fix the tests, remove BadApples a...

2018-10-30 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/486#discussion_r229523672 --- Diff: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java --- @@ -265,10 +281,30 @@ public MiniSolrCloudCluster(int

[GitHub] lucene-solr pull request #486: SOLR-12801: Fix the tests, remove BadApples a...

2018-10-30 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/486#discussion_r229522519 --- Diff: solr/core/src/test-files/solr/solr.xml --- @@ -40,12 +40,12 @@ 127.0.0.1 ${hostPort:8983} ${hostContext:solr

[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...

2018-10-25 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/483#discussion_r228304003 --- Diff: solr/core/src/java/org/apache/solr/update/processor/LogUpdateProcessorFactory.java --- @@ -187,12 +190,23 @@ public void finish() throws

[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...

2018-10-25 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/483#discussion_r228301278 --- Diff: solr/server/resources/log4j2.xml --- @@ -67,6 +67,10 @@ + + --- End diff -- Is

[GitHub] lucene-solr issue #477: Block Expensive Queries custom component

2018-10-25 Thread vthacker
Github user vthacker commented on the issue: https://github.com/apache/lucene-solr/pull/477 Hi Tirth, It would be great if we could have a test case for this. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] lucene-solr pull request #477: Block Expensive Queries custom component

2018-10-25 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/477#discussion_r228296662 --- Diff: solr/core/src/java/org/apache/solr/search/BlockExpensiveQueries.java --- @@ -0,0 +1,99 @@ +package org.apache.solr.search

[GitHub] lucene-solr issue #477: Block Expensive Queries custom component

2018-10-17 Thread vthacker
Github user vthacker commented on the issue: https://github.com/apache/lucene-solr/pull/477 Hi @tirthmehta1994 I see you've created 3+ PRs with patches on issues. Would you mind creating a solr Jira for each of them ( http://issues.apache.org/jira/browse/SOLR ), putt

[GitHub] lucene-solr pull request #402: SOLR-12477 - Return server error(500) for Alr...

2018-07-27 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/402#discussion_r205929735 --- Diff: solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java --- @@ -208,14 +208,17 @@ public void handleRequest(SolrQueryRequest req

[GitHub] lucene-solr pull request #402: SOLR-12477 - Return server error(500) for Alr...

2018-07-27 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/402#discussion_r205929654 --- Diff: solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java --- @@ -208,14 +208,17 @@ public void handleRequest(SolrQueryRequest req

[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...

2018-03-13 Thread vthacker
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/287#discussion_r174149233 --- Diff: dev-tools/eclipse/dot.classpath.xsl --- @@ -54,7 +55,23 @@ - + --- End diff