Re: PackedInts functionalities

2023-10-16 Thread Mikhail Khludnev
Hello Tony Is it possible to write a block of docfreqs and then a block of postingoffsets? Or why not write them as 10-bit integers and then split to quad and sextet in the posting format code? On Mon, Oct 16, 2023 at 11:50 PM Dongyu Xu wrote: > Hi devs, > > As I was working on https://github.co

PackedInts functionalities

2023-10-16 Thread Dongyu Xu
Hi devs, As I was working on https://github.com/apache/lucene/issues/12513 I needed to compress positive integers which are used to locate postings etc. To put it concretely, I will need to pack a few values per term contiguously and those values can have different bit-width. For example, consi

Re: Can we get rid of "Approve & Run" on GitHub PRs by new contributors (non-committers)?

2023-10-16 Thread Dawid Weiss
I filed a PR here - https://github.com/apache/lucene/pull/12687 Dawid On Mon, Oct 16, 2023 at 7:53 PM Dawid Weiss wrote: > > It's actually as simple as adding: > > timeout-minutes: xyz > > to workflows. > > > https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-acti

Re: Can we get rid of "Approve & Run" on GitHub PRs by new contributors (non-committers)?

2023-10-16 Thread Dawid Weiss
It's actually as simple as adding: timeout-minutes: xyz to workflows. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes I use it elsewhere for jobs on Windows because they tend to hang sometimes (for reasons unknown to me). Dawi

Re: Can we get rid of "Approve & Run" on GitHub PRs by new contributors (non-committers)?

2023-10-16 Thread Robert Muir
I think running the builds with a timeout is a good thing to do anyway, for any CI build. I'm sure github actions has some fancy yaml for that, but you can just do "timeout -k 1m 1h ./gradlew..." instead of "./gradlew" too. On Mon, Oct 16, 2023 at 9:58 AM Michael McCandless wrote: > > When a non-

Re: Can we get rid of "Approve & Run" on GitHub PRs by new contributors (non-committers)?

2023-10-16 Thread Uwe Schindler
Hi, this seems to be a safety feature and is also enabled in general for Github. I found no options in asf.yaml to enable/disable it: https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-GitHubsettings You can only add some users to a whitelist of "c

Can we get rid of "Approve & Run" on GitHub PRs by new contributors (non-committers)?

2023-10-16 Thread Michael McCandless
When a non-committer (I think?) opens a PR, one of the committers must notice it and click Approve & Run so the contributor can find out if something broke in our automated tests/precommit/linting. This seems like a waste, and a friction in the worst possible place for our community: new contribut

Re: Multimodal search

2023-10-16 Thread Michael Wechner
btw, here are some other examples of hybrid search implementations, using RRF https://weaviate.io/blog/hybrid-search-explained https://learn.microsoft.com/en-us/azure/search/hybrid-search-ranking https://www.elastic.co/guide/en/elasticsearch/reference/current/rrf.html but as written below, I do