Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-15 Thread Gary Gregory
I've had to use this plugin in the past. I'm glad to hear of this agreement!: -) Gary On Fri, Oct 15, 2021, 06:42 Volkan Yazıcı wrote: > I have gotten in touch with the author of the > maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly > accepted to contribute this plugin i

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-15 Thread Carter Kozak
This sounds great. Thanks, Volkan! -ck > On Oct 15, 2021, at 6:42 AM, Volkan Yazıcı wrote: > > I have gotten in touch with the author of the > maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly > accepted to contribute this plugin in the form of a PR to the project. I > ga

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-15 Thread Volkan Yazıcı
I have gotten in touch with the author of the maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly accepted to contribute this plugin in the form of a PR to the project. I gave him a briefing about the ICLA, Jira ticket, GitHub PR, etc. process and told him to first send an email

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Matt Sicker
The 3.x code loads plugins from generated Java classes that correspond to ServiceLoader-loadable classes. Since each jar tends to end up with their generated plugin class going into different package names, the result of shading them together works naturally with combining the META-INF/services/ fi

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Volkan Yazıcı
It works on `master`. Matt, mind shedding some light on why it works on `master`, but doesn't on `release-2.x`? Maybe we can backport the trick on `master` to `release-2.x`? On Wed, Oct 13, 2021 at 4:05 PM Apache wrote: > We could include it in Log4J. Does master work out of the box? > > Ralph >

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Apache
We could include it in Log4J. Does master work out of the box? Ralph > On Oct 13, 2021, at 12:23 AM, Volkan Yazıcı wrote: > >  > I have done something really nasty in the release-2.x branch to fix > benchmarks.jar generated by log4j-perf. Since a picture is worth a thousand > words, I am sha

broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Volkan Yazıcı
I have done something really nasty in the release-2.x branch to fix benchmarks.jar generated by log4j-perf. Since a picture is worth a thousand words, I am sharing two: [image: image.png] [image: image.png] (In case images get truncated, see commit 4049240c.) In a nutshell, Log4j2Plugins.dat of t