Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

2019-04-22 Thread sapiensy
Hi Konstantine, Randall, As you can see in the updated Converter interface, it always operates on `org.apache.kafka.common.header.Headers`. WorkerSinkTask simply uses Kafka message headers and passes them to the `toConnectData` method. WorkerSourceTask leverages header converter to extract Re

Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

2019-04-25 Thread sapiensy
Hi Randall, Konstantine, I've updated the KIP to reflect the details we discussed here. Let me know if it looks good and we can go to the voting phase. Thanks! On 2019/04/22 21:07:31, Randall Hauch wrote: > I think it would be helpful to clarify this in the KIP, just so that > readers are awa

Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

2019-05-06 Thread sapiensy
Hi Randall, Sorry, I was away. Just started a vote a few minutes ago. On 2019/05/06 17:46:23, Randall Hauch wrote: > Have we started a vote on this? I don't see the separate "[VOTE]" thread. > > On Mon, Apr 29, 2019 at 6:19 PM Konstantine Karantasis < > konstant...@confluent.io> wrote: > > >

Re: [VOTE] KIP-440: Extend Connect Converter to support headers

2019-05-31 Thread sapiensy
Hey everyone, just bumping this thread again. We need one more vote from the committers. Thanks! :) On 2019/05/19 14:31:15, Kamal Chandraprakash wrote: > +1 (non-binding). Thanks for the KIP! > > On Sun, May 19, 2019 at 6:36 PM Dongjin Lee wrote: > > > +1 (non-binding). > > > > Binding: +2

Re: [VOTE] KIP-440: Extend Connect Converter to support headers

2019-08-21 Thread sapiensy
Thanks everyone! Closing the vote with +7 (+3 binding). On 2019/08/21 13:41:34, Bill Bejeck wrote: > Thanks for the KIP! This looks like a valuable addition. > > +1(binding) > > -Bill > > On Mon, Aug 5, 2019 at 6:15 PM Ryanne Dolan wrote: > > > +1, non-binding > > > > Ryanne > > > > On Mon